From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 3/4] xfs/122: add the new v5 bulkstat/inumbers ioctl structures
Date: Wed, 31 Jul 2019 07:40:20 -0400 [thread overview]
Message-ID: <20190731114019.GB34040@bfoster> (raw)
In-Reply-To: <156394161274.1850833.4300015313269610610.stgit@magnolia>
On Tue, Jul 23, 2019 at 09:13:32PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The new v5 bulkstat and inumbers structures are correctly padded so that
> no format changes are necessary across platforms, so add them to the
> output.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/122.out | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>
> diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> index cf9ac9e2..e2f346eb 100644
> --- a/tests/xfs/122.out
> +++ b/tests/xfs/122.out
> @@ -66,6 +66,10 @@ sizeof(struct xfs_btree_block_lhdr) = 64
> sizeof(struct xfs_btree_block_shdr) = 48
> sizeof(struct xfs_bud_log_format) = 16
> sizeof(struct xfs_bui_log_format) = 16
> +sizeof(struct xfs_bulk_ireq) = 64
> +sizeof(struct xfs_bulkstat) = 192
> +sizeof(struct xfs_bulkstat_req) = 64
> +sizeof(struct xfs_bulkstat_single_req) = 224
> sizeof(struct xfs_clone_args) = 32
> sizeof(struct xfs_cud_log_format) = 16
> sizeof(struct xfs_cui_log_format) = 16
> @@ -89,6 +93,9 @@ sizeof(struct xfs_fsop_geom_v4) = 112
> sizeof(struct xfs_icreate_log) = 28
> sizeof(struct xfs_inode_log_format) = 56
> sizeof(struct xfs_inode_log_format_32) = 52
> +sizeof(struct xfs_inumbers) = 24
> +sizeof(struct xfs_inumbers_req) = 64
> +sizeof(struct xfs_ireq) = 32
I don't see xfs_bulkstat_single_req or xfs_ireq in the latest kernel
headers. Do we still have those? Otherwise looks fine.
Brian
> sizeof(struct xfs_log_dinode) = 176
> sizeof(struct xfs_map_extent) = 32
> sizeof(struct xfs_phys_extent) = 16
>
next prev parent reply other threads:[~2019-07-31 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 4:13 [PATCH 0/4] xfs: fixes and new tests for bulkstat v5 Darrick J. Wong
2019-07-24 4:13 ` [PATCH 1/4] xfs/122: ignore inode geometry structure Darrick J. Wong
2019-07-31 11:43 ` Brian Foster
2019-07-24 4:13 ` [PATCH 2/4] xfs/122: mask wonky ioctls Darrick J. Wong
2019-07-31 11:43 ` Brian Foster
2019-07-24 4:13 ` [PATCH 3/4] xfs/122: add the new v5 bulkstat/inumbers ioctl structures Darrick J. Wong
2019-07-31 11:40 ` Brian Foster [this message]
2019-07-31 16:08 ` Darrick J. Wong
2019-07-24 4:13 ` [PATCH 4/4] xfs: test new v5 bulkstat commands Darrick J. Wong
2019-07-31 11:43 ` Brian Foster
2019-07-31 16:44 ` Darrick J. Wong
2019-07-31 17:12 ` Brian Foster
2019-07-28 11:26 ` [PATCH 0/4] xfs: fixes and new tests for bulkstat v5 Eryu Guan
2019-07-30 0:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731114019.GB34040@bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.