From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 2/4] xfs/122: mask wonky ioctls
Date: Wed, 31 Jul 2019 07:43:38 -0400 [thread overview]
Message-ID: <20190731114337.GE34040@bfoster> (raw)
In-Reply-To: <156394160665.1850833.14349327556274532970.stgit@magnolia>
On Tue, Jul 23, 2019 at 09:13:26PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Don't check the structure size of the inogrp/bstat/fsop_bulkreq
> structures because they're incorrectly padded. When we remove the
> old typdefs the old filter stops working.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> tests/xfs/122 | 3 +++
> 1 file changed, 3 insertions(+)
>
>
> diff --git a/tests/xfs/122 b/tests/xfs/122
> index 89a39a23..64b63cb1 100755
> --- a/tests/xfs/122
> +++ b/tests/xfs/122
> @@ -148,12 +148,15 @@ xfs_growfs_data_t
> xfs_growfs_rt_t
> xfs_bstime_t
> xfs_bstat_t
> +struct xfs_bstat
> xfs_fsop_bulkreq_t
> +struct xfs_fsop_bulkreq
> xfs_icsb_cnts_t
> xfs_icdinode_t
> xfs_ictimestamp_t
> xfs_inobt_rec_incore_t
> xfs_inogrp_t
> +struct xfs_inogrp
> xfs_fid2_t
> xfs_fsop_handlereq_t
> xfs_fsop_setdm_handlereq_t
>
next prev parent reply other threads:[~2019-07-31 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 4:13 [PATCH 0/4] xfs: fixes and new tests for bulkstat v5 Darrick J. Wong
2019-07-24 4:13 ` [PATCH 1/4] xfs/122: ignore inode geometry structure Darrick J. Wong
2019-07-31 11:43 ` Brian Foster
2019-07-24 4:13 ` [PATCH 2/4] xfs/122: mask wonky ioctls Darrick J. Wong
2019-07-31 11:43 ` Brian Foster [this message]
2019-07-24 4:13 ` [PATCH 3/4] xfs/122: add the new v5 bulkstat/inumbers ioctl structures Darrick J. Wong
2019-07-31 11:40 ` Brian Foster
2019-07-31 16:08 ` Darrick J. Wong
2019-07-24 4:13 ` [PATCH 4/4] xfs: test new v5 bulkstat commands Darrick J. Wong
2019-07-31 11:43 ` Brian Foster
2019-07-31 16:44 ` Darrick J. Wong
2019-07-31 17:12 ` Brian Foster
2019-07-28 11:26 ` [PATCH 0/4] xfs: fixes and new tests for bulkstat v5 Eryu Guan
2019-07-30 0:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731114337.GE34040@bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.