All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Khem Raj <raj.khem@gmail.com>
Cc: Yocto Project <yocto@yoctoproject.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: [yocto] [yocto-docs][PATCH] ref-manual: Remove documentation for the removed gnome class
Date: Wed, 31 Jul 2019 17:47:58 +0300	[thread overview]
Message-ID: <20190731144758.GC1647@localhost> (raw)
In-Reply-To: <CAMKF1sriCokV8j2TsVva1DbxBnoe3q84cd=XXXaLpv6aHhLT-A@mail.gmail.com>

On Wed, Jul 31, 2019 at 07:33:37AM -0700, Khem Raj wrote:
> On Wed, Jul 31, 2019 at 6:30 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > When removed all it did was
> >   inherit gnomebase gtk-icon-cache gconf mime
> > which would also be the most trivial replacement.
> >
> > Most of the time not all of these classes were needed,
> > and it is recommended to use only the ones actually required.
> >
> 
> This should go to oe-core ml as well.

Added to Cc.

> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > ---
> >  documentation/ref-manual/ref-classes.xml | 15 ---------------
> >  1 file changed, 15 deletions(-)
> >
> > diff --git a/documentation/ref-manual/ref-classes.xml b/documentation/ref-manual/ref-classes.xml
> > index 37619e382d..5403f20b6f 100644
> > --- a/documentation/ref-manual/ref-classes.xml
> > +++ b/documentation/ref-manual/ref-classes.xml
> > @@ -920,21 +920,6 @@
> >      </para>
> >  </section>
> >
> > -<section id='ref-classes-gnome'>
> > -    <title><filename>gnome.bbclass</filename></title>
> > -
> > -    <para>
> > -        The <filename>gnome</filename> class supports recipes that
> > -        build software from the GNOME stack.
> > -        This class inherits the
> > -        <link linkend='ref-classes-gnomebase'><filename>gnomebase</filename></link>,
> > -        <link linkend='ref-classes-gtk-icon-cache'><filename>gtk-icon-cache</filename></link>,
> > -        <link linkend='ref-classes-gconf'><filename>gconf</filename></link> and
> > -        <link linkend='ref-classes-mime'><filename>mime</filename></link> classes.
> > -        The class also disables GObject introspection where applicable.
> > -    </para>
> > -</section>
> > -
> 
> do we need to enhance the documentation for gnomebase bbclass to
> mention about disabling  gobject introspection
> or is it handled differently now.
>...

This part of the documentation had been wrong for 3-4 years.

The gobject introspection disabling was moved to the gnomebase class
back in 2015.

In 2016 the gnomebase class stopped disabling gobject introspection.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Khem Raj <raj.khem@gmail.com>
Cc: Yocto Project <yocto@yoctoproject.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: [yocto-docs][PATCH] ref-manual: Remove documentation for the removed gnome class
Date: Wed, 31 Jul 2019 17:47:58 +0300	[thread overview]
Message-ID: <20190731144758.GC1647@localhost> (raw)
In-Reply-To: <CAMKF1sriCokV8j2TsVva1DbxBnoe3q84cd=XXXaLpv6aHhLT-A@mail.gmail.com>

On Wed, Jul 31, 2019 at 07:33:37AM -0700, Khem Raj wrote:
> On Wed, Jul 31, 2019 at 6:30 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > When removed all it did was
> >   inherit gnomebase gtk-icon-cache gconf mime
> > which would also be the most trivial replacement.
> >
> > Most of the time not all of these classes were needed,
> > and it is recommended to use only the ones actually required.
> >
> 
> This should go to oe-core ml as well.

Added to Cc.

> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > ---
> >  documentation/ref-manual/ref-classes.xml | 15 ---------------
> >  1 file changed, 15 deletions(-)
> >
> > diff --git a/documentation/ref-manual/ref-classes.xml b/documentation/ref-manual/ref-classes.xml
> > index 37619e382d..5403f20b6f 100644
> > --- a/documentation/ref-manual/ref-classes.xml
> > +++ b/documentation/ref-manual/ref-classes.xml
> > @@ -920,21 +920,6 @@
> >      </para>
> >  </section>
> >
> > -<section id='ref-classes-gnome'>
> > -    <title><filename>gnome.bbclass</filename></title>
> > -
> > -    <para>
> > -        The <filename>gnome</filename> class supports recipes that
> > -        build software from the GNOME stack.
> > -        This class inherits the
> > -        <link linkend='ref-classes-gnomebase'><filename>gnomebase</filename></link>,
> > -        <link linkend='ref-classes-gtk-icon-cache'><filename>gtk-icon-cache</filename></link>,
> > -        <link linkend='ref-classes-gconf'><filename>gconf</filename></link> and
> > -        <link linkend='ref-classes-mime'><filename>mime</filename></link> classes.
> > -        The class also disables GObject introspection where applicable.
> > -    </para>
> > -</section>
> > -
> 
> do we need to enhance the documentation for gnomebase bbclass to
> mention about disabling  gobject introspection
> or is it handled differently now.
>...

This part of the documentation had been wrong for 3-4 years.

The gobject introspection disabling was moved to the gnomebase class
back in 2015.

In 2016 the gnomebase class stopped disabling gobject introspection.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



  reply	other threads:[~2019-07-31 14:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 13:29 [yocto-docs][PATCH] ref-manual: Remove documentation for the removed gnome class Adrian Bunk
2019-07-31 14:33 ` Khem Raj
2019-07-31 14:47   ` Adrian Bunk [this message]
2019-07-31 14:47     ` Adrian Bunk
2019-09-06 11:09 ` [yocto] " Adrian Bunk
2019-09-06 11:09   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731144758.GC1647@localhost \
    --to=bunk@stusta.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.