All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, will@kernel.org, arnd@arndb.de,
	tglx@linutronix.de, salyzyn@android.com, pcc@google.com,
	0x7f454c46@gmail.com, linux@rasmusvillemoes.dk,
	sthotton@marvell.com, andre.przywara@arm.com, luto@kernel.org,
	Matteo Croce <mcroce@redhat.com>
Subject: Re: [PATCH] arm64: vdso: Fix Makefile regression
Date: Wed, 31 Jul 2019 18:09:27 +0100	[thread overview]
Message-ID: <20190731170927.GD17773@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190729125421.32482-1-vincenzo.frascino@arm.com>

On Mon, Jul 29, 2019 at 01:54:21PM +0100, Vincenzo Frascino wrote:
> Using an old .config in combination with "make oldconfig" can cause
> an incorrect detection of the compat compiler:
> 
> $ grep CROSS_COMPILE_COMPAT .config
> CONFIG_CROSS_COMPILE_COMPAT_VDSO=""
> 
> $ make oldconfig && make
> arch/arm64/Makefile:58: gcc not found, check CROSS_COMPILE_COMPAT.
> Stop.
> 
> Accordingly to the section 7.2 of the GNU Make manual "Syntax of
> Conditionals", "When the value results from complex expansions of
> variables and functions, expansions you would consider empty may
> actually contain whitespace characters and thus are not seen as
> empty. However, you can use the strip function to avoid interpreting
> whitespace as a non-empty value."
> 
> Fix the issue adding strip to the CROSS_COMPILE_COMPAT string
> evaluation.
> 
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

Queued for 5.3-rc3. Thanks.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, arnd@arndb.de, pcc@google.com,
	Matteo Croce <mcroce@redhat.com>,
	0x7f454c46@gmail.com, linux-kernel@vger.kernel.org,
	salyzyn@android.com, andre.przywara@arm.com, luto@kernel.org,
	linux@rasmusvillemoes.dk, tglx@linutronix.de,
	sthotton@marvell.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: vdso: Fix Makefile regression
Date: Wed, 31 Jul 2019 18:09:27 +0100	[thread overview]
Message-ID: <20190731170927.GD17773@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190729125421.32482-1-vincenzo.frascino@arm.com>

On Mon, Jul 29, 2019 at 01:54:21PM +0100, Vincenzo Frascino wrote:
> Using an old .config in combination with "make oldconfig" can cause
> an incorrect detection of the compat compiler:
> 
> $ grep CROSS_COMPILE_COMPAT .config
> CONFIG_CROSS_COMPILE_COMPAT_VDSO=""
> 
> $ make oldconfig && make
> arch/arm64/Makefile:58: gcc not found, check CROSS_COMPILE_COMPAT.
> Stop.
> 
> Accordingly to the section 7.2 of the GNU Make manual "Syntax of
> Conditionals", "When the value results from complex expansions of
> variables and functions, expansions you would consider empty may
> actually contain whitespace characters and thus are not seen as
> empty. However, you can use the strip function to avoid interpreting
> whitespace as a non-empty value."
> 
> Fix the issue adding strip to the CROSS_COMPILE_COMPAT string
> evaluation.
> 
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

Queued for 5.3-rc3. Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-07-31 17:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-28 20:08 build error Matteo Croce
2019-07-28 20:08 ` Matteo Croce
2019-07-28 20:15 ` Bernd Petrovitsch
2019-07-28 20:15   ` Bernd Petrovitsch
2019-07-28 20:28   ` Matteo Croce
2019-07-28 20:28     ` Matteo Croce
2019-07-29  4:44 ` Bhaskar Chowdhury
2019-07-29  4:44   ` Bhaskar Chowdhury
2019-07-29  7:58   ` Matteo Croce
2019-07-29  7:58     ` Matteo Croce
2019-07-29  9:50 ` Will Deacon
2019-07-29  9:50   ` Will Deacon
2019-07-29 10:08   ` Matteo Croce
2019-07-29 10:08     ` Matteo Croce
2019-07-29 10:16   ` Vincenzo Frascino
2019-07-29 10:16     ` Vincenzo Frascino
2019-07-29 10:21     ` Matteo Croce
2019-07-29 10:25     ` Matteo Croce
2019-07-29 10:25       ` Matteo Croce
2019-07-29 11:08       ` Vincenzo Frascino
2019-07-29 11:08         ` Vincenzo Frascino
2019-07-29 11:12         ` Matteo Croce
2019-07-29 11:12           ` Matteo Croce
2019-07-29 11:18           ` Vincenzo Frascino
2019-07-29 11:18             ` Vincenzo Frascino
2019-07-29 11:26             ` Matteo Croce
2019-07-29 11:26               ` Matteo Croce
2019-07-29 12:54               ` [PATCH] arm64: vdso: Fix Makefile regression Vincenzo Frascino
2019-07-29 12:54                 ` Vincenzo Frascino
2019-07-29 16:33                 ` Matteo Croce
2019-07-29 16:33                   ` Matteo Croce
2019-07-31 16:23                 ` Will Deacon
2019-07-31 16:23                   ` Will Deacon
2019-07-31 17:09                 ` Catalin Marinas [this message]
2019-07-31 17:09                   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731170927.GD17773@arrakis.emea.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=0x7f454c46@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luto@kernel.org \
    --cc=mcroce@redhat.com \
    --cc=pcc@google.com \
    --cc=salyzyn@android.com \
    --cc=sthotton@marvell.com \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.