From: Sasha Levin <sashal@kernel.org>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section
Date: Wed, 31 Jul 2019 15:23:31 -0400 [thread overview]
Message-ID: <20190731192331.GA17697@sasha-vm> (raw)
In-Reply-To: <1689B7E0-5CA6-4B27-B2A8-F352618096EA@intel.com>
On Wed, Jul 31, 2019 at 05:14:38PM +0000, Vivi, Rodrigo wrote:
>> On Jul 30, 2019, at 2:48 PM, Sasha Levin <sashal@kernel.org> wrote:
>> rather
>> than a few weeks later when Greg sends his "FAILED:" mails and gets
>> ignored because said folks have moved on.
>
>however this could potentially cause extra work and confusion like we can see on this
>thread where the developer immediately responded to your email and sent the
>backported patch to the stable mailing list.
>
>Maybe it is just because we are used to Greg's failed to apply email or maybe
>it was just a matter of education...
I think that there were a few things here that ended up causing
confusion, but I'm not quite sure how to address them.
I think that stable should have a clearer rules as to how backports
should be sent. Right now we weed through mails to stable@ to figure out
what are backport requests, what are upstream patches, and what are just
confused folks.
We have gotten pretty good at this, but still not perfect...
>But I wonder if there isn't something that could be improved on the automated
>message here. Some message clearly stating:
>
>- No action required at this point
One *could* send a backport at this point. My understanding is that when
Greg sees a failure to apply a commit tagged for stable he'll grep
through his mailbox, hopefully finding the backport as a result of this
bot bugging people.
>- you can work to prepare the backport in advance
>- don't send it to stable before requested by Greg
Why not? I think it's fine to put it on the mailing list, specially
under the same thread, and let us deal with it after the patch goes
upstream.
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section
Date: Wed, 31 Jul 2019 15:23:31 -0400 [thread overview]
Message-ID: <20190731192331.GA17697@sasha-vm> (raw)
In-Reply-To: <1689B7E0-5CA6-4B27-B2A8-F352618096EA@intel.com>
On Wed, Jul 31, 2019 at 05:14:38PM +0000, Vivi, Rodrigo wrote:
>> On Jul 30, 2019, at 2:48 PM, Sasha Levin <sashal@kernel.org> wrote:
>> rather
>> than a few weeks later when Greg sends his "FAILED:" mails and gets
>> ignored because said folks have moved on.
>
>however this could potentially cause extra work and confusion like we can see on this
>thread where the developer immediately responded to your email and sent the
>backported patch to the stable mailing list.
>
>Maybe it is just because we are used to Greg's failed to apply email or maybe
>it was just a matter of education...
I think that there were a few things here that ended up causing
confusion, but I'm not quite sure how to address them.
I think that stable should have a clearer rules as to how backports
should be sent. Right now we weed through mails to stable@ to figure out
what are backport requests, what are upstream patches, and what are just
confused folks.
We have gotten pretty good at this, but still not perfect...
>But I wonder if there isn't something that could be improved on the automated
>message here. Some message clearly stating:
>
>- No action required at this point
One *could* send a backport at this point. My understanding is that when
Greg sees a failure to apply a commit tagged for stable he'll grep
through his mailbox, hopefully finding the backport as a result of this
bot bugging people.
>- you can work to prepare the backport in advance
>- don't send it to stable before requested by Greg
Why not? I think it's fine to put it on the mailing list, specially
under the same thread, and let us deal with it after the patch goes
upstream.
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-07-31 19:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 22:34 [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section Dhinakaran Pandiyan
2019-07-17 22:34 ` Dhinakaran Pandiyan
2019-07-17 23:19 ` ✓ Fi.CI.BAT: success for drm/i915/vbt: Fix VBT parsing for the PSR section (rev3) Patchwork
2019-07-18 19:14 ` [Intel-gfx] [PATCH] drm/i915/vbt: Fix VBT parsing for the PSR section Rodrigo Vivi
2019-07-19 0:45 ` Sasha Levin
2019-07-22 23:13 ` [PATCH stable v5.2] " Dhinakaran Pandiyan
2019-07-24 12:06 ` Greg KH
2019-07-24 17:27 ` Souza, Jose
2019-07-24 17:27 ` Souza, Jose
2019-07-24 17:40 ` Rodrigo Vivi
2019-07-24 17:40 ` [Intel-gfx] " Rodrigo Vivi
2019-07-30 15:19 ` Rodrigo Vivi
2019-07-30 15:19 ` [Intel-gfx] " Rodrigo Vivi
2019-07-30 15:27 ` Greg KH
2019-07-30 16:22 ` Rodrigo Vivi
2019-07-30 16:27 ` Greg KH
2019-07-30 16:56 ` Rodrigo Vivi
2019-07-30 16:56 ` Rodrigo Vivi
2019-07-30 17:08 ` Greg KH
2019-07-30 18:24 ` Pandiyan, Dhinakaran
2019-07-30 20:42 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2019-07-30 21:48 ` Sasha Levin
2019-07-30 21:48 ` [Intel-gfx] " Sasha Levin
2019-07-31 17:14 ` Vivi, Rodrigo
2019-07-31 17:14 ` [Intel-gfx] " Vivi, Rodrigo
2019-07-31 19:23 ` Sasha Levin [this message]
2019-07-31 19:23 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731192331.GA17697@sasha-vm \
--to=sashal@kernel.org \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.