[PATCH] webkitgtk: Stop disabling gold on aarch64 and mips

[PATCH] webkitgtk: Stop disabling gold on aarch64 and mips

[Adrian Bunk]

The binutils bug appears to have gone away.

Using gold on powerpc still fails for seemingly unrelated reasons.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
 meta/recipes-sato/webkit/webkitgtk_2.24.3.bb | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.24.3.bb
index f65d79b0fb..81cbf34198 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.24.3.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.24.3.bb
@@ -87,10 +87,6 @@ EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
 
-# binutils 2.25.1 has a bug on aarch64:
-# https://sourceware.org/bugzilla/show_bug.cgi?id=18430
-EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
-EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "
 
 # JIT not supported on MIPS either
-- 
2.17.1

Re: [PATCH] webkitgtk: Stop disabling gold on aarch64 and mips

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

I don’t remember if mips disable reason was same as aarch64 I hope it was
not a runtime failure can you dig a bit

On Wed, Jul 31, 2019 at 9:50 PM Adrian Bunk <bunk@stusta.de> wrote:

> The binutils bug appears to have gone away.
>
> Using gold on powerpc still fails for seemingly unrelated reasons.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.24.3.bb | 4 ----
>  1 file changed, 4 deletions(-
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.3.bb
> b/meta/recipes-sato/webkit/webkitgtk_2.24.3.bb
> index f65d79b0fb..81cbf34198 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.24.3.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.3.bb
> @@ -87,10 +87,6 @@ EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=OFF "
>  EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=OFF "
>  EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
>
> -# binutils 2.25.1 has a bug on aarch64:
> -# https://sourceware.org/bugzilla/show_bug.cgi?id=18430
> -EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
> -EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
>  EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "
>
>  # JIT not supported on MIPS either
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2573 bytes --]

Re: [PATCH] webkitgtk: Stop disabling gold on aarch64 and mips

[Adrian Bunk]

On Wed, Jul 31, 2019 at 10:19:24PM -0700, Khem Raj wrote:
> I don’t remember if mips disable reason was same as aarch64 I hope it was
> not a runtime failure can you dig a bit

Author: Khem Raj <raj.khem@gmail.com>
Date:   Mon Aug 8 15:51:00 2016 -0700

    webkitgtk: Disable gold for mips/mips64
    
    with binutils 2.27, mips has got the gold support
    but it doesnt work for webkitgtk _yet_ therefore
    disable it for now.

To me this looked like a buildtime failure, but it's hard to be sure 
when the problem is not described.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] webkitgtk: Stop disabling gold on aarch64 and mips

[Khem Raj]

On 7/31/19 10:37 PM, Adrian Bunk wrote:
> On Wed, Jul 31, 2019 at 10:19:24PM -0700, Khem Raj wrote:
>> I don’t remember if mips disable reason was same as aarch64 I hope it was
>> not a runtime failure can you dig a bit
> Author: Khem Raj <raj.khem@gmail.com>
> Date:   Mon Aug 8 15:51:00 2016 -0700
>
>      webkitgtk: Disable gold for mips/mips64
>      
>      with binutils 2.27, mips has got the gold support
>      but it doesnt work for webkitgtk _yet_ therefore
>      disable it for now.
>
> To me this looked like a buildtime failure, but it's hard to be sure
> when the problem is not described.


yes i remember it now it was build time failure

> cu
> Adrian
>