From: Christoph Hellwig <hch@lst.de>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: kevin.tian@intel.com, ashok.raj@intel.com,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
jacob.jun.pan@intel.com, David Woodhouse <dwmw2@infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/3] iommu/vt-d: Refactor find_domain() helper
Date: Thu, 1 Aug 2019 08:10:21 +0200 [thread overview]
Message-ID: <20190801061021.GA14955@lst.de> (raw)
In-Reply-To: <20190801060156.8564-2-baolu.lu@linux.intel.com>
On Thu, Aug 01, 2019 at 02:01:54PM +0800, Lu Baolu wrote:
> + /* No lock here, assumes no domain exit in normal case */
s/exit/exists/ ?
> + info = dev->archdata.iommu;
> + if (likely(info))
> + return info->domain;
But then again the likely would be odd.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <joro@8bytes.org>,
ashok.raj@intel.com, jacob.jun.pan@intel.com,
kevin.tian@intel.com, Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH 1/3] iommu/vt-d: Refactor find_domain() helper
Date: Thu, 1 Aug 2019 08:10:21 +0200 [thread overview]
Message-ID: <20190801061021.GA14955@lst.de> (raw)
In-Reply-To: <20190801060156.8564-2-baolu.lu@linux.intel.com>
On Thu, Aug 01, 2019 at 02:01:54PM +0800, Lu Baolu wrote:
> + /* No lock here, assumes no domain exit in normal case */
s/exit/exists/ ?
> + info = dev->archdata.iommu;
> + if (likely(info))
> + return info->domain;
But then again the likely would be odd.
next prev parent reply other threads:[~2019-08-01 6:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 6:01 [PATCH 0/3] iommu/vtd: Per device dma ops Lu Baolu
2019-08-01 6:01 ` Lu Baolu
2019-08-01 6:01 ` [PATCH 1/3] iommu/vt-d: Refactor find_domain() helper Lu Baolu
2019-08-01 6:01 ` Lu Baolu
2019-08-01 6:10 ` Christoph Hellwig [this message]
2019-08-01 6:10 ` Christoph Hellwig
2019-08-01 6:20 ` Lu Baolu
2019-08-01 6:20 ` Lu Baolu
2019-08-01 14:09 ` Christoph Hellwig
2019-08-01 14:09 ` Christoph Hellwig
2019-08-02 2:06 ` Lu Baolu
2019-08-02 2:06 ` Lu Baolu
2019-08-01 6:01 ` [PATCH 2/3] iommu/vt-d: Apply per-device dma_ops Lu Baolu
2019-08-01 6:01 ` Lu Baolu
2019-08-06 6:43 ` Christoph Hellwig
2019-08-06 6:43 ` Christoph Hellwig
2019-08-07 3:06 ` Lu Baolu
2019-08-07 3:06 ` Lu Baolu
2019-08-13 7:38 ` Lu Baolu
2019-08-13 7:38 ` Lu Baolu
2019-08-01 6:01 ` [PATCH 3/3] iommu/vt-d: Cleanup after using per-device dma ops Lu Baolu
2019-08-01 6:01 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801061021.GA14955@lst.de \
--to=hch@lst.de \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.