All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Bharata B Rao <bharata-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
Cc: Ralph Campbell
	<rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH 5/9] nouveau: simplify nouveau_dmem_migrate_to_ram
Date: Thu, 1 Aug 2019 09:46:14 +0200	[thread overview]
Message-ID: <20190801074614.GC16178@lst.de> (raw)
In-Reply-To: <20190731095735.GB18807-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>

On Wed, Jul 31, 2019 at 03:27:35PM +0530, Bharata B Rao wrote:
> > -	kfree(fault->dma);
> > +	return VM_FAULT_SIGBUS;

> Looks like nouveau_dmem_fault_copy_one() is now returning VM_FAULT_SIGBUS
> for success case. Is this expected?

No, fixed.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Bharata B Rao <bharata@linux.ibm.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Jason Gunthorpe" <jgg@mellanox.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Ralph Campbell" <rcampbell@nvidia.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-mm@kvack.org, nouveau@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] nouveau: simplify nouveau_dmem_migrate_to_ram
Date: Thu, 1 Aug 2019 09:46:14 +0200	[thread overview]
Message-ID: <20190801074614.GC16178@lst.de> (raw)
In-Reply-To: <20190731095735.GB18807@in.ibm.com>

On Wed, Jul 31, 2019 at 03:27:35PM +0530, Bharata B Rao wrote:
> > -	kfree(fault->dma);
> > +	return VM_FAULT_SIGBUS;

> Looks like nouveau_dmem_fault_copy_one() is now returning VM_FAULT_SIGBUS
> for success case. Is this expected?

No, fixed.


  parent reply	other threads:[~2019-08-01  7:46 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 14:28 turn the hmm migrate_vma upside down Christoph Hellwig
2019-07-29 14:28 ` [PATCH 1/9] mm: turn " Christoph Hellwig
2019-07-29 23:43   ` Jerome Glisse
     [not found]   ` <20190729142843.22320-2-hch-jcswGhMUV9g@public.gmane.org>
2019-07-29 23:12     ` Ralph Campbell
2019-07-29 23:12       ` Ralph Campbell
2019-07-31  1:46     ` Ralph Campbell
2019-07-31  1:46       ` Ralph Campbell
2019-08-01  7:42       ` Christoph Hellwig
2019-07-29 14:28 ` [PATCH 2/9] nouveau: reset dma_nr in nouveau_dmem_migrate_alloc_and_copy Christoph Hellwig
2019-07-29 23:18   ` Ralph Campbell
2019-07-29 23:18     ` Ralph Campbell
     [not found] ` <20190729142843.22320-1-hch-jcswGhMUV9g@public.gmane.org>
2019-07-29 14:28   ` [PATCH 3/9] nouveau: factor out device memory address calculation Christoph Hellwig
2019-07-29 14:28     ` Christoph Hellwig
2019-07-29 23:21     ` Ralph Campbell
2019-07-29 23:21       ` Ralph Campbell
2019-07-29 14:28   ` [PATCH 4/9] nouveau: factor out dmem fence completion Christoph Hellwig
2019-07-29 14:28     ` Christoph Hellwig
2019-07-29 23:23     ` Ralph Campbell
2019-07-29 23:23       ` Ralph Campbell
2019-07-29 14:28   ` [PATCH 5/9] nouveau: simplify nouveau_dmem_migrate_to_ram Christoph Hellwig
2019-07-29 14:28     ` Christoph Hellwig
2019-07-29 23:26     ` Ralph Campbell
2019-07-29 23:26       ` Ralph Campbell
2019-07-31  9:57     ` Bharata B Rao
     [not found]       ` <20190731095735.GB18807-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
2019-08-01  7:46         ` Christoph Hellwig [this message]
2019-08-01  7:46           ` Christoph Hellwig
2019-07-29 14:28   ` [PATCH 6/9] nouveau: simplify nouveau_dmem_migrate_vma Christoph Hellwig
2019-07-29 14:28     ` Christoph Hellwig
     [not found]     ` <20190729142843.22320-7-hch-jcswGhMUV9g@public.gmane.org>
2019-07-29 23:27       ` Ralph Campbell
2019-07-29 23:27         ` Ralph Campbell
2019-07-29 14:28   ` [PATCH 7/9] mm: remove the unused MIGRATE_PFN_ERROR flag Christoph Hellwig
2019-07-29 14:28     ` Christoph Hellwig
     [not found]     ` <20190729142843.22320-8-hch-jcswGhMUV9g@public.gmane.org>
2019-07-29 23:29       ` Ralph Campbell
2019-07-29 23:29         ` Ralph Campbell
2019-07-29 14:28   ` [PATCH 8/9] mm: remove the unused MIGRATE_PFN_DEVICE flag Christoph Hellwig
2019-07-29 14:28     ` Christoph Hellwig
2019-07-29 23:31     ` Ralph Campbell
2019-07-29 23:31       ` Ralph Campbell
2019-07-29 14:28   ` [PATCH 9/9] mm: remove the MIGRATE_PFN_WRITE flag Christoph Hellwig
2019-07-29 14:28     ` Christoph Hellwig
2019-07-29 23:30     ` Jerome Glisse
     [not found]       ` <20190729233044.GA7171-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-07-30  5:46         ` Christoph Hellwig
2019-07-30  5:46           ` Christoph Hellwig
2019-07-30 15:51           ` Jerome Glisse
2019-07-29 23:42     ` Ralph Campbell
2019-07-29 23:42       ` Ralph Campbell
2019-07-29 23:46       ` Jerome Glisse
2019-07-30 12:32 ` turn the hmm migrate_vma upside down Jason Gunthorpe
2019-07-30 13:09   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190801074614.GC16178@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=bharata-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.