From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH 2/5] virtiofsd: take lo->mutex around lo_add_dirp_mapping()
Date: Thu, 1 Aug 2019 12:45:13 +0100 [thread overview]
Message-ID: <20190801114513.GE2773@work-vm> (raw)
In-Reply-To: <20190731161006.9447-3-stefanha@redhat.com>
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> The lo_add_dirp_mapping() function assumes lo->mutex is held, so we
> should acquire it.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Squashed into:
passthrough_ll: add dirp_map to hide lo_dirp pointers
> ---
> contrib/virtiofsd/passthrough_ll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/contrib/virtiofsd/passthrough_ll.c b/contrib/virtiofsd/passthrough_ll.c
> index 417a104218..e1d729d26b 100644
> --- a/contrib/virtiofsd/passthrough_ll.c
> +++ b/contrib/virtiofsd/passthrough_ll.c
> @@ -1357,7 +1357,9 @@ static void lo_opendir(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi
>
> g_atomic_int_set(&d->refcount, 1); /* paired with lo_releasedir() */
>
> + pthread_mutex_lock(&lo->mutex);
> fh = lo_add_dirp_mapping(req, d);
> + pthread_mutex_unlock(&lo->mutex);
> if (fh == -1)
> goto out_err;
>
> --
> 2.21.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: virtio-fs@redhat.com, Liu Bo <bo.liu@linux.alibaba.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] virtiofsd: take lo->mutex around lo_add_dirp_mapping()
Date: Thu, 1 Aug 2019 12:45:13 +0100 [thread overview]
Message-ID: <20190801114513.GE2773@work-vm> (raw)
In-Reply-To: <20190731161006.9447-3-stefanha@redhat.com>
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> The lo_add_dirp_mapping() function assumes lo->mutex is held, so we
> should acquire it.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Squashed into:
passthrough_ll: add dirp_map to hide lo_dirp pointers
> ---
> contrib/virtiofsd/passthrough_ll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/contrib/virtiofsd/passthrough_ll.c b/contrib/virtiofsd/passthrough_ll.c
> index 417a104218..e1d729d26b 100644
> --- a/contrib/virtiofsd/passthrough_ll.c
> +++ b/contrib/virtiofsd/passthrough_ll.c
> @@ -1357,7 +1357,9 @@ static void lo_opendir(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi
>
> g_atomic_int_set(&d->refcount, 1); /* paired with lo_releasedir() */
>
> + pthread_mutex_lock(&lo->mutex);
> fh = lo_add_dirp_mapping(req, d);
> + pthread_mutex_unlock(&lo->mutex);
> if (fh == -1)
> goto out_err;
>
> --
> 2.21.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-08-01 11:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:10 [Virtio-fs] [PATCH 0/5] virtiofsd: multithreading preparation part 2 Stefan Hajnoczi
2019-07-31 16:10 ` [Qemu-devel] " Stefan Hajnoczi
2019-07-31 16:10 ` [Virtio-fs] [PATCH 1/5] virtiofsd: take lo->mutex around lo_add_fd_mapping() Stefan Hajnoczi
2019-07-31 16:10 ` [Qemu-devel] " Stefan Hajnoczi
2019-07-31 18:45 ` [Virtio-fs] " Dr. David Alan Gilbert
2019-07-31 18:45 ` [Qemu-devel] " Dr. David Alan Gilbert
2019-08-01 9:17 ` [Virtio-fs] " Stefan Hajnoczi
2019-08-01 9:17 ` [Qemu-devel] " Stefan Hajnoczi
2019-07-31 16:10 ` [Virtio-fs] [PATCH 2/5] virtiofsd: take lo->mutex around lo_add_dirp_mapping() Stefan Hajnoczi
2019-07-31 16:10 ` [Qemu-devel] " Stefan Hajnoczi
2019-08-01 11:45 ` Dr. David Alan Gilbert [this message]
2019-08-01 11:45 ` Dr. David Alan Gilbert
2019-07-31 16:10 ` [Virtio-fs] [PATCH 3/5] virtiofsd: rename inode->refcount to inode->nlookup Stefan Hajnoczi
2019-07-31 16:10 ` [Qemu-devel] " Stefan Hajnoczi
2019-08-01 12:00 ` [Virtio-fs] " Dr. David Alan Gilbert
2019-08-01 12:00 ` [Qemu-devel] " Dr. David Alan Gilbert
2019-07-31 16:10 ` [Virtio-fs] [PATCH 4/5] virtiofsd: fix inode nlookup leaks Stefan Hajnoczi
2019-07-31 16:10 ` [Qemu-devel] " Stefan Hajnoczi
2019-07-31 16:10 ` [Virtio-fs] [PATCH 5/5] virtiofsd: introduce inode refcount to prevent use-after-free Stefan Hajnoczi
2019-07-31 16:10 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801114513.GE2773@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.