From: Wolfram Sang <wsa@the-dreams.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] i2c: s3c2410: Mark expected switch fall-through
Date: Thu, 1 Aug 2019 15:01:42 +0200 [thread overview]
Message-ID: <20190801130141.GO1659@ninjato> (raw)
In-Reply-To: <20190728235138.GA23429@embeddedor>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Sun, Jul 28, 2019 at 06:51:38PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/i2c/busses/i2c-s3c2410.c: In function 'i2c_s3c_irq_nextbyte':
> drivers/i2c/busses/i2c-s3c2410.c:431:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (i2c->state == STATE_READ)
> ^
> drivers/i2c/busses/i2c-s3c2410.c:439:2: note: here
> case STATE_WRITE:
> ^~~~
>
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-samsung-soc@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: s3c2410: Mark expected switch fall-through
Date: Thu, 1 Aug 2019 15:01:42 +0200 [thread overview]
Message-ID: <20190801130141.GO1659@ninjato> (raw)
In-Reply-To: <20190728235138.GA23429@embeddedor>
[-- Attachment #1.1: Type: text/plain, Size: 786 bytes --]
On Sun, Jul 28, 2019 at 06:51:38PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/i2c/busses/i2c-s3c2410.c: In function 'i2c_s3c_irq_nextbyte':
> drivers/i2c/busses/i2c-s3c2410.c:431:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (i2c->state == STATE_READ)
> ^
> drivers/i2c/busses/i2c-s3c2410.c:439:2: note: here
> case STATE_WRITE:
> ^~~~
>
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-01 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 23:51 [PATCH] i2c: s3c2410: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-28 23:51 ` Gustavo A. R. Silva
2019-07-29 16:34 ` Kees Cook
2019-07-29 16:34 ` Kees Cook
2019-08-01 13:01 ` Wolfram Sang [this message]
2019-08-01 13:01 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801130141.GO1659@ninjato \
--to=wsa@the-dreams.de \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.