* [PATCH] drm/panfrost: Remove completed features still in TODO
@ 2019-08-02 19:57 Rob Herring
2019-08-02 19:58 ` Boris Brezillon
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rob Herring @ 2019-08-02 19:57 UTC (permalink / raw)
To: dri-devel; +Cc: Boris Brezillon, Tomeu Vizoso
There's a few features the driver supports which we forgot to remove, so
remove them now.
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/gpu/drm/panfrost/TODO | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/TODO b/drivers/gpu/drm/panfrost/TODO
index c2e44add37d8..2ac972a3469c 100644
--- a/drivers/gpu/drm/panfrost/TODO
+++ b/drivers/gpu/drm/panfrost/TODO
@@ -1,15 +1,9 @@
-- Thermal support.
-
- Bifrost support:
- DT bindings (Neil, WIP)
- MMU page table format and address space setup
- Bifrost specific feature and issue handling
- Coherent DMA support
-- Support for 2MB pages. The io-pgtable code already supports this. Finishing
- support involves either copying or adapting the iommu API to handle passing
- aligned addresses and sizes to the io-pgtable code.
-
- Per FD address space support. The h/w supports multiple addresses spaces.
The hard part is handling when more address spaces are needed than what
the h/w provides.
@@ -22,6 +16,3 @@
- Compute job support. So called 'compute only' jobs need to be plumbed up to
userspace.
-
-- Performance counter support. (Boris)
-
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/panfrost: Remove completed features still in TODO
2019-08-02 19:57 [PATCH] drm/panfrost: Remove completed features still in TODO Rob Herring
@ 2019-08-02 19:58 ` Boris Brezillon
2019-08-05 16:07 ` Tomeu Vizoso
2019-08-13 13:07 ` Neil Armstrong
2 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2019-08-02 19:58 UTC (permalink / raw)
To: Rob Herring; +Cc: Tomeu Vizoso, dri-devel
On Fri, 2 Aug 2019 13:57:27 -0600
Rob Herring <robh@kernel.org> wrote:
> There's a few features the driver supports which we forgot to remove, so
> remove them now.
>
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/gpu/drm/panfrost/TODO | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/TODO b/drivers/gpu/drm/panfrost/TODO
> index c2e44add37d8..2ac972a3469c 100644
> --- a/drivers/gpu/drm/panfrost/TODO
> +++ b/drivers/gpu/drm/panfrost/TODO
> @@ -1,15 +1,9 @@
> -- Thermal support.
> -
> - Bifrost support:
> - DT bindings (Neil, WIP)
> - MMU page table format and address space setup
> - Bifrost specific feature and issue handling
> - Coherent DMA support
>
> -- Support for 2MB pages. The io-pgtable code already supports this. Finishing
> - support involves either copying or adapting the iommu API to handle passing
> - aligned addresses and sizes to the io-pgtable code.
> -
> - Per FD address space support. The h/w supports multiple addresses spaces.
> The hard part is handling when more address spaces are needed than what
> the h/w provides.
> @@ -22,6 +16,3 @@
>
> - Compute job support. So called 'compute only' jobs need to be plumbed up to
> userspace.
> -
> -- Performance counter support. (Boris)
> -
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panfrost: Remove completed features still in TODO
2019-08-02 19:57 [PATCH] drm/panfrost: Remove completed features still in TODO Rob Herring
2019-08-02 19:58 ` Boris Brezillon
@ 2019-08-05 16:07 ` Tomeu Vizoso
2019-08-05 21:09 ` Rob Herring
2019-08-13 13:07 ` Neil Armstrong
2 siblings, 1 reply; 6+ messages in thread
From: Tomeu Vizoso @ 2019-08-05 16:07 UTC (permalink / raw)
To: Rob Herring, dri-devel; +Cc: Boris Brezillon
On 8/2/19 9:57 PM, Rob Herring wrote:
> There's a few features the driver supports which we forgot to remove, so
> remove them now.
>
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/gpu/drm/panfrost/TODO | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/TODO b/drivers/gpu/drm/panfrost/TODO
> index c2e44add37d8..2ac972a3469c 100644
> --- a/drivers/gpu/drm/panfrost/TODO
> +++ b/drivers/gpu/drm/panfrost/TODO
> @@ -1,15 +1,9 @@
> -- Thermal support.
Was thinking that this item referred to cooling device support, which we
don't yet have?
Cheers,
Tomeu
> -
> - Bifrost support:
> - DT bindings (Neil, WIP)
> - MMU page table format and address space setup
> - Bifrost specific feature and issue handling
> - Coherent DMA support
>
> -- Support for 2MB pages. The io-pgtable code already supports this. Finishing
> - support involves either copying or adapting the iommu API to handle passing
> - aligned addresses and sizes to the io-pgtable code.
> -
> - Per FD address space support. The h/w supports multiple addresses spaces.
> The hard part is handling when more address spaces are needed than what
> the h/w provides.
> @@ -22,6 +16,3 @@
>
> - Compute job support. So called 'compute only' jobs need to be plumbed up to
> userspace.
> -
> -- Performance counter support. (Boris)
> -
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panfrost: Remove completed features still in TODO
2019-08-05 16:07 ` Tomeu Vizoso
@ 2019-08-05 21:09 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-08-05 21:09 UTC (permalink / raw)
To: Tomeu Vizoso; +Cc: Boris Brezillon, dri-devel
On Mon, Aug 5, 2019 at 10:07 AM Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
>
> On 8/2/19 9:57 PM, Rob Herring wrote:
> > There's a few features the driver supports which we forgot to remove, so
> > remove them now.
> >
> > Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> > Cc: Boris Brezillon <boris.brezillon@collabora.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drivers/gpu/drm/panfrost/TODO | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panfrost/TODO b/drivers/gpu/drm/panfrost/TODO
> > index c2e44add37d8..2ac972a3469c 100644
> > --- a/drivers/gpu/drm/panfrost/TODO
> > +++ b/drivers/gpu/drm/panfrost/TODO
> > @@ -1,15 +1,9 @@
> > -- Thermal support.
>
> Was thinking that this item referred to cooling device support, which we
> don't yet have?
Oh right. I thinking that somehow was left over from before committing
upstream... Will drop that change.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panfrost: Remove completed features still in TODO
2019-08-02 19:57 [PATCH] drm/panfrost: Remove completed features still in TODO Rob Herring
2019-08-02 19:58 ` Boris Brezillon
2019-08-05 16:07 ` Tomeu Vizoso
@ 2019-08-13 13:07 ` Neil Armstrong
2019-08-13 14:50 ` Rob Herring
2 siblings, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2019-08-13 13:07 UTC (permalink / raw)
To: Rob Herring, dri-devel; +Cc: Boris Brezillon, Tomeu Vizoso
On 02/08/2019 21:57, Rob Herring wrote:
> There's a few features the driver supports which we forgot to remove, so
> remove them now.
>
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/gpu/drm/panfrost/TODO | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/TODO b/drivers/gpu/drm/panfrost/TODO
> index c2e44add37d8..2ac972a3469c 100644
> --- a/drivers/gpu/drm/panfrost/TODO
> +++ b/drivers/gpu/drm/panfrost/TODO
> @@ -1,15 +1,9 @@
> -- Thermal support.
> -
> - Bifrost support:
> - DT bindings (Neil, WIP)
The bifrostr bindings are upstream, but not in YAML, you should move and transform this line into :
- DT bindings in YAML schema
Neil
> - MMU page table format and address space setup
> - Bifrost specific feature and issue handling
> - Coherent DMA support
>
> -- Support for 2MB pages. The io-pgtable code already supports this. Finishing
> - support involves either copying or adapting the iommu API to handle passing
> - aligned addresses and sizes to the io-pgtable code.
> -
> - Per FD address space support. The h/w supports multiple addresses spaces.
> The hard part is handling when more address spaces are needed than what
> the h/w provides.
> @@ -22,6 +16,3 @@
>
> - Compute job support. So called 'compute only' jobs need to be plumbed up to
> userspace.
> -
> -- Performance counter support. (Boris)
> -
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/panfrost: Remove completed features still in TODO
2019-08-13 13:07 ` Neil Armstrong
@ 2019-08-13 14:50 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-08-13 14:50 UTC (permalink / raw)
To: Neil Armstrong; +Cc: Boris Brezillon, Tomeu Vizoso, dri-devel
On Tue, Aug 13, 2019 at 7:07 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> On 02/08/2019 21:57, Rob Herring wrote:
> > There's a few features the driver supports which we forgot to remove, so
> > remove them now.
> >
> > Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> > Cc: Boris Brezillon <boris.brezillon@collabora.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drivers/gpu/drm/panfrost/TODO | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panfrost/TODO b/drivers/gpu/drm/panfrost/TODO
> > index c2e44add37d8..2ac972a3469c 100644
> > --- a/drivers/gpu/drm/panfrost/TODO
> > +++ b/drivers/gpu/drm/panfrost/TODO
> > @@ -1,15 +1,9 @@
> > -- Thermal support.
> > -
> > - Bifrost support:
> > - DT bindings (Neil, WIP)
>
> The bifrostr bindings are upstream, but not in YAML, you should move and transform this line into :
>
> - DT bindings in YAML schema
Already applied this. In any case, this patch was about removals. If
we have updates or additions, that's a separate thing.
But I rather just get this one done than add a todo.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-13 14:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-02 19:57 [PATCH] drm/panfrost: Remove completed features still in TODO Rob Herring
2019-08-02 19:58 ` Boris Brezillon
2019-08-05 16:07 ` Tomeu Vizoso
2019-08-05 21:09 ` Rob Herring
2019-08-13 13:07 ` Neil Armstrong
2019-08-13 14:50 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.