All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <natechancellor@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: andrew@lunn.ch, broonie@kernel.org, devel@driverdev.osuosl.org,
	f.fainelli@gmail.com, gregkh@linuxfoundation.org,
	hkallweit1@gmail.com, kernel-build-reports@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org,
	netdev@vger.kernel.org, willy@infradead.org, lkp@intel.com,
	rdunlap@infradead.org
Subject: Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning
Date: Fri, 2 Aug 2019 18:30:31 -0700	[thread overview]
Message-ID: <20190803013031.GA76252@archlinux-threadripper> (raw)
In-Reply-To: <20190802.181132.1425585873361511856.davem@davemloft.net>

On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Wed, 31 Jul 2019 11:50:24 -0700
> 
> > arm allyesconfig warns:
> > 
> > WARNING: unmet direct dependencies detected for MDIO_OCTEON
> >   Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
> > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y]
> >   Selected by [y]:
> >   - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC &&
> > NETDEVICES [=y] || COMPILE_TEST [=y])
> > 
> > and errors:
> > 
> > In file included from ../drivers/net/phy/mdio-octeon.c:14:
> > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe':
> > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
> > function 'writeq'; did you mean 'writeb'?
> 
> The proper way to fix this is to include either
> 
> 	linux/io-64-nonatomic-hi-lo.h
> 
> or
> 
> 	linux/io-64-nonatomic-lo-hi.h
> 
> whichever is appropriate.

Hmmmm, is that not what I did?

Although I did not know about io-64-nonatomic-hi-lo.h. What is the
difference and which one is needed here?

There is apparently another failure when OF_MDIO is not set, I guess I
can try to look into that as well and respin into a series if
necessary.

Cheers,
Nathan

WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: devel@driverdev.osuosl.org, andrew@lunn.ch, f.fainelli@gmail.com,
	lkp@intel.com, kernel-build-reports@lists.linaro.org,
	gregkh@linuxfoundation.org, rdunlap@infradead.org,
	willy@infradead.org, broonie@kernel.org,
	linux-next@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com
Subject: Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning
Date: Fri, 2 Aug 2019 18:30:31 -0700	[thread overview]
Message-ID: <20190803013031.GA76252@archlinux-threadripper> (raw)
In-Reply-To: <20190802.181132.1425585873361511856.davem@davemloft.net>

On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Wed, 31 Jul 2019 11:50:24 -0700
> 
> > arm allyesconfig warns:
> > 
> > WARNING: unmet direct dependencies detected for MDIO_OCTEON
> >   Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
> > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y]
> >   Selected by [y]:
> >   - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC &&
> > NETDEVICES [=y] || COMPILE_TEST [=y])
> > 
> > and errors:
> > 
> > In file included from ../drivers/net/phy/mdio-octeon.c:14:
> > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe':
> > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
> > function 'writeq'; did you mean 'writeb'?
> 
> The proper way to fix this is to include either
> 
> 	linux/io-64-nonatomic-hi-lo.h
> 
> or
> 
> 	linux/io-64-nonatomic-lo-hi.h
> 
> whichever is appropriate.

Hmmmm, is that not what I did?

Although I did not know about io-64-nonatomic-hi-lo.h. What is the
difference and which one is needed here?

There is apparently another failure when OF_MDIO is not set, I guess I
can try to look into that as well and respin into a series if
necessary.

Cheers,
Nathan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-08-03  1:30 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5d41767d.1c69fb81.d6304.4c8c@mx.google.com>
2019-07-31 11:24 ` next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) Mark Brown
2019-07-31 11:24   ` Mark Brown
2019-07-31 11:35   ` Greg Kroah-Hartman
2019-07-31 11:35     ` Greg Kroah-Hartman
2019-07-31 15:48     ` David Miller
2019-07-31 15:48       ` David Miller
2019-07-31 16:00       ` Greg KH
2019-07-31 16:00         ` Greg KH
2019-07-31 16:35         ` Nathan Chancellor
2019-07-31 16:35           ` Nathan Chancellor
2019-07-31 16:41           ` David Miller
2019-07-31 16:41             ` David Miller
2019-07-31 18:50             ` [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Nathan Chancellor
2019-07-31 18:50               ` Nathan Chancellor
2019-07-31 21:55               ` Randy Dunlap
2019-07-31 23:52                 ` Randy Dunlap
2019-07-31 23:52                   ` Randy Dunlap
2019-09-19  9:06                   ` Geert Uytterhoeven
2019-09-19  9:06                     ` Geert Uytterhoeven
2019-08-03  1:11               ` David Miller
2019-08-03  1:11                 ` David Miller
2019-08-03  1:30                 ` Nathan Chancellor [this message]
2019-08-03  1:30                   ` Nathan Chancellor
2019-08-03  1:39                   ` Matthew Wilcox
2019-08-03  1:39                     ` Matthew Wilcox
2019-08-03  6:05                     ` Nathan Chancellor
2019-08-03  6:05                       ` Nathan Chancellor
2019-08-03  6:01               ` [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors Nathan Chancellor
2019-08-03  6:01                 ` Nathan Chancellor
2019-08-03 18:34                 ` Randy Dunlap
2019-08-03 18:34                   ` Randy Dunlap
2019-08-06 21:11                 ` David Miller
2019-08-06 21:11                   ` David Miller
2019-08-07  5:10                   ` Nathan Chancellor
2019-08-07  5:10                     ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190803013031.GA76252@archlinux-threadripper \
    --to=natechancellor@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=kernel-build-reports@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.