From: Christoph Hellwig <hch@lst.de>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Doug Gilbert" <dgilbert@interlog.com>,
"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>,
"Hannes Reinecke" <hare@suse.com>,
"Omar Sandoval" <osandov@fb.com>,
"Ming Lei" <ming.lei@redhat.com>,
"Chaitanya Kulkarni" <chaitanya.kulkarni@wdc.com>,
"Damien Le Moal" <damien.lemoal@wdc.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"open list:SCSI TARGET SUBSYSTEM" <target-devel@vger.kernel.org>
Subject: Re: [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait
Date: Tue, 6 Aug 2019 07:19:11 +0200 [thread overview]
Message-ID: <20190806051911.GA13409@lst.de> (raw)
In-Reply-To: <20190806011754.7722-1-marcos.souza.org@gmail.com>
On Mon, Aug 05, 2019 at 10:17:51PM -0300, Marcos Paulo de Souza wrote:
> +void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq,
> + int at_head, rq_end_io_fn *done)
We store a ->rq_disk in struct request, so we should also not need
that. And at_head should either become a bool, or be replaced with
a flags argument, ints used boolean are usually not a good idea.
> @@ -81,7 +80,7 @@ void blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk,
And all the same argument changes that apply to blk_execute_rq_nowait
apply to blk_execute_rq as well.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait
Date: Tue, 6 Aug 2019 07:19:11 +0200 [thread overview]
Message-ID: <20190806051911.GA13409@lst.de> (raw)
In-Reply-To: <20190806011754.7722-1-marcos.souza.org@gmail.com>
On Mon, Aug 05, 2019@10:17:51PM -0300, Marcos Paulo de Souza wrote:
> +void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq,
> + int at_head, rq_end_io_fn *done)
We store a ->rq_disk in struct request, so we should also not need
that. And at_head should either become a bool, or be replaced with
a flags argument, ints used boolean are usually not a good idea.
> @@ -81,7 +80,7 @@ void blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk,
And all the same argument changes that apply to blk_execute_rq_nowait
apply to blk_execute_rq as well.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Doug Gilbert" <dgilbert@interlog.com>,
"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>,
"Hannes Reinecke" <hare@suse.com>,
"Omar Sandoval" <osandov@fb.com>,
"Ming Lei" <ming.lei@redhat.com>,
"Chaitanya Kulkarni" <chaitanya.kulkarni@wdc.com>,
"Damien Le Moal" <damien.lemoal@wdc.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait
Date: Tue, 6 Aug 2019 07:19:11 +0200 [thread overview]
Message-ID: <20190806051911.GA13409@lst.de> (raw)
In-Reply-To: <20190806011754.7722-1-marcos.souza.org@gmail.com>
On Mon, Aug 05, 2019 at 10:17:51PM -0300, Marcos Paulo de Souza wrote:
> +void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq,
> + int at_head, rq_end_io_fn *done)
We store a ->rq_disk in struct request, so we should also not need
that. And at_head should either become a bool, or be replaced with
a flags argument, ints used boolean are usually not a good idea.
> @@ -81,7 +80,7 @@ void blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk,
And all the same argument changes that apply to blk_execute_rq_nowait
apply to blk_execute_rq as well.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Doug Gilbert" <dgilbert@interlog.com>,
"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>,
"Hannes Reinecke" <hare@suse.com>,
"Omar Sandoval" <osandov@fb.com>,
"Ming Lei" <ming.lei@redhat.com>,
"Chaitanya Kulkarni" <chaitanya.kulkarni@wdc.com>,
"Damien Le Moal" <damien.lemoal@wdc.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"open list:SCSI TARGET SUBSYSTEM" <target-devel@vger.kernel.org>
Subject: Re: [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait
Date: Tue, 06 Aug 2019 05:19:11 +0000 [thread overview]
Message-ID: <20190806051911.GA13409@lst.de> (raw)
In-Reply-To: <20190806011754.7722-1-marcos.souza.org@gmail.com>
On Mon, Aug 05, 2019 at 10:17:51PM -0300, Marcos Paulo de Souza wrote:
> +void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq,
> + int at_head, rq_end_io_fn *done)
We store a ->rq_disk in struct request, so we should also not need
that. And at_head should either become a bool, or be replaced with
a flags argument, ints used boolean are usually not a good idea.
> @@ -81,7 +80,7 @@ void blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk,
And all the same argument changes that apply to blk_execute_rq_nowait
apply to blk_execute_rq as well.
next prev parent reply other threads:[~2019-08-06 5:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 1:17 [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait Marcos Paulo de Souza
2019-08-06 1:17 ` Marcos Paulo de Souza
2019-08-06 1:17 ` Marcos Paulo de Souza
2019-08-06 1:17 ` Marcos Paulo de Souza
2019-08-06 5:19 ` Christoph Hellwig [this message]
2019-08-06 5:19 ` Christoph Hellwig
2019-08-06 5:19 ` Christoph Hellwig
2019-08-06 5:19 ` Christoph Hellwig
2019-08-06 10:24 ` Marcos Paulo de Souza
2019-08-06 10:24 ` Marcos Paulo de Souza
2019-08-06 10:24 ` Marcos Paulo de Souza
2019-08-06 10:24 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806051911.GA13409@lst.de \
--to=hch@lst.de \
--cc=Kai.Makisara@kolumbus.fi \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dgilbert@interlog.com \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=sagi@grimberg.me \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.