From: Christoph Hellwig <hch@lst.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Tue, 6 Aug 2019 07:29:49 +0200 [thread overview]
Message-ID: <20190806052949.GC13409@lst.de> (raw)
In-Reply-To: <s5hzhkonf0k.wl-tiwai@suse.de>
On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote:
> This won't work as expected, unfortunately. It's a bit tricky check,
> since the driver may have its own mmap implementation via
> substream->ops->mmap, and the dma_buffer.dev.dev might point to
> another object depending on the dma_buffer.dev.type.
>
> So please replace with something like below:
From my gut feeling I'd reorder it a bit to make it more clear like
this:
http://git.infradead.org/users/hch/misc.git/commitdiff/958fccf54d00c16740522f818d23f9350498e911
if this is fine it'll be in the next version, waiting for a little more
feedback on the other patches.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux-foundation.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Michal Simek <monstr@monstr.eu>,
linux-arm-kernel@lists.infradead.org,
linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Tue, 6 Aug 2019 07:29:49 +0200 [thread overview]
Message-ID: <20190806052949.GC13409@lst.de> (raw)
In-Reply-To: <s5hzhkonf0k.wl-tiwai@suse.de>
On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote:
> This won't work as expected, unfortunately. It's a bit tricky check,
> since the driver may have its own mmap implementation via
> substream->ops->mmap, and the dma_buffer.dev.dev might point to
> another object depending on the dma_buffer.dev.type.
>
> So please replace with something like below:
From my gut feeling I'd reorder it a bit to make it more clear like
this:
http://git.infradead.org/users/hch/misc.git/commitdiff/958fccf54d00c16740522f818d23f9350498e911
if this is fine it'll be in the next version, waiting for a little more
feedback on the other patches.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Tue, 06 Aug 2019 05:29:49 +0000 [thread overview]
Message-ID: <20190806052949.GC13409@lst.de> (raw)
In-Reply-To: <20190805091159.7826-5-hch@lst.de>
On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote:
> This won't work as expected, unfortunately. It's a bit tricky check,
> since the driver may have its own mmap implementation via
> substream->ops->mmap, and the dma_buffer.dev.dev might point to
> another object depending on the dma_buffer.dev.type.
>
> So please replace with something like below:
From my gut feeling I'd reorder it a bit to make it more clear like
this:
http://git.infradead.org/users/hch/misc.git/commitdiff/958fccf54d00c16740522f818d23f9350498e911
if this is fine it'll be in the next version, waiting for a little more
feedback on the other patches.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Tue, 6 Aug 2019 07:29:49 +0200 [thread overview]
Message-ID: <20190806052949.GC13409@lst.de> (raw)
In-Reply-To: <s5hzhkonf0k.wl-tiwai@suse.de>
On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote:
> This won't work as expected, unfortunately. It's a bit tricky check,
> since the driver may have its own mmap implementation via
> substream->ops->mmap, and the dma_buffer.dev.dev might point to
> another object depending on the dma_buffer.dev.type.
>
> So please replace with something like below:
From my gut feeling I'd reorder it a bit to make it more clear like
this:
http://git.infradead.org/users/hch/misc.git/commitdiff/958fccf54d00c16740522f818d23f9350498e911
if this is fine it'll be in the next version, waiting for a little more
feedback on the other patches.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Tue, 6 Aug 2019 07:29:49 +0200 [thread overview]
Message-ID: <20190806052949.GC13409@lst.de> (raw)
In-Reply-To: <s5hzhkonf0k.wl-tiwai@suse.de>
On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote:
> This won't work as expected, unfortunately. It's a bit tricky check,
> since the driver may have its own mmap implementation via
> substream->ops->mmap, and the dma_buffer.dev.dev might point to
> another object depending on the dma_buffer.dev.type.
>
> So please replace with something like below:
From my gut feeling I'd reorder it a bit to make it more clear like
this:
http://git.infradead.org/users/hch/misc.git/commitdiff/958fccf54d00c16740522f818d23f9350498e911
if this is fine it'll be in the next version, waiting for a little more
feedback on the other patches.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-06 5:29 UTC|newest]
Thread overview: 160+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 9:11 remove default fallbacks in dma_map_ops v2 Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 1/7] dma-mapping: move the dma_get_sgtable API comments from arm to common code Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 2/7] dma-mapping: explicitly wire up ->mmap and ->get_sgtable Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 3/7] dma-mapping: add a dma_can_mmap helper Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_* Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:22 ` Takashi Iwai
2019-08-05 9:22 ` Takashi Iwai
2019-08-05 9:22 ` Takashi Iwai
2019-08-05 9:22 ` Takashi Iwai
2019-08-05 9:22 ` Takashi Iwai
2019-08-06 5:29 ` Christoph Hellwig [this message]
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 5:29 ` Christoph Hellwig
2019-08-06 6:00 ` Takashi Iwai
2019-08-06 6:00 ` Takashi Iwai
2019-08-06 6:00 ` Takashi Iwai
2019-08-06 6:00 ` Takashi Iwai
2019-08-06 6:00 ` Takashi Iwai
2019-08-05 9:11 ` [PATCH 5/7] m68knommu: add a pgprot_noncached stub Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 6/7] dma-mapping: remove ARCH_NO_COHERENT_DMA_MMAP Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` [PATCH 7/7] dma-mapping: provide a better default ->get_required_mask Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
2019-08-05 9:11 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2019-08-08 15:59 remove default fallbacks in dma_map_ops v3 Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` [PATCH 1/8] dma-mapping: provide a better default ->get_required_mask Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` [PATCH 2/8] dma-mapping: move the dma_get_sgtable API comments from arm to common code Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 15:59 ` Christoph Hellwig
2019-08-08 16:00 ` [PATCH 3/8] dma-mapping: explicitly wire up ->mmap and ->get_sgtable Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` [PATCH 4/8] dma-mapping: add a dma_can_mmap helper Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` [PATCH 5/8] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_* Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-11-04 7:26 ` youling257
2019-11-04 7:26 ` youling257
2019-11-04 7:26 ` youling257
2019-08-08 16:00 ` [PATCH 6/8] arm-nommu: call dma_mmap_from_dev_coherent directly Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-09 9:35 ` Sergei Shtylyov
2019-08-08 16:00 ` [PATCH 7/8] parisc: don't set ARCH_NO_COHERENT_DMA_MMAP Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 7:36 ` Christoph Hellwig
2019-08-15 9:25 ` James Bottomley
2019-08-15 9:25 ` James Bottomley
2019-08-15 9:25 ` James Bottomley
2019-08-15 9:25 ` James Bottomley
2019-08-15 9:25 ` James Bottomley
2019-08-15 10:50 ` Christoph Hellwig
2019-08-15 10:50 ` Christoph Hellwig
2019-08-15 10:50 ` Christoph Hellwig
2019-08-15 10:50 ` Christoph Hellwig
2019-08-15 10:50 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-19 14:25 ` Christoph Hellwig
2019-08-08 16:00 ` [PATCH 8/8] dma-mapping: remove CONFIG_ARCH_NO_COHERENT_DMA_MMAP Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-08 16:00 ` Christoph Hellwig
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-09 7:21 ` Geert Uytterhoeven
2019-08-29 15:38 ` remove default fallbacks in dma_map_ops v3 Christoph Hellwig
2019-08-29 15:38 ` Christoph Hellwig
2019-08-29 15:38 ` Christoph Hellwig
2019-08-29 15:38 ` Christoph Hellwig
2019-08-29 15:38 ` Christoph Hellwig
2019-11-04 7:06 ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_* youling 257
2019-11-04 7:06 ` youling 257
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:27 ` youling 257
2019-11-04 8:27 ` youling 257
2019-11-04 8:27 ` youling 257
2019-11-04 8:27 ` youling 257
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman
2019-11-04 9:03 ` Takashi Iwai
2019-11-04 9:03 ` Takashi Iwai
2019-11-04 9:03 ` Takashi Iwai
2019-11-04 9:03 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806052949.GC13409@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=robin.murphy@arm.com \
--cc=tiwai@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.