From: Christoph Hellwig <hch@lst.de>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: Anshuman Khandual <anshuman.linux@gmail.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Mike Anderson <andmike@linux.ibm.com>,
Ram Pai <linuxram@us.ibm.com>,
linux-kernel@vger.kernel.org,
Claudio Carvalho <cclaudio@linux.ibm.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 13/16] powerpc/pseries/iommu: Don't use dma_iommu_ops on secure guests
Date: Tue, 6 Aug 2019 07:48:41 +0200 [thread overview]
Message-ID: <20190806054841.GA14197@lst.de> (raw)
In-Reply-To: <20190806052237.12525-14-bauerman@linux.ibm.com>
On Tue, Aug 06, 2019 at 02:22:34AM -0300, Thiago Jung Bauermann wrote:
> @@ -1318,7 +1319,10 @@ void iommu_init_early_pSeries(void)
> of_reconfig_notifier_register(&iommu_reconfig_nb);
> register_memory_notifier(&iommu_mem_nb);
>
> - set_pci_dma_ops(&dma_iommu_ops);
> + if (is_secure_guest())
> + set_pci_dma_ops(NULL);
> + else
> + set_pci_dma_ops(&dma_iommu_ops);
Shoudn't:
if (!is_secure_guest())
set_pci_dma_ops(&dma_iommu_ops);
be enough here, given that NULL is the default?
Also either way I think this conditional needs a comment explaining
why it is there.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Anshuman Khandual <anshuman.linux@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christoph Hellwig <hch@lst.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Mike Anderson <andmike@linux.ibm.com>,
Paul Mackerras <paulus@samba.org>, Ram Pai <linuxram@us.ibm.com>,
Claudio Carvalho <cclaudio@linux.ibm.com>
Subject: Re: [PATCH v3 13/16] powerpc/pseries/iommu: Don't use dma_iommu_ops on secure guests
Date: Tue, 6 Aug 2019 07:48:41 +0200 [thread overview]
Message-ID: <20190806054841.GA14197@lst.de> (raw)
In-Reply-To: <20190806052237.12525-14-bauerman@linux.ibm.com>
On Tue, Aug 06, 2019 at 02:22:34AM -0300, Thiago Jung Bauermann wrote:
> @@ -1318,7 +1319,10 @@ void iommu_init_early_pSeries(void)
> of_reconfig_notifier_register(&iommu_reconfig_nb);
> register_memory_notifier(&iommu_mem_nb);
>
> - set_pci_dma_ops(&dma_iommu_ops);
> + if (is_secure_guest())
> + set_pci_dma_ops(NULL);
> + else
> + set_pci_dma_ops(&dma_iommu_ops);
Shoudn't:
if (!is_secure_guest())
set_pci_dma_ops(&dma_iommu_ops);
be enough here, given that NULL is the default?
Also either way I think this conditional needs a comment explaining
why it is there.
next prev parent reply other threads:[~2019-08-06 6:04 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 5:22 [PATCH v3 00/16] Secure Virtual Machine Enablement Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 01/16] powerpc/kernel: Add ucall_norets() ultravisor call handler Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 02/16] powerpc/pseries: Introduce option to build secure virtual machines Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [RFC PATCH v3 03/16] powerpc: Add support for adding an ESM blob to the zImage wrapper Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 04/16] powerpc/prom_init: Add the ESM call to prom_init Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 05/16] powerpc/pseries/svm: Add helpers for UV_SHARE_PAGE and UV_UNSHARE_PAGE Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 06/16] powerpc: Introduce the MSR_S bit Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 07/16] powerpc/pseries: Add and use LPPACA_SIZE constant Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 08/16] powerpc/pseries/svm: Use shared memory for LPPACA structures Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-12 12:36 ` Michael Ellerman
2019-08-12 12:36 ` Michael Ellerman
2019-08-12 21:43 ` Thiago Jung Bauermann
2019-08-12 21:43 ` Thiago Jung Bauermann
2019-08-14 10:54 ` Michael Ellerman
2019-08-14 10:54 ` Michael Ellerman
2019-08-16 0:52 ` Thiago Jung Bauermann
2019-08-16 0:52 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 09/16] powerpc/pseries/svm: Use shared memory for Debug Trace Log (DTL) Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 10/16] powerpc/pseries/svm: Unshare all pages before kexecing a new kernel Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 11/16] powerpc/pseries/svm: Export guest SVM status to user space via sysfs Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-12 13:03 ` Michael Ellerman
2019-08-12 13:03 ` Michael Ellerman
2019-08-12 23:21 ` Thiago Jung Bauermann
2019-08-12 23:21 ` Thiago Jung Bauermann
2019-08-15 6:30 ` Michael Ellerman
2019-08-15 6:30 ` Michael Ellerman
2019-08-16 0:49 ` Thiago Jung Bauermann
2019-08-16 0:49 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 12/16] powerpc/pseries/svm: Disable doorbells in SVM guests Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 13/16] powerpc/pseries/iommu: Don't use dma_iommu_ops on secure guests Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
2019-08-06 5:48 ` Christoph Hellwig [this message]
2019-08-06 5:48 ` Christoph Hellwig
2019-08-07 1:37 ` Thiago Jung Bauermann
2019-08-07 1:37 ` Thiago Jung Bauermann
2019-08-06 5:22 ` [PATCH v3 14/16] powerpc/pseries/svm: Force SWIOTLB for " Thiago Jung Bauermann
2019-08-06 5:22 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806054841.GA14197@lst.de \
--to=hch@lst.de \
--cc=aik@ozlabs.ru \
--cc=andmike@linux.ibm.com \
--cc=anshuman.linux@gmail.com \
--cc=bauerman@linux.ibm.com \
--cc=cclaudio@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.