From: Greg KH <gregkh@linuxfoundation.org>
To: chenzefeng <chenzefeng2@huawei.com>
Cc: tony.luck@intel.com, fenghua.yu@intel.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ia64:unwind: fix double free for mod->arch.init_unw_table
Date: Tue, 06 Aug 2019 07:58:53 +0000 [thread overview]
Message-ID: <20190806075853.GA701@kroah.com> (raw)
In-Reply-To: <1565077593-72480-1-git-send-email-chenzefeng2@huawei.com>
On Tue, Aug 06, 2019 at 03:46:33PM +0800, chenzefeng wrote:
> The function free_module in file kernel/module.c as follow:
>
> void free_module(struct module *mod) {
> ......
> module_arch_cleanup(mod);
> ......
> module_arch_freeing_init(mod);
> ......
> }
>
> Both module_arch_cleanup and module_arch_freeing_init function
> would free the mod->arch.init_unw_table, which cause double free.
>
> Here, set mod->arch.init_unw_table = NULL after remove the unwind
> table to avoid double free.
>
> Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
> ---
> arch/ia64/kernel/module.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: chenzefeng <chenzefeng2@huawei.com>
Cc: tony.luck@intel.com, fenghua.yu@intel.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ia64:unwind: fix double free for mod->arch.init_unw_table
Date: Tue, 6 Aug 2019 09:58:53 +0200 [thread overview]
Message-ID: <20190806075853.GA701@kroah.com> (raw)
In-Reply-To: <1565077593-72480-1-git-send-email-chenzefeng2@huawei.com>
On Tue, Aug 06, 2019 at 03:46:33PM +0800, chenzefeng wrote:
> The function free_module in file kernel/module.c as follow:
>
> void free_module(struct module *mod) {
> ......
> module_arch_cleanup(mod);
> ......
> module_arch_freeing_init(mod);
> ......
> }
>
> Both module_arch_cleanup and module_arch_freeing_init function
> would free the mod->arch.init_unw_table, which cause double free.
>
> Here, set mod->arch.init_unw_table = NULL after remove the unwind
> table to avoid double free.
>
> Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
> ---
> arch/ia64/kernel/module.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2019-08-06 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 7:46 [PATCH] ia64:unwind: fix double free for mod->arch.init_unw_table chenzefeng
2019-08-06 7:46 ` chenzefeng
2019-08-06 7:58 ` Greg KH [this message]
2019-08-06 7:58 ` Greg KH
2019-08-06 17:23 ` Luck, Tony
2019-08-06 17:23 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806075853.GA701@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chenzefeng2@huawei.com \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.