[Xen-devel] [PATCH] passthrough/amd: Drop "IOMMU not found" message

[Xen-devel] [PATCH] passthrough/amd: Drop "IOMMU not found" message

[Andrew Cooper]

Since c/s 9fa94e10585 "x86/ACPI: also parse AMD IOMMU tables early", this
function is unconditionally called in all cases where a DMAR ACPI table
doesn't exist.

As a consequnce, "AMD-Vi: IOMMU not found!" is printed in all cases where an
IOMMU isn't present, even on non-AMD systems.  Drop the message - it isn't
terribly interesting anyway, and is now misleading is a number of common
cases.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
CC: Brian Woods <brian.woods@amd.com>
---
 xen/drivers/passthrough/amd/pci_amd_iommu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c
index b3e1933b53..3bcfcc8404 100644
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -155,7 +155,6 @@ int __init acpi_ivrs_init(void)
 
     if ( (amd_iommu_detect_acpi() !=0) || (iommu_found() == 0) )
     {
-        printk("AMD-Vi: IOMMU not found!\n");
         iommu_intremap = 0;
         return -ENODEV;
     }
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] passthrough/amd: Drop "IOMMU not found" message

[Jan Beulich]

On 05.08.2019 18:44, Andrew Cooper wrote:
> Since c/s 9fa94e10585 "x86/ACPI: also parse AMD IOMMU tables early", this
> function is unconditionally called in all cases where a DMAR ACPI table
> doesn't exist.
> 
> As a consequnce, "AMD-Vi: IOMMU not found!" is printed in all cases where an
> IOMMU isn't present, even on non-AMD systems.

Oh, I didn't even notice this yet.

>  Drop the message - it isn't
> terribly interesting anyway, and is now misleading is a number of common
> cases.

Plus there's no VT-d side equivalent message.

Acked-by: Jan Beulich <jbeulich@suse.com>

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] passthrough/amd: Drop "IOMMU not found" message

[Woods, Brian]

On Mon, Aug 05, 2019 at 05:44:30PM +0100, Andy Cooper wrote:
> Since c/s 9fa94e10585 "x86/ACPI: also parse AMD IOMMU tables early", this
> function is unconditionally called in all cases where a DMAR ACPI table
> doesn't exist.
> 
> As a consequnce, "AMD-Vi: IOMMU not found!" is printed in all cases where an
> IOMMU isn't present, even on non-AMD systems.  Drop the message - it isn't
> terribly interesting anyway, and is now misleading is a number of common
> cases.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Brian Woods <brian.woods@amd.com>

> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wl@xen.org>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> CC: Brian Woods <brian.woods@amd.com>
> ---
>  xen/drivers/passthrough/amd/pci_amd_iommu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> index b3e1933b53..3bcfcc8404 100644
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -155,7 +155,6 @@ int __init acpi_ivrs_init(void)
>  
>      if ( (amd_iommu_detect_acpi() !=0) || (iommu_found() == 0) )
>      {
> -        printk("AMD-Vi: IOMMU not found!\n");
>          iommu_intremap = 0;
>          return -ENODEV;
>      }
> -- 
> 2.11.0
> 

-- 
Brian Woods

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel