* [PATCH] IB/mlx5: Check the correct variable in error handling code
@ 2019-08-07 12:32 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2019-08-07 12:32 UTC (permalink / raw)
To: Leon Romanovsky, Yishai Hadas
Cc: Doug Ledford, Jason Gunthorpe, linux-rdma, kernel-janitors
The code accidentally checks "event_sub" instead of "event_sub->eventfd".
Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events over DEVX")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/infiniband/hw/mlx5/devx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c
index fd577ffd7864..e24df414fd47 100644
--- a/drivers/infiniband/hw/mlx5/devx.c
+++ b/drivers/infiniband/hw/mlx5/devx.c
@@ -2041,7 +2041,7 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DEVX_SUBSCRIBE_EVENT)(
event_sub->eventfd =
eventfd_ctx_fdget(redirect_fd);
- if (IS_ERR(event_sub)) {
+ if (IS_ERR(event_sub->eventfd)) {
err = PTR_ERR(event_sub->eventfd);
event_sub->eventfd = NULL;
goto err;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] IB/mlx5: Check the correct variable in error handling code
2019-08-07 12:32 ` Dan Carpenter
@ 2019-08-07 12:59 ` Jason Gunthorpe
-1 siblings, 0 replies; 8+ messages in thread
From: Jason Gunthorpe @ 2019-08-07 12:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Leon Romanovsky, Yishai Hadas, Doug Ledford, linux-rdma,
kernel-janitors
On Wed, Aug 07, 2019 at 03:32:36PM +0300, Dan Carpenter wrote:
> The code accidentally checks "event_sub" instead of "event_sub->eventfd".
>
> Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events over DEVX")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/infiniband/hw/mlx5/devx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] IB/mlx5: Check the correct variable in error handling code
@ 2019-08-07 12:59 ` Jason Gunthorpe
0 siblings, 0 replies; 8+ messages in thread
From: Jason Gunthorpe @ 2019-08-07 12:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Leon Romanovsky, Yishai Hadas, Doug Ledford, linux-rdma,
kernel-janitors
On Wed, Aug 07, 2019 at 03:32:36PM +0300, Dan Carpenter wrote:
> The code accidentally checks "event_sub" instead of "event_sub->eventfd".
>
> Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events over DEVX")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/infiniband/hw/mlx5/devx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] IB/mlx5: Check the correct variable in error handling code
2019-08-07 12:32 ` Dan Carpenter
@ 2019-08-07 13:15 ` Leon Romanovsky
-1 siblings, 0 replies; 8+ messages in thread
From: Leon Romanovsky @ 2019-08-07 13:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: Yishai Hadas, Doug Ledford, Jason Gunthorpe, linux-rdma,
kernel-janitors
On Wed, Aug 07, 2019 at 03:32:36PM +0300, Dan Carpenter wrote:
> The code accidentally checks "event_sub" instead of "event_sub->eventfd".
>
> Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events over DEVX")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/infiniband/hw/mlx5/devx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] IB/mlx5: Check the correct variable in error handling code
@ 2019-08-07 13:15 ` Leon Romanovsky
0 siblings, 0 replies; 8+ messages in thread
From: Leon Romanovsky @ 2019-08-07 13:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: Yishai Hadas, Doug Ledford, Jason Gunthorpe, linux-rdma,
kernel-janitors
On Wed, Aug 07, 2019 at 03:32:36PM +0300, Dan Carpenter wrote:
> The code accidentally checks "event_sub" instead of "event_sub->eventfd".
>
> Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events over DEVX")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/infiniband/hw/mlx5/devx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] IB/mlx5: Check the correct variable in error handling code
2019-08-07 12:32 ` Dan Carpenter
@ 2019-08-07 20:47 ` Doug Ledford
-1 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2019-08-07 20:47 UTC (permalink / raw)
To: Dan Carpenter, Leon Romanovsky, Yishai Hadas
Cc: Jason Gunthorpe, linux-rdma, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
On Wed, 2019-08-07 at 15:32 +0300, Dan Carpenter wrote:
> The code accidentally checks "event_sub" instead of "event_sub-
> >eventfd".
>
> Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events
> over DEVX")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to for-rc.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] IB/mlx5: Check the correct variable in error handling code
@ 2019-08-07 20:47 ` Doug Ledford
0 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2019-08-07 20:47 UTC (permalink / raw)
To: Dan Carpenter, Leon Romanovsky, Yishai Hadas
Cc: Jason Gunthorpe, linux-rdma, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
On Wed, 2019-08-07 at 15:32 +0300, Dan Carpenter wrote:
> The code accidentally checks "event_sub" instead of "event_sub-
> >eventfd".
>
> Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events
> over DEVX")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to for-rc.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread