From: Stephen Boyd <sboyd@kernel.org>
To: Colin King <colin.king@canonical.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den
Date: Wed, 07 Aug 2019 21:23:41 +0000 [thread overview]
Message-ID: <20190807212342.ABD8921743@mail.kernel.org> (raw)
In-Reply-To: <20190701165020.19840-1-colin.king@canonical.com>
Quoting Colin King (2019-07-01 09:50:20)
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable n_den is initialized however that value is never read
> as n_den is re-assigned a little later in the two paths of a
> following if-statement. Remove the redundant assignment.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Applied to clk-next
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Colin King <colin.king@canonical.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den
Date: Wed, 07 Aug 2019 14:23:41 -0700 [thread overview]
Message-ID: <20190807212342.ABD8921743@mail.kernel.org> (raw)
In-Reply-To: <20190701165020.19840-1-colin.king@canonical.com>
Quoting Colin King (2019-07-01 09:50:20)
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable n_den is initialized however that value is never read
> as n_den is re-assigned a little later in the two paths of a
> following if-statement. Remove the redundant assignment.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Applied to clk-next
next prev parent reply other threads:[~2019-08-07 21:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 16:50 [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den Colin King
2019-07-01 16:50 ` Colin King
2019-07-22 21:24 ` Stephen Boyd
2019-07-22 21:24 ` Stephen Boyd
2019-07-22 21:43 ` Christophe JAILLET
2019-07-22 21:43 ` Christophe JAILLET
2019-07-22 21:43 ` Christophe JAILLET
2019-07-22 21:53 ` Stephen Boyd
2019-07-22 21:53 ` Stephen Boyd
2019-07-22 22:00 ` Christophe JAILLET
2019-07-22 22:00 ` Christophe JAILLET
2019-07-22 22:00 ` Christophe JAILLET
2019-07-22 22:24 ` Stephen Boyd
2019-07-22 22:24 ` Stephen Boyd
2019-07-23 12:29 ` Mike Looijmans
2019-07-23 12:29 ` Mike Looijmans
2019-08-07 21:23 ` Stephen Boyd [this message]
2019-08-07 21:23 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807212342.ABD8921743@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.