[Virtio-fs] Rebased kernel patches to 5.3-rc kernel

[Virtio-fs] Rebased kernel patches to 5.3-rc kernel

[Vivek Goyal]

Hi All,

I have rebased virtio_fs kernel patches to 5.3-rc kernel and pushed it to my
github repo.

https://github.com/rhvgoyal/linux/commits/vivek-5.3-aug-07-2019

This compiles and passes basic tests. It needs more testing though.

It needs one patch in virtiofsd to change bit position of MAP_ALIGNMENT
flag. I posted a patch for that.

Give it a try and let us know if you face issues.

Thanks
Vivek

Re: [Virtio-fs] Rebased kernel patches to 5.3-rc kernel

[Boeuf, Sebastien]

Thank you Vivek! I'm definitely gonna try this new branch soon, and I'll let you know if I run into any issue :)

Thanks,
Sebastien
________________________________________
From: Vivek Goyal [vgoyal@redhat.com]
Sent: Wednesday, August 07, 2019 2:26 PM
To: virtio-fs-list
Cc: Boeuf, Sebastien
Subject: Rebased kernel patches to 5.3-rc kernel

Hi All,

I have rebased virtio_fs kernel patches to 5.3-rc kernel and pushed it to my
github repo.

https://github.com/rhvgoyal/linux/commits/vivek-5.3-aug-07-2019

This compiles and passes basic tests. It needs more testing though.

It needs one patch in virtiofsd to change bit position of MAP_ALIGNMENT
flag. I posted a patch for that.

Give it a try and let us know if you face issues.

Thanks
Vivek

Re: [Virtio-fs] Rebased kernel patches to 5.3-rc kernel

[Vivek Goyal]

On Wed, Aug 07, 2019 at 11:23:35PM +0000, Boeuf, Sebastien wrote:
> Hi Vivek, I just tried the new kernel and I run into issues with my VMM.
> When I try to mount from inside the guest with the following command:
> # mount -t virtio_fs /dev/null mount_dir/ -o tag=myfs,rootmode=040000,user_id=0,group_id=0,dax
> 
> I realized the mount command changed into this:
> mount -t virtio_fs myfs mount_dir/ -o rootmode=040000,user_id=0,group_id=0,dax

Hi Sebastien,

Adding virtio-fs list back. I think its a good idea to keep conversation
on list, just in case others face similar issues.

> 
> It'd be nice to update it from the official documentation.

Yes it will be nice to update doc.

Stefan, can you please take care of updating docs. We will have to mention
for 4.19 kernel syntax is different and for latest kernel syntax is
different.

> 
> Now, when I try to read from my files, I get nothing. I see the mmap happening,
> but the output of `cat` is empty.
> Can you think of anything that changed that could affect the mapping?

For me it works. Which virtiofsd are you using. I am using virtio-fs-dev
branch of qemu.

https://gitlab.com/virtio-fs/qemu/commits/virtio-fs-dev

If it still does not work, try disabling dax and see if it helps.

Thanks
Vivek

Re: [Virtio-fs] Rebased kernel patches to 5.3-rc kernel

[Boeuf, Sebastien]

Hi Vivek,

On Wed, 2019-08-07 at 20:23 -0400, Vivek Goyal wrote:
> On Wed, Aug 07, 2019 at 11:23:35PM +0000, Boeuf, Sebastien wrote:
> > Hi Vivek, I just tried the new kernel and I run into issues with my
> > VMM.
> > When I try to mount from inside the guest with the following
> > command:
> > # mount -t virtio_fs /dev/null mount_dir/ -o
> > tag=myfs,rootmode=040000,user_id=0,group_id=0,dax
> > 
> > I realized the mount command changed into this:
> > mount -t virtio_fs myfs mount_dir/ -o
> > rootmode=040000,user_id=0,group_id=0,dax
> 
> Hi Sebastien,
> 
> Adding virtio-fs list back. I think its a good idea to keep
> conversation
> on list, just in case others face similar issues.

Oh yes sorry about that.

> 
> > 
> > It'd be nice to update it from the official documentation.
> 
> Yes it will be nice to update doc.

:)

> 
> Stefan, can you please take care of updating docs. We will have to
> mention
> for 4.19 kernel syntax is different and for latest kernel syntax is
> different.
> 
> > 
> > Now, when I try to read from my files, I get nothing. I see the
> > mmap happening,
> > but the output of `cat` is empty.
> > Can you think of anything that changed that could affect the
> > mapping?
> 
> For me it works. Which virtiofsd are you using. I am using virtio-fs-
> dev
> branch of qemu.
> 
> https://gitlab.com/virtio-fs/qemu/commits/virtio-fs-dev
> 
> If it still does not work, try disabling dax and see if it helps.

Yes I'm using the same branch as you. I got it working eventually. I
was ignoring the flags passed by virtiofsd to do the mmap and it caused
the mmap to fail since I was trying to mmap R/W when virtiofsd was
telling me to do RO.

Anyway, I confirm it's all working now :)

Thanks,
Sebastien
> 
> Thanks
> Vivek

Re: [Virtio-fs] Rebased kernel patches to 5.3-rc kernel

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On Wed, Aug 07, 2019 at 08:23:05PM -0400, Vivek Goyal wrote:
> On Wed, Aug 07, 2019 at 11:23:35PM +0000, Boeuf, Sebastien wrote:
> > Hi Vivek, I just tried the new kernel and I run into issues with my VMM.
> > When I try to mount from inside the guest with the following command:
> > # mount -t virtio_fs /dev/null mount_dir/ -o tag=myfs,rootmode=040000,user_id=0,group_id=0,dax
> > 
> > I realized the mount command changed into this:
> > mount -t virtio_fs myfs mount_dir/ -o rootmode=040000,user_id=0,group_id=0,dax
> 
> Hi Sebastien,
> 
> Adding virtio-fs list back. I think its a good idea to keep conversation
> on list, just in case others face similar issues.
> 
> > 
> > It'd be nice to update it from the official documentation.
> 
> Yes it will be nice to update doc.
> 
> Stefan, can you please take care of updating docs. We will have to mention
> for 4.19 kernel syntax is different and for latest kernel syntax is
> different.

Yes, I'll publish updated instructions.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]