All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: "Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Halil Pasic <pasic@linux.ibm.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: Regression due to d98849aff879 (dma-direct: handle DMA_ATTR_NO_KERNEL_MAPPING in common code)
Date: Thu, 8 Aug 2019 09:48:58 +0200	[thread overview]
Message-ID: <20190808074858.GA30308@lst.de> (raw)
In-Reply-To: <1565191457.2323.41.camel@pengutronix.de>

On Wed, Aug 07, 2019 at 05:24:17PM +0200, Lucas Stach wrote:
> I would suggest to place this line above the comment, as the comment
> only really applies to the return value. Other than this nitpick, this
> matches my understanding of the required changes, so:
> 
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

Thanks, I've applied it with that fixed up.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Christoph Hellwig <hch@lst.de>,
	"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Thiago Jung Bauermann <bauerman@linux.ibm.com>,
	Halil Pasic <pasic@linux.ibm.com>
Subject: Re: Regression due to d98849aff879 (dma-direct: handle DMA_ATTR_NO_KERNEL_MAPPING in common code)
Date: Thu, 8 Aug 2019 09:48:58 +0200	[thread overview]
Message-ID: <20190808074858.GA30308@lst.de> (raw)
In-Reply-To: <1565191457.2323.41.camel@pengutronix.de>

On Wed, Aug 07, 2019 at 05:24:17PM +0200, Lucas Stach wrote:
> I would suggest to place this line above the comment, as the comment
> only really applies to the return value. Other than this nitpick, this
> matches my understanding of the required changes, so:
> 
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

Thanks, I've applied it with that fixed up.

  reply	other threads:[~2019-08-08  7:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06  9:13 Regression due to d98849aff879 (dma-direct: handle DMA_ATTR_NO_KERNEL_MAPPING in common code) Lucas Stach
2019-08-06  9:13 ` Lucas Stach
2019-08-06 11:33 ` Christoph Hellwig
2019-08-06 11:33   ` Christoph Hellwig
2019-08-06 12:20   ` Lucas Stach
2019-08-06 12:20     ` Lucas Stach
2019-08-06 13:38   ` Lendacky, Thomas
2019-08-06 13:38     ` Lendacky, Thomas
2019-08-06 14:04     ` Christoph Hellwig
2019-08-06 14:04       ` Christoph Hellwig
2019-08-06 14:06       ` Lucas Stach
2019-08-06 14:06         ` Lucas Stach
2019-08-06 14:18         ` Lendacky, Thomas
2019-08-06 14:18           ` Lendacky, Thomas
2019-08-06 15:46           ` Christoph Hellwig
2019-08-06 15:46             ` Christoph Hellwig
2019-08-06 15:59             ` Lendacky, Thomas
2019-08-06 15:59               ` Lendacky, Thomas
2019-08-06 16:07               ` Christoph Hellwig
2019-08-06 16:07                 ` Christoph Hellwig
2019-08-06 15:44         ` Christoph Hellwig
2019-08-06 15:44           ` Christoph Hellwig
2019-08-07 15:24           ` Lucas Stach
2019-08-07 15:24             ` Lucas Stach
2019-08-08  7:48             ` Christoph Hellwig [this message]
2019-08-08  7:48               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190808074858.GA30308@lst.de \
    --to=hch@lst.de \
    --cc=Thomas.Lendacky@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.