From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rob Herring <robh+dt@kernel.org>, Saravana Kannan <saravanak@google.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] of/platform: Clean up a return type in of_link_property()
Date: Thu, 08 Aug 2019 10:32:07 +0000 [thread overview]
Message-ID: <20190808103207.GA30506@mwanda> (raw)
This function is supposed to return zero on success and negative
error codes on failure but currently it returns true on failure. The
caller only checks for zero and non-zero so this mixup doesn't cause any
runtime issues.
Fixes: 690ff7881b26 ("of/platform: Add functional dependency link from DT bindings")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/of/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 21838226d68a..86fb8ab8c012 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -625,7 +625,7 @@ static const struct supplier_bindings bindings[] = {
{ },
};
-static bool of_link_property(struct device *dev, struct device_node *con_np,
+static int of_link_property(struct device *dev, struct device_node *con_np,
const char *prop)
{
struct device_node *phandle;
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rob Herring <robh+dt@kernel.org>, Saravana Kannan <saravanak@google.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] of/platform: Clean up a return type in of_link_property()
Date: Thu, 8 Aug 2019 13:32:07 +0300 [thread overview]
Message-ID: <20190808103207.GA30506@mwanda> (raw)
This function is supposed to return zero on success and negative
error codes on failure but currently it returns true on failure. The
caller only checks for zero and non-zero so this mixup doesn't cause any
runtime issues.
Fixes: 690ff7881b26 ("of/platform: Add functional dependency link from DT bindings")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/of/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 21838226d68a..86fb8ab8c012 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -625,7 +625,7 @@ static const struct supplier_bindings bindings[] = {
{ },
};
-static bool of_link_property(struct device *dev, struct device_node *con_np,
+static int of_link_property(struct device *dev, struct device_node *con_np,
const char *prop)
{
struct device_node *phandle;
--
2.20.1
next reply other threads:[~2019-08-08 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 10:32 Dan Carpenter [this message]
2019-08-08 10:32 ` [PATCH] of/platform: Clean up a return type in of_link_property() Dan Carpenter
2019-08-08 16:09 ` Frank Rowand
2019-08-08 16:09 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808103207.GA30506@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.