From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: netdev@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH v2 07/17] hns3: no need to check return value of debugfs_create functions
Date: Fri, 9 Aug 2019 14:30:58 +0200 [thread overview]
Message-ID: <20190809123108.27065-8-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20190809123108.27065-1-gregkh@linuxfoundation.org>
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
.../net/ethernet/hisilicon/hns3/hns3_debugfs.c | 17 ++---------------
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c
index a4b937286f55..2e79380502e9 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c
@@ -372,20 +372,11 @@ static const struct file_operations hns3_dbg_cmd_fops = {
void hns3_dbg_init(struct hnae3_handle *handle)
{
const char *name = pci_name(handle->pdev);
- struct dentry *pfile;
handle->hnae3_dbgfs = debugfs_create_dir(name, hns3_dbgfs_root);
- if (!handle->hnae3_dbgfs)
- return;
- pfile = debugfs_create_file("cmd", 0600, handle->hnae3_dbgfs, handle,
- &hns3_dbg_cmd_fops);
- if (!pfile) {
- debugfs_remove_recursive(handle->hnae3_dbgfs);
- handle->hnae3_dbgfs = NULL;
- dev_warn(&handle->pdev->dev, "create file for %s fail\n",
- name);
- }
+ debugfs_create_file("cmd", 0600, handle->hnae3_dbgfs, handle,
+ &hns3_dbg_cmd_fops);
}
void hns3_dbg_uninit(struct hnae3_handle *handle)
@@ -397,10 +388,6 @@ void hns3_dbg_uninit(struct hnae3_handle *handle)
void hns3_dbg_register_debugfs(const char *debugfs_dir_name)
{
hns3_dbgfs_root = debugfs_create_dir(debugfs_dir_name, NULL);
- if (!hns3_dbgfs_root) {
- pr_warn("Register debugfs for %s fail\n", debugfs_dir_name);
- return;
- }
}
void hns3_dbg_unregister_debugfs(void)
--
2.22.0
next prev parent reply other threads:[~2019-08-09 12:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 12:30 [PATCH v2 00/17] Networking driver debugfs cleanups Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 01/17] wimax: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 02/17] bonding: no need to print a message if debugfs_create_dir() fails Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 03/17] mlx5: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 04/17] xgbe: " Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 05/17] bnxt: " Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 06/17] cxgb4: " Greg Kroah-Hartman
2019-08-09 12:30 ` Greg Kroah-Hartman [this message]
2019-08-09 12:30 ` [PATCH v2 08/17] nfp: " Greg Kroah-Hartman
2019-08-09 17:10 ` Jakub Kicinski
2019-08-09 12:31 ` [PATCH v2 09/17] stmmac: " Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 10/17] dpaa2: " Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 11/17] qca: " Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 12/17] skge: " Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 13/17] mvpp2: " Greg Kroah-Hartman
2019-08-09 12:31 ` [Intel-wired-lan] [PATCH v2 14/17] fm10k: " Greg Kroah-Hartman
2019-08-09 12:31 ` Greg Kroah-Hartman
2019-08-09 12:31 ` [Intel-wired-lan] [PATCH v2 15/17] i40e: " Greg Kroah-Hartman
2019-08-09 12:31 ` Greg Kroah-Hartman
2019-08-09 12:31 ` [Intel-wired-lan] [PATCH v2 16/17] ixgbe: " Greg Kroah-Hartman
2019-08-09 12:31 ` Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 17/17] ieee802154: " Greg Kroah-Hartman
2019-08-09 12:34 ` Hennerich, Michael
2019-08-09 18:20 ` [PATCH v2 00/17] Networking driver debugfs cleanups David Miller
2019-08-10 10:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809123108.27065-8-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.