From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 15/17] i40e: no need to check return value of debugfs_create functions
Date: Fri, 9 Aug 2019 14:31:06 +0200 [thread overview]
Message-ID: <20190809123108.27065-16-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20190809123108.27065-1-gregkh@linuxfoundation.org>
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: intel-wired-lan at lists.osuosl.org
Cc: netdev at vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
.../net/ethernet/intel/i40e/i40e_debugfs.c | 22 ++++---------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 55d20acfcf70..41232898d8ae 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -1732,29 +1732,15 @@ static const struct file_operations i40e_dbg_netdev_ops_fops = {
**/
void i40e_dbg_pf_init(struct i40e_pf *pf)
{
- struct dentry *pfile;
const char *name = pci_name(pf->pdev);
- const struct device *dev = &pf->pdev->dev;
pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root);
- if (!pf->i40e_dbg_pf)
- return;
-
- pfile = debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf,
- &i40e_dbg_command_fops);
- if (!pfile)
- goto create_failed;
- pfile = debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf,
- &i40e_dbg_netdev_ops_fops);
- if (!pfile)
- goto create_failed;
+ debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf,
+ &i40e_dbg_command_fops);
- return;
-
-create_failed:
- dev_info(dev, "debugfs dir/file for %s failed\n", name);
- debugfs_remove_recursive(pf->i40e_dbg_pf);
+ debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf,
+ &i40e_dbg_netdev_ops_fops);
}
/**
--
2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: netdev@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"David S. Miller" <davem@davemloft.net>,
intel-wired-lan@lists.osuosl.org
Subject: [PATCH v2 15/17] i40e: no need to check return value of debugfs_create functions
Date: Fri, 9 Aug 2019 14:31:06 +0200 [thread overview]
Message-ID: <20190809123108.27065-16-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20190809123108.27065-1-gregkh@linuxfoundation.org>
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
.../net/ethernet/intel/i40e/i40e_debugfs.c | 22 ++++---------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 55d20acfcf70..41232898d8ae 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -1732,29 +1732,15 @@ static const struct file_operations i40e_dbg_netdev_ops_fops = {
**/
void i40e_dbg_pf_init(struct i40e_pf *pf)
{
- struct dentry *pfile;
const char *name = pci_name(pf->pdev);
- const struct device *dev = &pf->pdev->dev;
pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root);
- if (!pf->i40e_dbg_pf)
- return;
-
- pfile = debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf,
- &i40e_dbg_command_fops);
- if (!pfile)
- goto create_failed;
- pfile = debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf,
- &i40e_dbg_netdev_ops_fops);
- if (!pfile)
- goto create_failed;
+ debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf,
+ &i40e_dbg_command_fops);
- return;
-
-create_failed:
- dev_info(dev, "debugfs dir/file for %s failed\n", name);
- debugfs_remove_recursive(pf->i40e_dbg_pf);
+ debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf,
+ &i40e_dbg_netdev_ops_fops);
}
/**
--
2.22.0
next prev parent reply other threads:[~2019-08-09 12:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 12:30 [PATCH v2 00/17] Networking driver debugfs cleanups Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 01/17] wimax: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 02/17] bonding: no need to print a message if debugfs_create_dir() fails Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 03/17] mlx5: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 04/17] xgbe: " Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 05/17] bnxt: " Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 06/17] cxgb4: " Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 07/17] hns3: " Greg Kroah-Hartman
2019-08-09 12:30 ` [PATCH v2 08/17] nfp: " Greg Kroah-Hartman
2019-08-09 17:10 ` Jakub Kicinski
2019-08-09 12:31 ` [PATCH v2 09/17] stmmac: " Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 10/17] dpaa2: " Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 11/17] qca: " Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 12/17] skge: " Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 13/17] mvpp2: " Greg Kroah-Hartman
2019-08-09 12:31 ` [Intel-wired-lan] [PATCH v2 14/17] fm10k: " Greg Kroah-Hartman
2019-08-09 12:31 ` Greg Kroah-Hartman
2019-08-09 12:31 ` Greg Kroah-Hartman [this message]
2019-08-09 12:31 ` [PATCH v2 15/17] i40e: " Greg Kroah-Hartman
2019-08-09 12:31 ` [Intel-wired-lan] [PATCH v2 16/17] ixgbe: " Greg Kroah-Hartman
2019-08-09 12:31 ` Greg Kroah-Hartman
2019-08-09 12:31 ` [PATCH v2 17/17] ieee802154: " Greg Kroah-Hartman
2019-08-09 12:34 ` Hennerich, Michael
2019-08-09 18:20 ` [PATCH v2 00/17] Networking driver debugfs cleanups David Miller
2019-08-10 10:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809123108.27065-16-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.