From: Michal Hocko <mhocko@kernel.org>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS
Date: Mon, 12 Aug 2019 10:45:24 +0200 [thread overview]
Message-ID: <20190812084524.GC5117@dhcp22.suse.cz> (raw)
In-Reply-To: <20190811234614.GZ17747@sasha-vm>
On Sun 11-08-19 19:46:14, Sasha Levin wrote:
> On Fri, Aug 09, 2019 at 03:17:18PM -0700, Andrew Morton wrote:
> > On Fri, 9 Aug 2019 08:46:33 +0200 Michal Hocko <mhocko@kernel.org> wrote:
> >
> > > > Maybe we should introduce the Fixes-no-stable: tag. That should get
> > > > their attention.
> > >
> > > No please, Fixes shouldn't be really tight to any stable tree rules. It
> > > is a very useful indication of which commit has introduced bug/problem
> > > or whatever that the patch follows up to. We in Suse are using this tag
> > > to evaluate potential fixes as the stable is not reliable. We could live
> > > with Fixes-no-stable or whatever other name but does it really makes
> > > sense to complicate the existing state when stable maintainers are doing
> > > whatever they want anyway? Does a tag like that force AI from selecting
> > > a patch? I am not really convinced.
> >
> > It should work if we ask stable trees maintainers not to backport
> > such patches.
> >
> > Sasha, please don't backport patches which are marked Fixes-no-stable:
> > and which lack a cc:stable tag.
>
> I'll add it to my filter, thank you!
I would really prefer to stick with Fixes: tag and stable only picking
up cc: stable patches. I really hate to see workarounds for sensible
workflows (marking the Fixes) just because we are trying to hide
something from stable maintainers. Seriously, if stable maintainers have
a different idea about what should be backported, it is their call. They
are the ones to deal with regressions and the backporting effort in
those cases of disagreement.
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ltp@lists.linux.it, Li Wang <liwang@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Cyril Hrubis <chrubis@suse.cz>,
xishi.qiuxishi@alibaba-inc.com
Subject: Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS
Date: Mon, 12 Aug 2019 10:45:24 +0200 [thread overview]
Message-ID: <20190812084524.GC5117@dhcp22.suse.cz> (raw)
In-Reply-To: <20190811234614.GZ17747@sasha-vm>
On Sun 11-08-19 19:46:14, Sasha Levin wrote:
> On Fri, Aug 09, 2019 at 03:17:18PM -0700, Andrew Morton wrote:
> > On Fri, 9 Aug 2019 08:46:33 +0200 Michal Hocko <mhocko@kernel.org> wrote:
> >
> > > > Maybe we should introduce the Fixes-no-stable: tag. That should get
> > > > their attention.
> > >
> > > No please, Fixes shouldn't be really tight to any stable tree rules. It
> > > is a very useful indication of which commit has introduced bug/problem
> > > or whatever that the patch follows up to. We in Suse are using this tag
> > > to evaluate potential fixes as the stable is not reliable. We could live
> > > with Fixes-no-stable or whatever other name but does it really makes
> > > sense to complicate the existing state when stable maintainers are doing
> > > whatever they want anyway? Does a tag like that force AI from selecting
> > > a patch? I am not really convinced.
> >
> > It should work if we ask stable trees maintainers not to backport
> > such patches.
> >
> > Sasha, please don't backport patches which are marked Fixes-no-stable:
> > and which lack a cc:stable tag.
>
> I'll add it to my filter, thank you!
I would really prefer to stick with Fixes: tag and stable only picking
up cc: stable patches. I really hate to see workarounds for sensible
workflows (marking the Fixes) just because we are trying to hide
something from stable maintainers. Seriously, if stable maintainers have
a different idea about what should be backported, it is their call. They
are the ones to deal with regressions and the backporting effort in
those cases of disagreement.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-08-12 8:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 0:05 [LTP] [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS Mike Kravetz
2019-08-08 0:05 ` Mike Kravetz
2019-08-08 3:36 ` [LTP] " Naoya Horiguchi
2019-08-08 3:36 ` Naoya Horiguchi
2019-08-08 7:46 ` [LTP] " Michal Hocko
2019-08-08 7:46 ` Michal Hocko
2019-08-08 7:47 ` [LTP] " Michal Hocko
2019-08-08 7:47 ` Michal Hocko
2019-08-08 16:55 ` [LTP] " Mike Kravetz
2019-08-08 16:55 ` Mike Kravetz
2019-08-08 18:53 ` [LTP] " Michal Hocko
2019-08-08 18:53 ` Michal Hocko
2019-08-08 23:39 ` [LTP] " Andrew Morton
2019-08-08 23:39 ` Andrew Morton
2019-08-09 6:46 ` [LTP] " Michal Hocko
2019-08-09 6:46 ` Michal Hocko
2019-08-09 22:17 ` [LTP] " Andrew Morton
2019-08-09 22:17 ` Andrew Morton
2019-08-11 23:46 ` [LTP] " Sasha Levin
2019-08-11 23:46 ` Sasha Levin
2019-08-12 8:45 ` Michal Hocko [this message]
2019-08-12 8:45 ` Michal Hocko
2019-08-12 13:14 ` [LTP] " Vlastimil Babka
2019-08-12 13:14 ` Vlastimil Babka
2019-08-12 13:22 ` [LTP] " Michal Hocko
2019-08-12 13:22 ` Michal Hocko
2019-08-12 15:33 ` [LTP] " Sasha Levin
2019-08-12 15:33 ` Sasha Levin
2019-08-12 16:09 ` [LTP] " Qian Cai
2019-08-12 16:09 ` Qian Cai
2019-08-12 21:37 ` [LTP] " Andrew Morton
2019-08-12 21:37 ` Andrew Morton
2019-08-13 8:43 ` [LTP] " Michal Hocko
2019-08-13 8:43 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2019-08-08 2:24 [LTP] " =?unknown-8bit?b?6KOY56iA55+z56iA55+z?=
2019-08-08 2:44 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812084524.GC5117@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.