From: Lee Jones <lee.jones@linaro.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Frank Wunderlich <frank-w@public-files.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Allison Randal <allison@lohutok.net>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org,
Eddie Huang <eddie.huang@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Richard Fontana <rfontana@redhat.com>,
Rob Herring <robh+dt@kernel.o>
Subject: Re: [PATCH v3 03/10] rtc: mt6397: move some common definitions into rtc.h
Date: Mon, 12 Aug 2019 11:18:38 +0100 [thread overview]
Message-ID: <20190812101838.GG26727@dell> (raw)
In-Reply-To: <20190805134842.GG3600@piout.net>
On Mon, 05 Aug 2019, Alexandre Belloni wrote:
> On 29/07/2019 19:41:47+0200, Frank Wunderlich wrote:
> > From: Josef Friedl <josef.friedl@speed.at>
> >
> > move code to separate header-file to reuse definitions later
> > in poweroff-driver (drivers/power/reset/mt6323-poweroff.c)
> >
> > changes since v2: add missing commit-message
>
> The changelog should be after the --- marker.
> >
> > Suggested-by: Frank Wunderlich <frank-w@public-files.de>
> > Signed-off-by: Josef Friedl <josef.friedl@speed.at>
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > drivers/rtc/rtc-mt6397.c | 55 +-------------------------
> > include/linux/mfd/mt6397/rtc.h | 71 ++++++++++++++++++++++++++++++++++
I think include/linux/rtc/mt6397.h would be better?
Certainly from a maintainance PoV, it would be better reviewed and
looked after by an RTC expert.
> > 2 files changed, 72 insertions(+), 54 deletions(-)
> > create mode 100644 include/linux/mfd/mt6397/rtc.h
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Frank Wunderlich <frank-w@public-files.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Allison Randal <allison@lohutok.net>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org,
Eddie Huang <eddie.huang@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Richard Fontana <rfontana@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Sean Wang <sean.wang@mediatek.com>,
Sebastian Reichel <sre@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Tianping . Fang" <tianping.fang@mediatek.com>,
Josef Friedl <josef.friedl@speed.at>
Subject: Re: [PATCH v3 03/10] rtc: mt6397: move some common definitions into rtc.h
Date: Mon, 12 Aug 2019 11:18:38 +0100 [thread overview]
Message-ID: <20190812101838.GG26727@dell> (raw)
In-Reply-To: <20190805134842.GG3600@piout.net>
On Mon, 05 Aug 2019, Alexandre Belloni wrote:
> On 29/07/2019 19:41:47+0200, Frank Wunderlich wrote:
> > From: Josef Friedl <josef.friedl@speed.at>
> >
> > move code to separate header-file to reuse definitions later
> > in poweroff-driver (drivers/power/reset/mt6323-poweroff.c)
> >
> > changes since v2: add missing commit-message
>
> The changelog should be after the --- marker.
> >
> > Suggested-by: Frank Wunderlich <frank-w@public-files.de>
> > Signed-off-by: Josef Friedl <josef.friedl@speed.at>
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > drivers/rtc/rtc-mt6397.c | 55 +-------------------------
> > include/linux/mfd/mt6397/rtc.h | 71 ++++++++++++++++++++++++++++++++++
I think include/linux/rtc/mt6397.h would be better?
Certainly from a maintainance PoV, it would be better reviewed and
looked after by an RTC expert.
> > 2 files changed, 72 insertions(+), 54 deletions(-)
> > create mode 100644 include/linux/mfd/mt6397/rtc.h
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
Richard Fontana <rfontana@redhat.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-rtc@vger.kernel.org,
Frank Wunderlich <frank-w@public-files.de>,
Allison Randal <allison@lohutok.net>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Sean Wang <sean.wang@mediatek.com>,
"Tianping . Fang" <tianping.fang@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
Alessandro Zummo <a.zummo@towertech.it>,
Josef Friedl <josef.friedl@speed.at>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Reichel <sre@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 03/10] rtc: mt6397: move some common definitions into rtc.h
Date: Mon, 12 Aug 2019 11:18:38 +0100 [thread overview]
Message-ID: <20190812101838.GG26727@dell> (raw)
In-Reply-To: <20190805134842.GG3600@piout.net>
On Mon, 05 Aug 2019, Alexandre Belloni wrote:
> On 29/07/2019 19:41:47+0200, Frank Wunderlich wrote:
> > From: Josef Friedl <josef.friedl@speed.at>
> >
> > move code to separate header-file to reuse definitions later
> > in poweroff-driver (drivers/power/reset/mt6323-poweroff.c)
> >
> > changes since v2: add missing commit-message
>
> The changelog should be after the --- marker.
> >
> > Suggested-by: Frank Wunderlich <frank-w@public-files.de>
> > Signed-off-by: Josef Friedl <josef.friedl@speed.at>
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > drivers/rtc/rtc-mt6397.c | 55 +-------------------------
> > include/linux/mfd/mt6397/rtc.h | 71 ++++++++++++++++++++++++++++++++++
I think include/linux/rtc/mt6397.h would be better?
Certainly from a maintainance PoV, it would be better reviewed and
looked after by an RTC expert.
> > 2 files changed, 72 insertions(+), 54 deletions(-)
> > create mode 100644 include/linux/mfd/mt6397/rtc.h
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-12 10:18 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 17:41 [PATCH v3 00/10] implement poweroff for mt6323 / bpi-r2 Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` [PATCH v3 01/10] dt-bindings: add powercontroller Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-08-12 10:20 ` Lee Jones
2019-08-12 10:20 ` Lee Jones
2019-08-12 10:20 ` Lee Jones
2019-08-12 11:10 ` Aw: " Frank Wunderlich
2019-08-12 11:10 ` Frank Wunderlich
2019-08-12 11:10 ` Frank Wunderlich
2019-08-12 11:25 ` Lee Jones
2019-08-12 11:25 ` Lee Jones
2019-08-12 11:25 ` Lee Jones
2019-08-12 11:37 ` Aw: " Frank Wunderlich
2019-08-12 11:37 ` Frank Wunderlich
2019-08-12 11:37 ` Frank Wunderlich
2019-08-12 11:51 ` Lee Jones
2019-08-12 11:51 ` Lee Jones
2019-08-12 11:51 ` Lee Jones
2019-07-29 17:41 ` [PATCH v3 02/10] dt-bindings: add missing mt6397 rtc Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-08-05 13:47 ` Alexandre Belloni
2019-08-05 13:47 ` Alexandre Belloni
2019-08-05 13:47 ` Alexandre Belloni
2019-07-29 17:41 ` [PATCH v3 03/10] rtc: mt6397: move some common definitions into rtc.h Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-08-05 13:48 ` Alexandre Belloni
2019-08-05 13:48 ` Alexandre Belloni
2019-08-05 13:48 ` Alexandre Belloni
2019-08-12 10:18 ` Lee Jones [this message]
2019-08-12 10:18 ` Lee Jones
2019-08-12 10:18 ` Lee Jones
2019-07-29 17:41 ` [PATCH v3 04/10] rtc: mt6397: improvements of rtc driver Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` [PATCH v3 05/10] rtc: mt6397: add compatible for mt6323 Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-08-05 13:50 ` Alexandre Belloni
2019-08-05 13:50 ` Alexandre Belloni
2019-08-05 13:50 ` Alexandre Belloni
2019-07-29 17:41 ` [PATCH v3 06/10] mfd: mt6323: some improvements of mt6397-core Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-08-12 10:22 ` Lee Jones
2019-08-12 10:22 ` Lee Jones
2019-08-12 10:22 ` Lee Jones
2019-08-12 11:25 ` Aw: " Frank Wunderlich
2019-08-12 11:25 ` Frank Wunderlich
2019-08-12 11:25 ` Frank Wunderlich
2019-08-12 11:27 ` Lee Jones
2019-08-12 11:27 ` Lee Jones
2019-08-12 11:27 ` Lee Jones
2019-07-29 17:41 ` [PATCH v3 07/10] mfd: mt6323: add mt6323 rtc+pwrc Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-08-12 10:22 ` Lee Jones
2019-08-12 10:22 ` Lee Jones
2019-08-12 10:22 ` Lee Jones
2019-07-29 17:41 ` [PATCH v3 08/10] power: reset: add driver for mt6323 poweroff Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 17:41 ` Frank Wunderlich
2019-07-29 18:16 ` [PATCH v3 00/10] implement poweroff for mt6323 / bpi-r2 Frank Wunderlich
2019-07-29 18:16 ` Frank Wunderlich
2019-07-29 18:16 ` Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812101838.GG26727@dell \
--to=lee.jones@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=allison@lohutok.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.o \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.