From: Pavel Machek <pavel@ucw.cz>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
Frank Steiner <fsteiner-mail1@bio.ifi.lmu.de>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH v3 4/6] block: introduce LED block device activity trigger
Date: Tue, 13 Aug 2019 12:33:13 +0200 [thread overview]
Message-ID: <20190813103313.GC26337@amd> (raw)
In-Reply-To: <1565459703-30513-5-git-send-email-akinobu.mita@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
On Sun 2019-08-11 02:55:01, Akinobu Mita wrote:
> This allows LEDs to be controlled by block device activity.
>
> We already have ledtrig-disk (LED disk activity trigger), but the lower
> level disk drivers need to utilize ledtrig_disk_activity() to make the
> LED blink.
>
> The LED block device trigger doesn't require the lower level drivers to
> have any instrumentation. The activity is collected by polling the disk
> stats.
>
> Example:
>
> echo block-nvme0n1 > /sys/class/leds/diy/trigger
Some machines have lots of block devices... Should we perhaps have
"echo block > trigger; echo nvme0n1 > device"?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
Subject: [PATCH v3 4/6] block: introduce LED block device activity trigger
Date: Tue, 13 Aug 2019 12:33:13 +0200 [thread overview]
Message-ID: <20190813103313.GC26337@amd> (raw)
In-Reply-To: <1565459703-30513-5-git-send-email-akinobu.mita@gmail.com>
On Sun 2019-08-11 02:55:01, Akinobu Mita wrote:
> This allows LEDs to be controlled by block device activity.
>
> We already have ledtrig-disk (LED disk activity trigger), but the lower
> level disk drivers need to utilize ledtrig_disk_activity() to make the
> LED blink.
>
> The LED block device trigger doesn't require the lower level drivers to
> have any instrumentation. The activity is collected by polling the disk
> stats.
>
> Example:
>
> echo block-nvme0n1 > /sys/class/leds/diy/trigger
Some machines have lots of block devices... Should we perhaps have
"echo block > trigger; echo nvme0n1 > device"?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20190813/a5a8ffbc/attachment.sig>
next prev parent reply other threads:[~2019-08-13 10:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 17:54 [PATCH v3 0/6] introduce LED block device activity trigger Akinobu Mita
2019-08-10 17:54 ` Akinobu Mita
2019-08-10 17:54 ` [PATCH v3 1/6] block: umem: rename LED_* macros to MEMCTRL_LED_* Akinobu Mita
2019-08-10 17:54 ` Akinobu Mita
2019-08-13 10:11 ` Pavel Machek
2019-08-13 10:11 ` Pavel Machek
2019-08-10 17:54 ` [PATCH v3 2/6] scsi: mvsas: rename LED_* enums to SGPIO_LED_* Akinobu Mita
2019-08-10 17:54 ` Akinobu Mita
2019-08-13 10:12 ` Pavel Machek
2019-08-13 10:12 ` Pavel Machek
2019-08-10 17:55 ` [PATCH v3 3/6] scsi: nsp32: rename LED_* macros to EXT_PORT_LED_* Akinobu Mita
2019-08-10 17:55 ` Akinobu Mita
2019-08-10 17:55 ` [PATCH v3 4/6] block: introduce LED block device activity trigger Akinobu Mita
2019-08-10 17:55 ` Akinobu Mita
2019-08-12 19:28 ` Jacek Anaszewski
2019-08-12 19:28 ` Jacek Anaszewski
2019-08-13 10:33 ` Pavel Machek [this message]
2019-08-13 10:33 ` Pavel Machek
2019-08-13 15:40 ` Akinobu Mita
2019-08-13 15:40 ` Akinobu Mita
2019-08-10 17:55 ` [PATCH v3 5/6] ledtrig-blk: add interface to stop and restart polling disk stats Akinobu Mita
2019-08-10 17:55 ` Akinobu Mita
2019-08-12 19:31 ` Jacek Anaszewski
2019-08-12 19:31 ` Jacek Anaszewski
2019-08-13 15:37 ` Akinobu Mita
2019-08-13 15:37 ` Akinobu Mita
2019-08-10 17:55 ` [PATCH v3 6/6] scsi: sd: stop polling disk stats by ledtrig-blk during runtime suspend Akinobu Mita
2019-08-10 17:55 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813103313.GC26337@amd \
--to=pavel@ucw.cz \
--cc=akinobu.mita@gmail.com \
--cc=axboe@kernel.dk \
--cc=dmurphy@ti.com \
--cc=fsteiner-mail1@bio.ifi.lmu.de \
--cc=hare@suse.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.