From: Dariusz Marcinkiewicz <darekm@google.com>
To: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
hverkuil-cisco@xs4all.nl
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Douglas Anderson <dianders@chromium.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Sam Ravnborg <sam@ravnborg.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
Allison Randal <allison@lohutok.net>,
Kees Cook <keescook@chromium.org>,
Jonas Karlman <jonas@kwiboo.se>,
Jani Nikula <jani.nikula@intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
"open list:DRM DRIVERS FOR NVIDIA TEGRA"
<linux-tegra@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
open list <linux-kernel@vger.kernel.org>,
Colin Ian King <colin.king@can>
Subject: [PATCH v6 0/8] drm: cec: convert DRM drivers to the new notifier API
Date: Tue, 13 Aug 2019 13:02:32 +0200 [thread overview]
Message-ID: <20190813110300.83025-1-darekm@google.com> (raw)
This series updates DRM drivers to use new CEC notifier API.
Only first two patches were tested on the actual hardware.
Changes since v5:
Fixed a warning about a missing comment for a new member of
drm_dp_aux_cec struct. Sending to a wider audience, including
maintainers of respective drivers.
Changes since v4:
Addressing review comments.
Changes since v3:
Updated adapter flags in dw-hdmi-cec.
Changes since v2:
Include all DRM patches from "cec: improve notifier support,
add connector info connector info" series.
Changes since v1:
Those patches delay creation of notifiers until respective
connectors are constructed. It seems that those patches, for a
couple of drivers, by adding the delay, introduce a race between
notifiers' creation and the IRQs handling threads - at least I
don't see anything obvious in there that would explicitly forbid
such races to occur. v2 adds a write barrier to make sure IRQ
threads see the notifier once it is created (replacing the
WRITE_ONCE I put in v1). The best thing to do here, I believe,
would be not to have any synchronization and make sure that an IRQ
only gets enabled after the notifier is created.
Dariusz Marcinkiewicz (8):
drm/i915/intel_hdmi: use cec_notifier_conn_(un)register
dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
tda9950: use cec_notifier_cec_adap_(un)register
drm: tda998x: use cec_notifier_conn_(un)register
drm: sti: use cec_notifier_conn_(un)register
drm: tegra: use cec_notifier_conn_(un)register
drm: dw-hdmi: use cec_notifier_conn_(un)register
drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 ++++---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 36 +++++++++++--------
drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++++-------
drivers/gpu/drm/i2c/tda9950.c | 12 +++----
drivers/gpu/drm/i2c/tda998x_drv.c | 33 +++++++++++------
drivers/gpu/drm/i915/display/intel_hdmi.c | 13 ++++---
drivers/gpu/drm/sti/sti_hdmi.c | 19 ++++++----
drivers/gpu/drm/tegra/output.c | 28 +++++++++++----
8 files changed, 117 insertions(+), 68 deletions(-)
--
2.23.0.rc1.153.gdeed80330f-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dariusz Marcinkiewicz <darekm@google.com>
To: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
hverkuil-cisco@xs4all.nl
Cc: "Dariusz Marcinkiewicz" <darekm@google.com>,
"Allison Randal" <allison@lohutok.net>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Colin Ian King" <colin.king@canonical.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Douglas Anderson" <dianders@chromium.org>,
"Enrico Weigelt" <info@metux.net>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Jani Nikula" <jani.nikula@intel.com>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Kees Cook" <keescook@chromium.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
"open list:DRM DRIVERS FOR NVIDIA TEGRA"
<linux-tegra@vger.kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Ramalingam C" <ramalingam.c@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Shashank Sharma" <shashank.sharma@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v6 0/8] drm: cec: convert DRM drivers to the new notifier API
Date: Tue, 13 Aug 2019 13:02:32 +0200 [thread overview]
Message-ID: <20190813110300.83025-1-darekm@google.com> (raw)
This series updates DRM drivers to use new CEC notifier API.
Only first two patches were tested on the actual hardware.
Changes since v5:
Fixed a warning about a missing comment for a new member of
drm_dp_aux_cec struct. Sending to a wider audience, including
maintainers of respective drivers.
Changes since v4:
Addressing review comments.
Changes since v3:
Updated adapter flags in dw-hdmi-cec.
Changes since v2:
Include all DRM patches from "cec: improve notifier support,
add connector info connector info" series.
Changes since v1:
Those patches delay creation of notifiers until respective
connectors are constructed. It seems that those patches, for a
couple of drivers, by adding the delay, introduce a race between
notifiers' creation and the IRQs handling threads - at least I
don't see anything obvious in there that would explicitly forbid
such races to occur. v2 adds a write barrier to make sure IRQ
threads see the notifier once it is created (replacing the
WRITE_ONCE I put in v1). The best thing to do here, I believe,
would be not to have any synchronization and make sure that an IRQ
only gets enabled after the notifier is created.
Dariusz Marcinkiewicz (8):
drm/i915/intel_hdmi: use cec_notifier_conn_(un)register
dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
tda9950: use cec_notifier_cec_adap_(un)register
drm: tda998x: use cec_notifier_conn_(un)register
drm: sti: use cec_notifier_conn_(un)register
drm: tegra: use cec_notifier_conn_(un)register
drm: dw-hdmi: use cec_notifier_conn_(un)register
drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 ++++---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 36 +++++++++++--------
drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++++-------
drivers/gpu/drm/i2c/tda9950.c | 12 +++----
drivers/gpu/drm/i2c/tda998x_drv.c | 33 +++++++++++------
drivers/gpu/drm/i915/display/intel_hdmi.c | 13 ++++---
drivers/gpu/drm/sti/sti_hdmi.c | 19 ++++++----
drivers/gpu/drm/tegra/output.c | 28 +++++++++++----
8 files changed, 117 insertions(+), 68 deletions(-)
--
2.23.0.rc1.153.gdeed80330f-goog
next reply other threads:[~2019-08-13 11:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 11:02 Dariusz Marcinkiewicz [this message]
2019-08-13 11:02 ` [PATCH v6 0/8] drm: cec: convert DRM drivers to the new notifier API Dariusz Marcinkiewicz
2019-08-13 11:02 ` [PATCH v6 1/8] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-08-13 11:02 ` Dariusz Marcinkiewicz
2019-08-13 11:02 ` [PATCH v6 2/8] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register Dariusz Marcinkiewicz
2019-08-13 11:02 ` Dariusz Marcinkiewicz
2019-08-13 11:02 ` [PATCH v6 3/8] tda9950: " Dariusz Marcinkiewicz
2019-08-13 11:02 ` Dariusz Marcinkiewicz
2019-08-13 11:32 ` Russell King - ARM Linux admin
2019-08-13 11:32 ` Russell King - ARM Linux admin
2019-08-13 11:44 ` Hans Verkuil
2019-08-13 11:02 ` [PATCH v6 4/8] drm: tda998x: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-08-13 11:02 ` Dariusz Marcinkiewicz
2019-08-13 11:20 ` Russell King - ARM Linux admin
2019-08-14 10:52 ` Dariusz Marcinkiewicz
2019-08-13 11:02 ` [PATCH v6 5/8] drm: sti: " Dariusz Marcinkiewicz
2019-08-13 11:02 ` Dariusz Marcinkiewicz
2019-08-13 11:02 ` [PATCH v6 6/8] drm: tegra: " Dariusz Marcinkiewicz
2019-08-13 11:02 ` Dariusz Marcinkiewicz
2019-08-13 11:02 ` [PATCH v6 7/8] drm: dw-hdmi: " Dariusz Marcinkiewicz
2019-08-13 11:02 ` Dariusz Marcinkiewicz
2019-08-13 11:37 ` Hans Verkuil
2019-08-14 10:49 ` Dariusz Marcinkiewicz
2019-08-13 11:02 ` [PATCH v6 8/8] drm: exynos: exynos_hdmi: " Dariusz Marcinkiewicz
2019-08-13 11:02 ` Dariusz Marcinkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813110300.83025-1-darekm@google.com \
--to=darekm@google.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=allison@lohutok.net \
--cc=colin.king@can \
--cc=daniel.vetter@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=hverkuil@xs4all.nl \
--cc=jani.nikula@intel.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rodrigo.vivi@intel.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.