From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] sctp: fix the transport error_count check
Date: Tue, 13 Aug 2019 16:27:34 +0000 [thread overview]
Message-ID: <20190813162734.GA2870@localhost.localdomain> (raw)
In-Reply-To: <55b2fe3e5123958ccd7983e0892bc604aa717132.1565614152.git.lucien.xin@gmail.com>
On Mon, Aug 12, 2019 at 08:49:12PM +0800, Xin Long wrote:
> As the annotation says in sctp_do_8_2_transport_strike():
>
> "If the transport error count is greater than the pf_retrans
> threshold, and less than pathmaxrtx ..."
>
> It should be transport->error_count checked with pathmaxrxt,
> instead of asoc->pf_retrans.
>
> Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Dave, please consider this one for stable. Thanks.
> ---
> net/sctp/sm_sideeffect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index a554d6d..1cf5bb5 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -546,7 +546,7 @@ static void sctp_do_8_2_transport_strike(struct sctp_cmd_seq *commands,
> */
> if (net->sctp.pf_enable &&
> (transport->state = SCTP_ACTIVE) &&
> - (asoc->pf_retrans < transport->pathmaxrxt) &&
> + (transport->error_count < transport->pathmaxrxt) &&
> (transport->error_count > asoc->pf_retrans)) {
>
> sctp_assoc_control_transport(asoc, transport,
> --
> 2.1.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] sctp: fix the transport error_count check
Date: Tue, 13 Aug 2019 13:27:34 -0300 [thread overview]
Message-ID: <20190813162734.GA2870@localhost.localdomain> (raw)
In-Reply-To: <55b2fe3e5123958ccd7983e0892bc604aa717132.1565614152.git.lucien.xin@gmail.com>
On Mon, Aug 12, 2019 at 08:49:12PM +0800, Xin Long wrote:
> As the annotation says in sctp_do_8_2_transport_strike():
>
> "If the transport error count is greater than the pf_retrans
> threshold, and less than pathmaxrtx ..."
>
> It should be transport->error_count checked with pathmaxrxt,
> instead of asoc->pf_retrans.
>
> Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Dave, please consider this one for stable. Thanks.
> ---
> net/sctp/sm_sideeffect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index a554d6d..1cf5bb5 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -546,7 +546,7 @@ static void sctp_do_8_2_transport_strike(struct sctp_cmd_seq *commands,
> */
> if (net->sctp.pf_enable &&
> (transport->state == SCTP_ACTIVE) &&
> - (asoc->pf_retrans < transport->pathmaxrxt) &&
> + (transport->error_count < transport->pathmaxrxt) &&
> (transport->error_count > asoc->pf_retrans)) {
>
> sctp_assoc_control_transport(asoc, transport,
> --
> 2.1.0
>
next prev parent reply other threads:[~2019-08-13 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 12:49 [PATCH net] sctp: fix the transport error_count check Xin Long
2019-08-12 12:49 ` Xin Long
2019-08-13 16:27 ` Marcelo Ricardo Leitner [this message]
2019-08-13 16:27 ` Marcelo Ricardo Leitner
2019-08-14 2:22 ` Jakub Kicinski
2019-08-14 2:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813162734.GA2870@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.