From: Stephen Boyd <sboyd@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Wen He <wen.he_1@nxp.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: leoyang.li@nxp.com, liviu.dudau@arm.com, Wen He <wen.he_1@nxp.com>
Subject: Re: [v1 2/3] dt/bindings: clk: Add DT bindings for LS1028A Display output interface
Date: Tue, 13 Aug 2019 11:30:05 -0700 [thread overview]
Message-ID: <20190813183005.EC13020665@mail.kernel.org> (raw)
In-Reply-To: <20190812100216.34459-1-wen.he_1@nxp.com>
Quoting Wen He (2019-08-12 03:02:16)
> diff --git a/Documentation/devicetree/bindings/clock/fsl,plldig.txt b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> new file mode 100644
> index 000000000000..29c5a6117809
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> @@ -0,0 +1,26 @@
> +NXP QorIQ Layerscape LS1028A Display output interface Clock
> +===========================================================
Can you convert this to YAML?
> +
> +Required properties:
> + - compatible: shall contain "fsl,ls1028a-plldig"
> + - reg: Physical base address and size of the block registers
> + - #clock-cells: shall contain 1.
As I said in the previous patch, this should probably be 0. Also, please
order this before the driver in the patch series and thread your
messages please. If you use git-send-email this is done for you pretty
easily.
> + - clocks: a phandle + clock-specifier pairs, here should be
> + specify the reference clock of the system
> +
> +
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: leoyang.li@nxp.com, liviu.dudau@arm.com, Wen He <wen.he_1@nxp.com>
Subject: Re: [v1 2/3] dt/bindings: clk: Add DT bindings for LS1028A Display output interface
Date: Tue, 13 Aug 2019 11:30:05 -0700 [thread overview]
Message-ID: <20190813183005.EC13020665@mail.kernel.org> (raw)
In-Reply-To: <20190812100216.34459-1-wen.he_1@nxp.com>
Quoting Wen He (2019-08-12 03:02:16)
> diff --git a/Documentation/devicetree/bindings/clock/fsl,plldig.txt b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> new file mode 100644
> index 000000000000..29c5a6117809
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,plldig.txt
> @@ -0,0 +1,26 @@
> +NXP QorIQ Layerscape LS1028A Display output interface Clock
> +===========================================================
Can you convert this to YAML?
> +
> +Required properties:
> + - compatible: shall contain "fsl,ls1028a-plldig"
> + - reg: Physical base address and size of the block registers
> + - #clock-cells: shall contain 1.
As I said in the previous patch, this should probably be 0. Also, please
order this before the driver in the patch series and thread your
messages please. If you use git-send-email this is done for you pretty
easily.
> + - clocks: a phandle + clock-specifier pairs, here should be
> + specify the reference clock of the system
> +
> +
next prev parent reply other threads:[~2019-08-13 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 10:02 [v1 2/3] dt/bindings: clk: Add DT bindings for LS1028A Display output interface Wen He
2019-08-13 18:30 ` Stephen Boyd [this message]
2019-08-13 18:30 ` Stephen Boyd
2019-08-14 9:49 ` [EXT] " Wen He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813183005.EC13020665@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.