From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: host: ohci-pxa27x: Fix and & vs | typo
Date: Wed, 14 Aug 2019 14:04:14 +0000 [thread overview]
Message-ID: <20190814140414.GU1974@kadam> (raw)
In-Reply-To: <20180223123300.GA1062@mwanda>
I was looking at this code again today and I'm still convinced this
patch is correct. Should I resend?
regards,
dan carpenter
On Fri, Feb 23, 2018 at 03:33:00PM +0300, Dan Carpenter wrote:
> The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
> a no-op because of the & vs | typo. This bug predates git and it was
> only discovered using static analysis so it must not affect too many
> people in real life.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
>
> diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
> index 3e2474959735..7679fb583e41 100644
> --- a/drivers/usb/host/ohci-pxa27x.c
> +++ b/drivers/usb/host/ohci-pxa27x.c
> @@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode)
> uhcrhda |= RH_A_NPS;
> break;
> case PMM_GLOBAL_MODE:
> - uhcrhda &= ~(RH_A_NPS & RH_A_PSM);
> + uhcrhda &= ~(RH_A_NPS | RH_A_PSM);
> break;
> case PMM_PERPORT_MODE:
> uhcrhda &= ~(RH_A_NPS);
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: host: ohci-pxa27x: Fix and & vs | typo
Date: Wed, 14 Aug 2019 17:04:14 +0300 [thread overview]
Message-ID: <20190814140414.GU1974@kadam> (raw)
In-Reply-To: <20180223123300.GA1062@mwanda>
I was looking at this code again today and I'm still convinced this
patch is correct. Should I resend?
regards,
dan carpenter
On Fri, Feb 23, 2018 at 03:33:00PM +0300, Dan Carpenter wrote:
> The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
> a no-op because of the & vs | typo. This bug predates git and it was
> only discovered using static analysis so it must not affect too many
> people in real life.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
>
> diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
> index 3e2474959735..7679fb583e41 100644
> --- a/drivers/usb/host/ohci-pxa27x.c
> +++ b/drivers/usb/host/ohci-pxa27x.c
> @@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode)
> uhcrhda |= RH_A_NPS;
> break;
> case PMM_GLOBAL_MODE:
> - uhcrhda &= ~(RH_A_NPS & RH_A_PSM);
> + uhcrhda &= ~(RH_A_NPS | RH_A_PSM);
> break;
> case PMM_PERPORT_MODE:
> uhcrhda &= ~(RH_A_NPS);
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2019-08-14 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 12:33 [PATCH] usb: host: ohci-pxa27x: Fix and & vs | typo Dan Carpenter
2018-02-23 12:33 ` Dan Carpenter
2019-08-14 14:04 ` Dan Carpenter [this message]
2019-08-14 14:04 ` [PATCH] " Dan Carpenter
2019-08-15 12:36 ` Greg Kroah-Hartman
2019-08-15 12:36 ` Greg Kroah-Hartman
2019-08-14 14:46 ` Alan Stern
2019-08-14 14:46 ` Alan Stern
2019-08-17 6:55 ` Dan Carpenter
2019-08-17 6:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814140414.GU1974@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.