From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH] nvme: Add quirk for LiteON CL1 devices running FW 22301111
Date: Wed, 14 Aug 2019 13:31:32 -0600 [thread overview]
Message-ID: <20190814193132.GD3256@localhost.localdomain> (raw)
In-Reply-To: <1565798749-15672-1-git-send-email-mario.limonciello@dell.com>
On Wed, Aug 14, 2019@09:05:49AM -0700, Mario Limonciello wrote:
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 8f3fbe5..47c7754 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2251,6 +2251,29 @@ static const struct nvme_core_quirk_entry core_quirks[] = {
> .vid = 0x1179,
> .mn = "THNSF5256GPUK TOSHIBA",
> .quirks = NVME_QUIRK_NO_APST,
> + },
> + /*
> + * This LiteON CL1 firmware version has a race condition associated with
> + * actions related to suspend to idle. LiteON has resolved the problem
> + * in future firmware.
> + */
> + {
> + .vid = 0x14a4,
> + .mn = "CL1-3D128-Q11 NVMe LITEON 128GB",
> + .fr = "22301111",
> + .quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> + },
> + {
> + .vid = 0x14a4,
> + .mn = "CL1-3D256-Q11 NVMe LITEON 256GB",
> + .fr = "22301111",
> + .quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> + },
> + {
> + .vid = 0x14a4,
> + .mn = "CL1-3D512-Q11 NVMe LITEON 512GB",
> + .fr = "22301111",
> + .quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> }
> };
Are there models from this vendor with this same 'fr' that don't need
this quirk? If not, you can leave .mn blank and just use a single entry.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ryan Hong <Ryan.Hong@Dell.com>, Crag Wang <Crag.Wang@dell.com>,
"sjg@google.com" <sjg@google.com>,
Charles Hyde <charles.hyde@dellteam.com>,
Jared Dominguez <jared.dominguez@dell.com>
Subject: Re: [PATCH] nvme: Add quirk for LiteON CL1 devices running FW 22301111
Date: Wed, 14 Aug 2019 13:31:32 -0600 [thread overview]
Message-ID: <20190814193132.GD3256@localhost.localdomain> (raw)
In-Reply-To: <1565798749-15672-1-git-send-email-mario.limonciello@dell.com>
On Wed, Aug 14, 2019 at 09:05:49AM -0700, Mario Limonciello wrote:
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 8f3fbe5..47c7754 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2251,6 +2251,29 @@ static const struct nvme_core_quirk_entry core_quirks[] = {
> .vid = 0x1179,
> .mn = "THNSF5256GPUK TOSHIBA",
> .quirks = NVME_QUIRK_NO_APST,
> + },
> + /*
> + * This LiteON CL1 firmware version has a race condition associated with
> + * actions related to suspend to idle. LiteON has resolved the problem
> + * in future firmware.
> + */
> + {
> + .vid = 0x14a4,
> + .mn = "CL1-3D128-Q11 NVMe LITEON 128GB",
> + .fr = "22301111",
> + .quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> + },
> + {
> + .vid = 0x14a4,
> + .mn = "CL1-3D256-Q11 NVMe LITEON 256GB",
> + .fr = "22301111",
> + .quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> + },
> + {
> + .vid = 0x14a4,
> + .mn = "CL1-3D512-Q11 NVMe LITEON 512GB",
> + .fr = "22301111",
> + .quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> }
> };
Are there models from this vendor with this same 'fr' that don't need
this quirk? If not, you can leave .mn blank and just use a single entry.
next prev parent reply other threads:[~2019-08-14 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 16:05 [PATCH] nvme: Add quirk for LiteON CL1 devices running FW 22301111 Mario Limonciello
2019-08-14 16:05 ` Mario Limonciello
2019-08-14 19:22 ` Sagi Grimberg
2019-08-14 19:22 ` Sagi Grimberg
2019-08-14 19:31 ` Keith Busch [this message]
2019-08-14 19:31 ` Keith Busch
2019-08-14 19:51 ` Mario.Limonciello
2019-08-14 19:51 ` Mario.Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814193132.GD3256@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.