All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111
Date: Wed, 14 Aug 2019 14:08:47 -0600	[thread overview]
Message-ID: <20190814200847.GA3504@localhost.localdomain> (raw)
In-Reply-To: <1565813304-16710-1-git-send-email-mario.limonciello@dell.com>

On Wed, Aug 14, 2019@01:08:24PM -0700, Mario Limonciello wrote:
> One of the components in LiteON CL1 device has limitations that
> can be encountered based upon boundary race conditions using the
> nvme bus specific suspend to idle flow.
> 
> When this situation occurs the drive doesn't resume properly from
> suspend-to-idle.
> 
> LiteON has confirmed this problem and fixed in the next firmware
> version.  As this firmware is already in the field, avoid running
> nvme specific suspend to idle flow.
> 
> Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend")
> Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html
> Signed-off-by: Mario Limonciello <mario.limonciello at dell.com>
> Signed-off-by: Charles Hyde <charles.hyde at dellteam.com>

Looks fine to me.

Reviewed-by: Keith Busch <kbusch at kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ryan Hong <Ryan.Hong@Dell.com>, Crag Wang <Crag.Wang@dell.com>,
	"sjg@google.com" <sjg@google.com>,
	Charles Hyde <charles.hyde@dellteam.com>,
	Jared Dominguez <jared.dominguez@dell.com>
Subject: Re: [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111
Date: Wed, 14 Aug 2019 14:08:47 -0600	[thread overview]
Message-ID: <20190814200847.GA3504@localhost.localdomain> (raw)
In-Reply-To: <1565813304-16710-1-git-send-email-mario.limonciello@dell.com>

On Wed, Aug 14, 2019 at 01:08:24PM -0700, Mario Limonciello wrote:
> One of the components in LiteON CL1 device has limitations that
> can be encountered based upon boundary race conditions using the
> nvme bus specific suspend to idle flow.
> 
> When this situation occurs the drive doesn't resume properly from
> suspend-to-idle.
> 
> LiteON has confirmed this problem and fixed in the next firmware
> version.  As this firmware is already in the field, avoid running
> nvme specific suspend to idle flow.
> 
> Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend")
> Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> Signed-off-by: Charles Hyde <charles.hyde@dellteam.com>

Looks fine to me.

Reviewed-by: Keith Busch <kbusch@kernel.org>

  reply	other threads:[~2019-08-14 20:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 20:08 [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111 Mario Limonciello
2019-08-14 20:08 ` Mario Limonciello
2019-08-14 20:08 ` Keith Busch [this message]
2019-08-14 20:08   ` Keith Busch
2019-08-14 20:14 ` Sagi Grimberg
2019-08-14 20:14   ` Sagi Grimberg
2019-08-14 20:19   ` Keith Busch
2019-08-14 20:19     ` Keith Busch
2019-08-15 17:19     ` Sagi Grimberg
2019-08-15 17:19       ` Sagi Grimberg
2019-08-16 19:43       ` Mario.Limonciello
2019-08-16 19:43         ` Mario.Limonciello
2019-08-16 20:01         ` Keith Busch
2019-08-16 20:01           ` Keith Busch
2019-08-14 20:19   ` Mario.Limonciello
2019-08-14 20:19     ` Mario.Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814200847.GA3504@localhost.localdomain \
    --to=kbusch@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.