All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Glisse <jglisse@redhat.com>
To: "Yang, Philip" <Philip.Yang@amd.com>
Cc: "alex.deucher@amd.com" <alex.deucher@amd.com>,
	"Kuehling, Felix" <Felix.Kuehling@amd.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"jgg@mellanox.com" <jgg@mellanox.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] mm/hmm: hmm_range_fault handle pages swapped out
Date: Thu, 15 Aug 2019 17:02:53 -0400	[thread overview]
Message-ID: <20190815210253.GD25517@redhat.com> (raw)
In-Reply-To: <20190815205227.7949-1-Philip.Yang@amd.com>

On Thu, Aug 15, 2019 at 08:52:56PM +0000, Yang, Philip wrote:
> hmm_range_fault may return NULL pages because some of pfns are equal to
> HMM_PFN_NONE. This happens randomly under memory pressure. The reason is
> for swapped out page pte path, hmm_vma_handle_pte doesn't update fault
> variable from cpu_flags, so it failed to call hmm_vam_do_fault to swap
> the page in.
> 
> The fix is to call hmm_pte_need_fault to update fault variable.
> 
> Change-Id: I2e8611485563d11d938881c18b7935fa1e7c91ee
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>

Reviewed-by: Jérôme Glisse <jglisse@redhat.com>

> ---
>  mm/hmm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 9f22562e2c43..7ca4fb39d3d8 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -544,6 +544,9 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr,
>  		swp_entry_t entry = pte_to_swp_entry(pte);
>  
>  		if (!non_swap_entry(entry)) {
> +			cpu_flags = pte_to_hmm_pfn_flags(range, pte);
> +			hmm_pte_need_fault(hmm_vma_walk, orig_pfn, cpu_flags,
> +					   &fault, &write_fault);
>  			if (fault || write_fault)
>  				goto fault;
>  			return 0;
> -- 
> 2.17.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: "Yang, Philip" <Philip.Yang@amd.com>
Cc: "alex.deucher@amd.com" <alex.deucher@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"Kuehling, Felix" <Felix.Kuehling@amd.com>,
	"jgg@mellanox.com" <jgg@mellanox.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] mm/hmm: hmm_range_fault handle pages swapped out
Date: Thu, 15 Aug 2019 17:02:53 -0400	[thread overview]
Message-ID: <20190815210253.GD25517@redhat.com> (raw)
In-Reply-To: <20190815205227.7949-1-Philip.Yang@amd.com>

On Thu, Aug 15, 2019 at 08:52:56PM +0000, Yang, Philip wrote:
> hmm_range_fault may return NULL pages because some of pfns are equal to
> HMM_PFN_NONE. This happens randomly under memory pressure. The reason is
> for swapped out page pte path, hmm_vma_handle_pte doesn't update fault
> variable from cpu_flags, so it failed to call hmm_vam_do_fault to swap
> the page in.
> 
> The fix is to call hmm_pte_need_fault to update fault variable.
> 
> Change-Id: I2e8611485563d11d938881c18b7935fa1e7c91ee
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>

Reviewed-by: Jérôme Glisse <jglisse@redhat.com>

> ---
>  mm/hmm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 9f22562e2c43..7ca4fb39d3d8 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -544,6 +544,9 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr,
>  		swp_entry_t entry = pte_to_swp_entry(pte);
>  
>  		if (!non_swap_entry(entry)) {
> +			cpu_flags = pte_to_hmm_pfn_flags(range, pte);
> +			hmm_pte_need_fault(hmm_vma_walk, orig_pfn, cpu_flags,
> +					   &fault, &write_fault);
>  			if (fault || write_fault)
>  				goto fault;
>  			return 0;
> -- 
> 2.17.1
> 


  reply	other threads:[~2019-08-15 21:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 20:52 [PATCH] mm/hmm: hmm_range_fault handle pages swapped out Yang, Philip
2019-08-15 20:52 ` Yang, Philip
2019-08-15 21:02 ` Jerome Glisse [this message]
2019-08-15 21:02   ` Jerome Glisse
     [not found] ` <20190815205227.7949-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org>
2019-08-16  0:54   ` Jason Gunthorpe
2019-08-16  0:54     ` Jason Gunthorpe
2019-08-16 16:02     ` Yang, Philip
2019-08-16 16:02       ` Yang, Philip
2019-08-23 13:39   ` Jason Gunthorpe
2019-08-23 13:39     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190815210253.GD25517@redhat.com \
    --to=jglisse@redhat.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Philip.Yang@amd.com \
    --cc=alex.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jgg@mellanox.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.