All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915/buddy: tidy up i915_buddy_fini
@ 2019-08-16 10:53 Matthew Auld
  2019-08-16 10:53 ` [PATCH 2/2] drm/i915/buddy: use kmemleak_update_trace Matthew Auld
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Matthew Auld @ 2019-08-16 10:53 UTC (permalink / raw)
  To: intel-gfx

If we are leaking nodes don't hide it. Also stop trying to be
"defensive" and instead embrace Kasan et al.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_buddy.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_buddy.c b/drivers/gpu/drm/i915/i915_buddy.c
index b679ab6fd889..5995247fdf76 100644
--- a/drivers/gpu/drm/i915/i915_buddy.c
+++ b/drivers/gpu/drm/i915/i915_buddy.c
@@ -171,15 +171,10 @@ int i915_buddy_init(struct i915_buddy_mm *mm, u64 size, u64 chunk_size)
 
 void i915_buddy_fini(struct i915_buddy_mm *mm)
 {
-	int err = 0;
 	int i;
 
 	for (i = 0; i < mm->n_roots; ++i) {
-		if (!i915_buddy_block_is_free(mm->roots[i])) {
-			err = -EBUSY;
-			continue;
-		}
-
+		GEM_WARN_ON(!i915_buddy_block_is_free(mm->roots[i]));
 		i915_block_free(mm->roots[i]);
 	}
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-08-17  6:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-16 10:53 [PATCH 1/2] drm/i915/buddy: tidy up i915_buddy_fini Matthew Auld
2019-08-16 10:53 ` [PATCH 2/2] drm/i915/buddy: use kmemleak_update_trace Matthew Auld
2019-08-16 10:57   ` Chris Wilson
2019-08-16 10:56 ` [PATCH 1/2] drm/i915/buddy: tidy up i915_buddy_fini Chris Wilson
2019-08-16 14:43 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-08-17  6:09 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.