All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 1/2] clk: aspeed: Move structures to header
Date: Fri, 16 Aug 2019 10:01:49 -0700	[thread overview]
Message-ID: <20190816170150.4E6772077C@mail.kernel.org> (raw)
In-Reply-To: <20190816155806.22869-2-joel@jms.id.au>

Quoting Joel Stanley (2019-08-16 08:58:05)
> diff --git a/drivers/clk/clk-aspeed.h b/drivers/clk/clk-aspeed.h
> new file mode 100644
> index 000000000000..92d384367c25
> --- /dev/null
> +++ b/drivers/clk/clk-aspeed.h
> @@ -0,0 +1,74 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Structures used by ASPEED clock drivers
> + *
> + * Copyright 2019 IBM Corp.
> + */

Please include reset.h (or whatever defines reset_controller_dev),
clk-provider.h, kernel.h (for container_of and types), and forward
declare struct regmap and clk_div_table here.

> +
> +/**
> + * struct aspeed_gate_data - Aspeed gated clocks

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Joel Stanley <joel@jms.id.au>,
	Michael Turquette <mturquette@baylibre.com>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>,
	Andrew Jeffery <andrew@aj.id.au>,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 1/2] clk: aspeed: Move structures to header
Date: Fri, 16 Aug 2019 10:01:49 -0700	[thread overview]
Message-ID: <20190816170150.4E6772077C@mail.kernel.org> (raw)
In-Reply-To: <20190816155806.22869-2-joel@jms.id.au>

Quoting Joel Stanley (2019-08-16 08:58:05)
> diff --git a/drivers/clk/clk-aspeed.h b/drivers/clk/clk-aspeed.h
> new file mode 100644
> index 000000000000..92d384367c25
> --- /dev/null
> +++ b/drivers/clk/clk-aspeed.h
> @@ -0,0 +1,74 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Structures used by ASPEED clock drivers
> + *
> + * Copyright 2019 IBM Corp.
> + */

Please include reset.h (or whatever defines reset_controller_dev),
clk-provider.h, kernel.h (for container_of and types), and forward
declare struct regmap and clk_div_table here.

> +
> +/**
> + * struct aspeed_gate_data - Aspeed gated clocks

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Joel Stanley <joel@jms.id.au>,
	Michael Turquette <mturquette@baylibre.com>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>,
	linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] clk: aspeed: Move structures to header
Date: Fri, 16 Aug 2019 10:01:49 -0700	[thread overview]
Message-ID: <20190816170150.4E6772077C@mail.kernel.org> (raw)
In-Reply-To: <20190816155806.22869-2-joel@jms.id.au>

Quoting Joel Stanley (2019-08-16 08:58:05)
> diff --git a/drivers/clk/clk-aspeed.h b/drivers/clk/clk-aspeed.h
> new file mode 100644
> index 000000000000..92d384367c25
> --- /dev/null
> +++ b/drivers/clk/clk-aspeed.h
> @@ -0,0 +1,74 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Structures used by ASPEED clock drivers
> + *
> + * Copyright 2019 IBM Corp.
> + */

Please include reset.h (or whatever defines reset_controller_dev),
clk-provider.h, kernel.h (for container_of and types), and forward
declare struct regmap and clk_div_table here.

> +
> +/**
> + * struct aspeed_gate_data - Aspeed gated clocks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-08-16 17:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 15:58 [PATCH 0/2] clk: Add driver for ast2600 Joel Stanley
2019-08-16 15:58 ` Joel Stanley
2019-08-16 15:58 ` Joel Stanley
2019-08-16 15:58 ` [PATCH 1/2] clk: aspeed: Move structures to header Joel Stanley
2019-08-16 15:58   ` Joel Stanley
2019-08-16 15:58   ` Joel Stanley
2019-08-16 17:01   ` Stephen Boyd [this message]
2019-08-16 17:01     ` Stephen Boyd
2019-08-16 17:01     ` Stephen Boyd
2019-08-16 15:58 ` [PATCH 2/2] clk: Add support for AST2600 SoC Joel Stanley
2019-08-16 15:58   ` Joel Stanley
2019-08-16 15:58   ` Joel Stanley
2019-08-16 17:14   ` Stephen Boyd
2019-08-16 17:14     ` Stephen Boyd
2019-08-16 17:14     ` Stephen Boyd
2019-08-19  2:03     ` Joel Stanley
2019-08-19  2:03       ` Joel Stanley
2019-08-19  2:03       ` Joel Stanley
2019-09-06 22:03       ` Stephen Boyd
2019-09-06 22:03         ` Stephen Boyd
2019-09-06 22:03         ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190816170150.4E6772077C@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.