From: Pavel Machek <pavel@ucw.cz>
To: Oleh Kravchenko <oleg@kaa.org.ua>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 2/2] leds: add LED driver for EL15203000 board
Date: Sat, 17 Aug 2019 17:02:46 +0200 [thread overview]
Message-ID: <20190817150246.GB18381@amd> (raw)
In-Reply-To: <e72f3669-1537-54ee-5ddd-ea77f9d13f07@kaa.org.ua>
[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]
Hi!
> >>>> All pattern is predefined, you can't change them at all.
> >>>> I just tried to describe real things what happened in LED board.
> >>>> It's ticks every 800 milliseconds for Pipe LEDs.
> >>>
> >>> It makes me wonder how you figured out the values? If you have
> >>> a documentation for this controller, could you share how the pattern
> >>> settings are documented?
> >>
> >> I saw the code of firmware.
> >> Not sure if I can find any documentation for it right now.
> >
> > Have you tried to alter the values? Or check what happens when
> > the duplication is removed?
>
> What do you mean alter? It doesn't make any sense.
> Board is accepts only brightness level from '0' to '5'.
> I'm really confused :-)
For the record, what you did seems ok to me.
> >> Ok, I will reduce it.
> >
> > Please hold on for a while. I will have some more remarks to the driver,
> > just collecting missing info for now to gain more complete view on this
> > device.
>
> Here is the full story:
>
> EL15203000 LEDs board (aka RED LEDs board, because it has only RED LEDs).
> It's provide access to 3 LEDs:
>
> - First LED (Screen) is a light tube around big 21" screen
> It's have 3 brightness levels:
> * OFF
> * ON
> * Breathing mode (8 seconds full cycle)
> - Second LED (Vending area) is highlight coffee cap
> * OFF
> * ON
Again, this is ok.
> - Third LED (Pipe) is actually virtual, because consists from 5 LEDs
> * OFF for all 5 LEDs
> * ON for all 5 LEDs
> * Cascade
> * Inverses cascade
> * Bounce
> * Inverses bounce
But having one virtual LED that is really five LEDs scares me a tiny
bit. But I guess its ok for your case...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-08-17 15:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 20:32 [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 Oleh Kravchenko
2019-08-08 20:32 ` [PATCH v4 2/2] leds: add LED driver for EL15203000 board Oleh Kravchenko
2019-08-13 20:28 ` Jacek Anaszewski
2019-08-13 20:28 ` Jacek Anaszewski
2019-08-13 20:37 ` Oleh Kravchenko
2019-08-14 18:18 ` Jacek Anaszewski
2019-08-14 19:46 ` Oleh Kravchenko
2019-08-14 19:57 ` Jacek Anaszewski
2019-08-14 20:16 ` Oleh Kravchenko
2019-08-14 20:53 ` Jacek Anaszewski
2019-08-14 20:58 ` Oleh Kravchenko
2019-08-17 15:02 ` Pavel Machek [this message]
2019-08-20 7:46 ` Oleh Kravchenko
2019-08-18 13:47 ` Jacek Anaszewski
2019-08-27 20:43 ` Oleh Kravchenko
2019-08-27 20:56 ` Jacek Anaszewski
2019-08-27 21:11 ` Oleh Kravchenko
2019-08-27 21:18 ` Jacek Anaszewski
2019-08-27 21:26 ` Oleh Kravchenko
2019-08-13 20:31 ` [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 Dan Murphy
2019-08-13 20:31 ` Dan Murphy
2019-08-14 19:54 ` Jacek Anaszewski
2019-08-18 13:41 ` Jacek Anaszewski
2019-08-20 7:50 ` Oleh Kravchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190817150246.GB18381@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=oleg@kaa.org.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.