From: Vicente Bergas <vicencb@gmail.com>
To: Felipe Balbi <balbi@kernel.org>, Robin Murphy <robin.murphy@arm.com>
Cc: Matthias Brugger <mbrugger@suse.com>,
Heiko Stuebner <heiko@sntech.de>,
MarcZyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-usb@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
Vicente Bergas <vicencb@gmail.com>,
linux-rockchip@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: dwc3: Add shutdown to platform_driver
Date: Sat, 17 Aug 2019 19:41:40 +0200 [thread overview]
Message-ID: <20190817174140.6394-1-vicencb@gmail.com> (raw)
In-Reply-To: <4d18d4f7-a00e-bd60-6361-51054eba3bca@arm.com>
Otherwise the device keeps writing to memory after kexec and disturbs
the next kernel.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
drivers/usb/dwc3/dwc3-of-simple.c | 6 ++++++
1 file changed, 6 insertions(+)
Hi Felipe, Robin,
this version calls 'remove' from 'shutdown' instead of just asserting
a reset because it looks like a cleaner way to stop the device.
Calling remove from shutdown in core.c instead of dwc3-of-simple.c does not
fix the issue either.
It has been tested on the sapphire board, a RK3399 platform.
Regards,
Vicenç.
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index bdac3e7d7b18..d5fd45c64901 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -133,6 +133,11 @@ static int dwc3_of_simple_remove(struct platform_device *pdev)
return 0;
}
+static void dwc3_of_simple_shutdown(struct platform_device *pdev)
+{
+ dwc3_of_simple_remove(pdev);
+}
+
static int __maybe_unused dwc3_of_simple_runtime_suspend(struct device *dev)
{
struct dwc3_of_simple *simple = dev_get_drvdata(dev);
@@ -190,6 +195,7 @@ MODULE_DEVICE_TABLE(of, of_dwc3_simple_match);
static struct platform_driver dwc3_of_simple_driver = {
.probe = dwc3_of_simple_probe,
.remove = dwc3_of_simple_remove,
+ .shutdown = dwc3_of_simple_shutdown,
.driver = {
.name = "dwc3-of-simple",
.of_match_table = of_dwc3_simple_match,
--
2.22.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Vicente Bergas <vicencb@gmail.com>
To: Felipe Balbi <balbi@kernel.org>, Robin Murphy <robin.murphy@arm.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Will Deacon <will.deacon@arm.com>,
MarcZyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Matthias Brugger <mbrugger@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Vicente Bergas <vicencb@gmail.com>
Subject: [PATCH] usb: dwc3: Add shutdown to platform_driver
Date: Sat, 17 Aug 2019 19:41:40 +0200 [thread overview]
Message-ID: <20190817174140.6394-1-vicencb@gmail.com> (raw)
In-Reply-To: <4d18d4f7-a00e-bd60-6361-51054eba3bca@arm.com>
Otherwise the device keeps writing to memory after kexec and disturbs
the next kernel.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
drivers/usb/dwc3/dwc3-of-simple.c | 6 ++++++
1 file changed, 6 insertions(+)
Hi Felipe, Robin,
this version calls 'remove' from 'shutdown' instead of just asserting
a reset because it looks like a cleaner way to stop the device.
Calling remove from shutdown in core.c instead of dwc3-of-simple.c does not
fix the issue either.
It has been tested on the sapphire board, a RK3399 platform.
Regards,
Vicenç.
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index bdac3e7d7b18..d5fd45c64901 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -133,6 +133,11 @@ static int dwc3_of_simple_remove(struct platform_device *pdev)
return 0;
}
+static void dwc3_of_simple_shutdown(struct platform_device *pdev)
+{
+ dwc3_of_simple_remove(pdev);
+}
+
static int __maybe_unused dwc3_of_simple_runtime_suspend(struct device *dev)
{
struct dwc3_of_simple *simple = dev_get_drvdata(dev);
@@ -190,6 +195,7 @@ MODULE_DEVICE_TABLE(of, of_dwc3_simple_match);
static struct platform_driver dwc3_of_simple_driver = {
.probe = dwc3_of_simple_probe,
.remove = dwc3_of_simple_remove,
+ .shutdown = dwc3_of_simple_shutdown,
.driver = {
.name = "dwc3-of-simple",
.of_match_table = of_dwc3_simple_match,
--
2.22.1
next prev parent reply other threads:[~2019-08-17 17:41 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 14:31 kexec on rk3399 Vicente Bergas
2019-07-22 14:31 ` Vicente Bergas
2019-07-22 14:46 ` Will Deacon
2019-07-22 14:46 ` Will Deacon
2019-07-22 16:08 ` Vicente Bergas
[not found] ` <ebcb52be-2063-4e2c-9a09-fdcacb94f855-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-07-22 14:47 ` Matthias Brugger
2019-07-22 14:47 ` Matthias Brugger
2019-07-22 16:56 ` Vicente Bergas
2019-07-22 14:54 ` Marc Zyngier
2019-07-22 14:54 ` Marc Zyngier
2019-07-22 17:05 ` Vicente Bergas
2019-07-22 17:35 ` Robin Murphy
[not found] ` <8f71e7de-7eaf-58c7-6471-c8eb01e656ce-5wv7dgnIgG8@public.gmane.org>
2019-07-22 18:53 ` Vicente Bergas
2019-07-22 18:53 ` Vicente Bergas
2019-07-23 13:32 ` Robin Murphy
2019-07-23 13:32 ` Robin Murphy
2019-08-14 12:53 ` Vicente Bergas
2019-08-14 12:53 ` Vicente Bergas
2019-08-14 12:53 ` Vicente Bergas
[not found] ` <c6993a1e-6fc2-44ab-b59e-152142e2ff4d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14 13:06 ` Felipe Balbi
2019-08-14 13:06 ` Felipe Balbi
2019-08-14 13:06 ` Felipe Balbi
2019-08-14 13:15 ` Vicente Bergas
2019-08-14 13:15 ` Vicente Bergas
2019-08-14 13:15 ` Vicente Bergas
2019-08-15 6:00 ` Felipe Balbi
2019-08-15 6:00 ` Felipe Balbi
2019-08-14 13:12 ` Robin Murphy
2019-08-14 13:12 ` Robin Murphy
2019-08-15 1:15 ` Vicente Bergas
2019-08-15 1:15 ` Vicente Bergas
2019-08-15 1:15 ` Vicente Bergas
2019-08-15 6:06 ` Felipe Balbi
2019-08-15 6:06 ` Felipe Balbi
2019-08-15 11:09 ` Robin Murphy
2019-08-15 11:09 ` Robin Murphy
2019-08-17 17:41 ` Vicente Bergas [this message]
2019-08-17 17:41 ` [PATCH] usb: dwc3: Add shutdown to platform_driver Vicente Bergas
2019-08-27 11:45 ` Vicente Bergas
2019-08-27 11:45 ` Vicente Bergas
[not found] ` <8d48017a-64c5-4b25-8d85-113ffcf502c9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-27 11:53 ` Felipe Balbi
2019-08-27 11:53 ` Felipe Balbi
2019-08-27 11:53 ` Felipe Balbi
2019-08-27 12:16 ` Vicente Bergas
2019-08-27 12:16 ` Vicente Bergas
2019-09-09 15:07 ` Vicente Bergas
2019-09-09 15:07 ` Vicente Bergas
[not found] ` <0edb55d4-3bad-47ac-9d29-8d994d182e67-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-10-23 6:31 ` Felipe Balbi
2019-10-23 6:31 ` Felipe Balbi
2019-10-23 6:31 ` Felipe Balbi
2019-10-24 12:15 ` Vicente Bergas
2019-10-24 12:15 ` Vicente Bergas
2019-10-24 12:15 ` Vicente Bergas
2019-10-25 10:25 ` Felipe Balbi
2019-10-25 10:25 ` Felipe Balbi
2019-10-25 10:25 ` Felipe Balbi
2019-10-25 10:42 ` Vicente Bergas
2019-10-25 10:42 ` Vicente Bergas
2019-10-25 10:42 ` Vicente Bergas
2019-09-19 11:36 ` Vicente Bergas
2019-09-19 11:36 ` Vicente Bergas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190817174140.6394-1-vicencb@gmail.com \
--to=vicencb@gmail.com \
--cc=balbi@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mbrugger@suse.com \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.