[U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

[U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

[Andy Shevchenko]

Using ACPI predefined macros, such as Zero or One, will reduce a binary size
of resulting ACPI tables.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
 arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/arch-tangier/acpi/platform.asl b/arch/x86/include/asm/arch-tangier/acpi/platform.asl
index bd1aa9ce88..39bcaf3801 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/platform.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/platform.asl
@@ -18,7 +18,7 @@ Method(_PTS, 1)
 /* The _WAK method is called on system wakeup */
 Method(_WAK, 1)
 {
-    Return (Package() {0, 0})
+    Return (Package() { Zero, Zero })
 }
 
 Scope (\_SB)
diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
index bb2a59dbc2..aedc62cc0c 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
@@ -10,8 +10,8 @@ Device (PCI0)
     Name (_HID, EISAID("PNP0A08"))    /* PCIe */
     Name (_CID, EISAID("PNP0A03"))    /* PCI */
 
-    Name (_ADR, 0)
-    Name (_BBN, 0)
+    Name (_ADR, Zero)
+    Name (_BBN, Zero)
 
     Name (MCRS, ResourceTemplate()
     {
-- 
2.23.0.rc1

[U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

[Bin Meng]

On Mon, Aug 19, 2019 at 5:17 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Using ACPI predefined macros, such as Zero or One, will reduce a binary size
> of resulting ACPI tables.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
>  arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

[Bin Meng]

Hi Andy,

On Mon, Aug 19, 2019 at 5:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Mon, Aug 19, 2019 at 5:17 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Using ACPI predefined macros, such as Zero or One, will reduce a binary size
> > of resulting ACPI tables.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
> >  arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Somehow this patch does not apply cleanly on top of latest
u-boot/master, so I manually fixed the issue and

applied to u-boot-x86, thanks!

Regards,
Bin

[U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

[Andy Shevchenko]

On Mon, Aug 26, 2019 at 09:49:49AM +0800, Bin Meng wrote:
> Hi Andy,
> 
> On Mon, Aug 19, 2019 at 5:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > On Mon, Aug 19, 2019 at 5:17 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > Using ACPI predefined macros, such as Zero or One, will reduce a binary size
> > > of resulting ACPI tables.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
> > >  arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
> > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > >
> >
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> 
> Somehow this patch does not apply cleanly on top of latest
> u-boot/master, so I manually fixed the issue and
> 
> applied to u-boot-x86, thanks!

Thanks!

P.S. It seems the subject missed. If you can rebase, it might be worth to fix.

-- 
With Best Regards,
Andy Shevchenko

[U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

[Bin Meng]

Hi Andy,

On Mon, Aug 26, 2019 at 5:43 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Aug 26, 2019 at 09:49:49AM +0800, Bin Meng wrote:
> > Hi Andy,
> >
> > On Mon, Aug 19, 2019 at 5:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > On Mon, Aug 19, 2019 at 5:17 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > >
> > > > Using ACPI predefined macros, such as Zero or One, will reduce a binary size
> > > > of resulting ACPI tables.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > ---
> > > >  arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
> > > >  arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
> > > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > >
> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > Somehow this patch does not apply cleanly on top of latest
> > u-boot/master, so I manually fixed the issue and
> >
> > applied to u-boot-x86, thanks!
>
> Thanks!
>
> P.S. It seems the subject missed. If you can rebase, it might be worth to fix.
>

Ah, yes! Thanks for catching this. I added the commit subject.

Regards,
Bin