From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, tony@atomide.com, sre@kernel.org,
nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode
Date: Mon, 19 Aug 2019 12:48:04 +0200 [thread overview]
Message-ID: <20190819104804.GD21072@amd> (raw)
In-Reply-To: <20190813181154.6614-1-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
On Tue 2019-08-13 13:11:51, Dan Murphy wrote:
> Fix the brightness control for I2C mode. Instead of
> changing the full scale current register update the ALS target
> register for the appropriate banks.
>
> In addition clean up some code errors and random misspellings found
> during coding.
>
> Tested on Droid4 as well as LM3532 EVM connected to a BeagleBoneBlack
>
> Fixes: e37a7f8d77e1 ("leds: lm3532: Introduce the lm3532 LED driver")
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
I may prefer register renames to come separately, but ...
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-08-19 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 18:11 [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode Dan Murphy
2019-08-13 18:11 ` [PATCH v2 2/4] leds: lm3532: Fixes for the driver for stability Dan Murphy
2019-08-19 10:48 ` Pavel Machek
2019-08-13 18:11 ` [PATCH v2 3/4] dt: lm3532: Add property for full scale current Dan Murphy
2019-08-19 10:49 ` Pavel Machek
2019-08-13 18:11 ` [PATCH v2 4/4] leds: lm3532: Add full scale current configuration Dan Murphy
2019-08-19 10:55 ` Pavel Machek
2019-08-20 15:51 ` Dan Murphy
2019-08-20 16:29 ` Pavel Machek
2019-08-20 17:48 ` Dan Murphy
2019-08-19 10:48 ` Pavel Machek [this message]
2019-08-20 15:52 ` [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819104804.GD21072@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.