All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, tony@atomide.com, sre@kernel.org,
	nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration
Date: Tue, 20 Aug 2019 18:29:34 +0200	[thread overview]
Message-ID: <20190820162934.GA5701@amd> (raw)
In-Reply-To: <1f4efd9f-8234-161a-2c05-c5bae2720207@ti.com>

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Hi!

> >No need to move ctrl_brt_pointer... to keep order consistent with docs.
> 
> OK I will reset the patches and get rid of that change.  I think this got
> moved when I applied the v1 patch.
> 
> 
> >>+		fs_current_val = led->full_scale_current - LM3532_FS_CURR_MIN /
> >>+				 LM3532_FS_CURR_STEP;
> >The computation is wrong ... needs () AFAICT.
> 
> Hmm. Doesn't order of operations take precedence?
> 
> I will add the () unless checkpatch cribs about them

I may be misunderstanding. What do you expect the computation to be? /
has higher priority than -, right? Can you test it provides expected
results?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2019-08-20 16:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 18:11 [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode Dan Murphy
2019-08-13 18:11 ` [PATCH v2 2/4] leds: lm3532: Fixes for the driver for stability Dan Murphy
2019-08-19 10:48   ` Pavel Machek
2019-08-13 18:11 ` [PATCH v2 3/4] dt: lm3532: Add property for full scale current Dan Murphy
2019-08-19 10:49   ` Pavel Machek
2019-08-13 18:11 ` [PATCH v2 4/4] leds: lm3532: Add full scale current configuration Dan Murphy
2019-08-19 10:55   ` Pavel Machek
2019-08-20 15:51     ` Dan Murphy
2019-08-20 16:29       ` Pavel Machek [this message]
2019-08-20 17:48         ` Dan Murphy
2019-08-19 10:48 ` [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode Pavel Machek
2019-08-20 15:52   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820162934.GA5701@amd \
    --to=pavel@ucw.cz \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=mpartap@gmx.net \
    --cc=nekit1000@gmail.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.