From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] arm64: implement KPROBES_ON_FTRACE
Date: Tue, 20 Aug 2019 02:16:28 +0000 [thread overview]
Message-ID: <20190820100522.55bc3f42@xhacker.debian> (raw)
In-Reply-To: <1566232996.v8nlwmnjqa.naveen@linux.ibm.com>
On Mon, 19 Aug 2019 22:22:12 +0530 "Naveen N. Rao" wrote:
>
>
> Jisheng Zhang wrote:
> > This patch implements KPROBES_ON_FTRACE for arm64.
> >
> > ~ # mount -t debugfs debugfs /sys/kernel/debug/
> > ~ # cd /sys/kernel/debug/
> > /sys/kernel/debug # echo 'p _do_fork' > tracing/kprobe_events
> >
> > before the patch:
> >
> > /sys/kernel/debug # cat kprobes/list
> > ffffff801009ff7c k _do_fork+0x4 [DISABLED]
>
> This looks wrong -- we should not be allowing kprobe to be registered on
Yes. I made a mistake when dumping this log. The kernel isn't as clean
as "before the patch".
> ftrace address without KPROBES_ON_FTRACE. Is _do_fork+0x4 the location
> of ftrace entry on arm64?
Indeed, w/o KPROBES_ON_FTRACE, it should be _do_fork+0x0
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Borislav Petkov <bp@alien8.de>,
Catalin Marinas <catalin.marinas@arm.com>,
"David S. Miller" <davem@davemloft.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 4/4] arm64: implement KPROBES_ON_FTRACE
Date: Tue, 20 Aug 2019 02:16:28 +0000 [thread overview]
Message-ID: <20190820100522.55bc3f42@xhacker.debian> (raw)
In-Reply-To: <1566232996.v8nlwmnjqa.naveen@linux.ibm.com>
On Mon, 19 Aug 2019 22:22:12 +0530 "Naveen N. Rao" wrote:
>
>
> Jisheng Zhang wrote:
> > This patch implements KPROBES_ON_FTRACE for arm64.
> >
> > ~ # mount -t debugfs debugfs /sys/kernel/debug/
> > ~ # cd /sys/kernel/debug/
> > /sys/kernel/debug # echo 'p _do_fork' > tracing/kprobe_events
> >
> > before the patch:
> >
> > /sys/kernel/debug # cat kprobes/list
> > ffffff801009ff7c k _do_fork+0x4 [DISABLED]
>
> This looks wrong -- we should not be allowing kprobe to be registered on
Yes. I made a mistake when dumping this log. The kernel isn't as clean
as "before the patch".
> ftrace address without KPROBES_ON_FTRACE. Is _do_fork+0x4 the location
> of ftrace entry on arm64?
Indeed, w/o KPROBES_ON_FTRACE, it should be _do_fork+0x0
Thanks
next prev parent reply other threads:[~2019-08-20 2:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 11:35 [PATCH 0/4] arm64: KPROBES_ON_FTRACE Jisheng Zhang
2019-08-19 11:35 ` Jisheng Zhang
2019-08-19 11:36 ` [PATCH 1/4] kprobes: adjust kprobe addr for KPROBES_ON_FTRACE Jisheng Zhang
2019-08-19 11:36 ` Jisheng Zhang
2019-08-19 16:43 ` Naveen N. Rao
2019-08-19 16:43 ` Naveen N. Rao
2019-08-20 1:51 ` Jisheng Zhang
2019-08-20 1:51 ` Jisheng Zhang
2019-08-20 0:01 ` Masami Hiramatsu
2019-08-20 0:01 ` Masami Hiramatsu
2019-08-20 2:05 ` Jisheng Zhang
2019-08-20 2:05 ` Jisheng Zhang
2019-08-19 11:36 ` [PATCH 2/4] kprobes/x86: use instruction_pointer and instruction_pointer_set Jisheng Zhang
2019-08-19 11:36 ` Jisheng Zhang
2019-08-20 0:09 ` Masami Hiramatsu
2019-08-20 0:09 ` Masami Hiramatsu
2019-08-19 11:37 ` [PATCH 3/4] kprobes: move kprobe_ftrace_handler() from x86 and make it weak Jisheng Zhang
2019-08-19 11:37 ` Jisheng Zhang
2019-08-20 0:07 ` Masami Hiramatsu
2019-08-20 0:07 ` Masami Hiramatsu
2019-08-20 1:56 ` Jisheng Zhang
2019-08-20 1:56 ` Jisheng Zhang
2019-08-19 11:38 ` [PATCH 4/4] arm64: implement KPROBES_ON_FTRACE Jisheng Zhang
2019-08-19 11:38 ` Jisheng Zhang
2019-08-19 16:52 ` Naveen N. Rao
2019-08-19 16:52 ` Naveen N. Rao
2019-08-20 2:16 ` Jisheng Zhang [this message]
2019-08-20 2:16 ` Jisheng Zhang
2019-08-19 12:53 ` [PATCH 0/4] arm64: KPROBES_ON_FTRACE Mark Rutland
2019-08-19 12:53 ` Mark Rutland
2019-08-19 13:10 ` Masami Hiramatsu
2019-08-19 13:10 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820100522.55bc3f42@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.