* [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-08-21 16:23 ` codekipper
0 siblings, 0 replies; 12+ messages in thread
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2019-08-21 16:23 UTC (permalink / raw)
To: mripard-DgEjT+Ai2ygdnm+yROfE0A, wens-jdAy2FN1RRM,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw, be17068-p0aYb1w59bq9tCD/VL7h6Q,
Marcus Cooper
From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
sound/soc/sunxi/sun4i-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index cbc6e59aa089..056a299c03fb 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -1109,7 +1109,7 @@ static const struct sun4i_i2s_quirks sun6i_a31_i2s_quirks = {
static const struct sun4i_i2s_quirks sun8i_a83t_i2s_quirks = {
.has_reset = true,
.reg_offset_txdata = SUN8I_I2S_FIFO_TX_REG,
- .sun4i_i2s_regmap = &sun4i_i2s_regmap_config,
+ .sun4i_i2s_regmap = &sun8i_i2s_regmap_config,
.field_clkdiv_mclk_en = REG_FIELD(SUN4I_I2S_CLK_DIV_REG, 8, 8),
.field_fmt_wss = REG_FIELD(SUN4I_I2S_FMT0_REG, 0, 2),
.field_fmt_sr = REG_FIELD(SUN4I_I2S_FMT0_REG, 4, 6),
--
2.23.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-08-21 16:23 ` codekipper
0 siblings, 0 replies; 12+ messages in thread
From: codekipper @ 2019-08-21 16:23 UTC (permalink / raw)
To: mripard, wens, linux-sunxi
Cc: linux-arm-kernel, lgirdwood, broonie, linux-kernel, alsa-devel,
be17068, Marcus Cooper
From: Marcus Cooper <codekipper@gmail.com>
Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
sound/soc/sunxi/sun4i-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index cbc6e59aa089..056a299c03fb 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -1109,7 +1109,7 @@ static const struct sun4i_i2s_quirks sun6i_a31_i2s_quirks = {
static const struct sun4i_i2s_quirks sun8i_a83t_i2s_quirks = {
.has_reset = true,
.reg_offset_txdata = SUN8I_I2S_FIFO_TX_REG,
- .sun4i_i2s_regmap = &sun4i_i2s_regmap_config,
+ .sun4i_i2s_regmap = &sun8i_i2s_regmap_config,
.field_clkdiv_mclk_en = REG_FIELD(SUN4I_I2S_CLK_DIV_REG, 8, 8),
.field_fmt_wss = REG_FIELD(SUN4I_I2S_FMT0_REG, 0, 2),
.field_fmt_sr = REG_FIELD(SUN4I_I2S_FMT0_REG, 4, 6),
--
2.23.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-08-21 16:23 ` codekipper
0 siblings, 0 replies; 12+ messages in thread
From: codekipper @ 2019-08-21 16:23 UTC (permalink / raw)
To: mripard, wens, linux-sunxi
Cc: alsa-devel, Marcus Cooper, lgirdwood, linux-kernel, be17068,
broonie, linux-arm-kernel
From: Marcus Cooper <codekipper@gmail.com>
Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
sound/soc/sunxi/sun4i-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index cbc6e59aa089..056a299c03fb 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -1109,7 +1109,7 @@ static const struct sun4i_i2s_quirks sun6i_a31_i2s_quirks = {
static const struct sun4i_i2s_quirks sun8i_a83t_i2s_quirks = {
.has_reset = true,
.reg_offset_txdata = SUN8I_I2S_FIFO_TX_REG,
- .sun4i_i2s_regmap = &sun4i_i2s_regmap_config,
+ .sun4i_i2s_regmap = &sun8i_i2s_regmap_config,
.field_clkdiv_mclk_en = REG_FIELD(SUN4I_I2S_CLK_DIV_REG, 8, 8),
.field_fmt_wss = REG_FIELD(SUN4I_I2S_FMT0_REG, 0, 2),
.field_fmt_sr = REG_FIELD(SUN4I_I2S_FMT0_REG, 4, 6),
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
2019-08-21 16:23 ` codekipper
@ 2019-08-22 6:17 ` Maxime Ripard
-1 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2019-08-22 6:17 UTC (permalink / raw)
To: codekipper
Cc: alsa-devel, linux-sunxi, linux-kernel, lgirdwood, be17068, wens,
broonie, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 397 bytes --]
Hi Markus,
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
The patch is ok, but you should have a commit log here.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-08-22 6:17 ` Maxime Ripard
0 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2019-08-22 6:17 UTC (permalink / raw)
To: codekipper
Cc: wens, linux-sunxi, linux-arm-kernel, lgirdwood, broonie,
linux-kernel, alsa-devel, be17068
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
Hi Markus,
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
The patch is ok, but you should have a commit log here.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20190821162320.28653-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-08-30 11:44 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2019-08-30 11:44 UTC (permalink / raw)
To: codekipper-Re5JQEeQqe8AvxtiuMwx3w
Cc: mripard-DgEjT+Ai2ygdnm+yROfE0A, wens-jdAy2FN1RRM,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw, be17068-p0aYb1w59bq9tCD/VL7h6Q
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
This doesn't apply against current code, please check and resend.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-08-30 11:44 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2019-08-30 11:44 UTC (permalink / raw)
To: codekipper
Cc: mripard, wens, linux-sunxi, linux-arm-kernel, lgirdwood,
linux-kernel, alsa-devel, be17068
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-08-30 11:44 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2019-08-30 11:44 UTC (permalink / raw)
To: codekipper
Cc: alsa-devel, linux-sunxi, linux-kernel, mripard, lgirdwood,
be17068, wens, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 317 bytes --]
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
This doesn't apply against current code, please check and resend.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-08-30 11:44 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2019-08-30 11:44 UTC (permalink / raw)
To: codekipper
Cc: alsa-devel, linux-sunxi, linux-kernel, mripard, lgirdwood,
be17068, wens, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 317 bytes --]
On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
This doesn't apply against current code, please check and resend.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
2019-08-30 11:44 ` [alsa-devel] " Mark Brown
(?)
@ 2019-09-02 9:18 ` Code Kipper
-1 siblings, 0 replies; 12+ messages in thread
From: Code Kipper @ 2019-09-02 9:18 UTC (permalink / raw)
To: Mark Brown
Cc: Linux-ALSA, linux-sunxi, linux-kernel, Maxime Ripard,
Liam Girdwood, Andrea Venturi (pers), Chen-Yu Tsai,
linux-arm-kernel
On Fri, 30 Aug 2019 at 13:45, Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> > ---
>
> This doesn't apply against current code, please check and resend.
This patch is no longer valid and the fix has been done through the reverts,
BR,
CK
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-09-02 9:18 ` Code Kipper
0 siblings, 0 replies; 12+ messages in thread
From: Code Kipper @ 2019-09-02 9:18 UTC (permalink / raw)
To: Mark Brown
Cc: Maxime Ripard, Chen-Yu Tsai, linux-sunxi, linux-arm-kernel,
Liam Girdwood, linux-kernel, Linux-ALSA, Andrea Venturi (pers)
On Fri, 30 Aug 2019 at 13:45, Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> > ---
>
> This doesn't apply against current code, please check and resend.
This patch is no longer valid and the fix has been done through the reverts,
BR,
CK
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t
@ 2019-09-02 9:18 ` Code Kipper
0 siblings, 0 replies; 12+ messages in thread
From: Code Kipper @ 2019-09-02 9:18 UTC (permalink / raw)
To: Mark Brown
Cc: Linux-ALSA, linux-sunxi, linux-kernel, Maxime Ripard,
Liam Girdwood, Andrea Venturi (pers), Chen-Yu Tsai,
linux-arm-kernel
On Fri, 30 Aug 2019 at 13:45, Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekipper@gmail.com wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> > ---
>
> This doesn't apply against current code, please check and resend.
This patch is no longer valid and the fix has been done through the reverts,
BR,
CK
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-09-02 9:19 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-21 16:23 [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-21 16:23 ` codekipper
2019-08-21 16:23 ` codekipper
2019-08-22 6:17 ` Maxime Ripard
2019-08-22 6:17 ` Maxime Ripard
[not found] ` <20190821162320.28653-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-30 11:44 ` Mark Brown
2019-08-30 11:44 ` Mark Brown
2019-08-30 11:44 ` Mark Brown
2019-08-30 11:44 ` [alsa-devel] " Mark Brown
2019-09-02 9:18 ` Code Kipper
2019-09-02 9:18 ` Code Kipper
2019-09-02 9:18 ` Code Kipper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.