All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: add port info to debugfs
@ 2019-08-21 14:15 Simon Ser
  2019-08-21 14:46 ` Imre Deak
  2019-08-21 16:31 ` Manasi Navare
  0 siblings, 2 replies; 7+ messages in thread
From: Simon Ser @ 2019-08-21 14:15 UTC (permalink / raw)
  To: dri-devel

This patch adds a line with the port name to connectors in
debugfs/i916_display_info. A hint is printed if the port is type-C.

Signed-off-by: Simon Ser <simon.ser@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index b39226d7f8d2..718a337c8f0a 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,
 static void intel_connector_info(struct seq_file *m,
 				 struct drm_connector *connector)
 {
+	struct drm_i915_private *i915 = to_i915(connector->dev);
 	struct intel_connector *intel_connector = to_intel_connector(connector);
 	struct intel_encoder *intel_encoder = intel_connector->encoder;
 	struct drm_display_mode *mode;
+	enum tc_port tc_port;

 	seq_printf(m, "connector %d: type %s, status: %s\n",
 		   connector->base.id, connector->name,
@@ -2578,6 +2580,13 @@ static void intel_connector_info(struct seq_file *m,
 	if (!intel_encoder)
 		return;

+	if (intel_encoder->port != PORT_NONE) {
+		tc_port = intel_port_to_tc(i915, intel_encoder->port);
+		seq_printf(m, "\tport: %c%s\n",
+			   port_name(intel_encoder->port),
+			   tc_port != PORT_TC_NONE ? " (type-C)" : "");
+	}
+
 	switch (connector->connector_type) {
 	case DRM_MODE_CONNECTOR_DisplayPort:
 	case DRM_MODE_CONNECTOR_eDP:
--
2.22.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] drm/i915: add port info to debugfs
@ 2019-08-22 11:09 Simon Ser
  2019-08-22 12:38 ` Imre Deak
  2019-08-26 13:10 ` Jani Nikula
  0 siblings, 2 replies; 7+ messages in thread
From: Simon Ser @ 2019-08-22 11:09 UTC (permalink / raw)
  To: dri-devel; +Cc: Manasi Navare

This patch adds a line with the port name to connectors in
debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is
printed too.

Signed-off-by: Simon Ser <simon.ser@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Manasi Navare <nabasi.d.navare@intel.com>
---

Thanks for your comments, Imre and Manasi. Here is v2:

- Use same port formatting as intel_tc_port_init (e.g. "C/TC#1")
- Fix typo in commit message

 drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index b39226d7f8d2..4ba508c954f8 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,
 static void intel_connector_info(struct seq_file *m,
 				 struct drm_connector *connector)
 {
+	struct drm_i915_private *i915 = to_i915(connector->dev);
 	struct intel_connector *intel_connector = to_intel_connector(connector);
 	struct intel_encoder *intel_encoder = intel_connector->encoder;
 	struct drm_display_mode *mode;
+	enum tc_port tc_port;

 	seq_printf(m, "connector %d: type %s, status: %s\n",
 		   connector->base.id, connector->name,
@@ -2578,6 +2580,14 @@ static void intel_connector_info(struct seq_file *m,
 	if (!intel_encoder)
 		return;

+	if (intel_encoder->port != PORT_NONE) {
+		seq_printf(m, "\tport: %c", port_name(intel_encoder->port));
+		tc_port = intel_port_to_tc(i915, intel_encoder->port);
+		if (tc_port != PORT_TC_NONE)
+			seq_printf(m, "/TC#%d", tc_port + 1);
+		seq_printf(m, "\n");
+	}
+
 	switch (connector->connector_type) {
 	case DRM_MODE_CONNECTOR_DisplayPort:
 	case DRM_MODE_CONNECTOR_eDP:
--
2.22.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-26 13:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-21 14:15 [PATCH] drm/i915: add port info to debugfs Simon Ser
2019-08-21 14:46 ` Imre Deak
2019-08-21 16:31 ` Manasi Navare
  -- strict thread matches above, loose matches on Subject: below --
2019-08-22 11:09 Simon Ser
2019-08-22 12:38 ` Imre Deak
2019-08-26 13:10 ` Jani Nikula
2019-08-26 13:44   ` Ser, Simon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.