From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Derek Kiernan <derek.kiernan@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks
Date: Thu, 22 Aug 2019 08:28:31 +0000 [thread overview]
Message-ID: <20190822082831.GH3964@kadam> (raw)
In-Reply-To: <58e9a151-3d92-c730-eea6-5cfde90934a4@xilinx.com>
On Thu, Aug 22, 2019 at 10:14:12AM +0200, Michal Simek wrote:
> Hi Dan,
>
> On 21. 08. 19 9:06, Dan Carpenter wrote:
> > These structs have holes in them so we end up disclosing a few bytes of
> > uninitialized stack data.
> >
> > drivers/misc/xilinx_sdfec.c:305 xsdfec_get_status() warn: check that 'status' doesn't leak information (struct has a hole after 'activity')
> > drivers/misc/xilinx_sdfec.c:449 xsdfec_get_turbo() warn: check that 'turbo_params' doesn't leak information (struct has a hole after 'scale')
>
> Who is generating these warnings? Is this any new GCC or different tool?
> I see that 3byte padding but never seen these warnings.
This is a Smatch check.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Derek Kiernan <derek.kiernan@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks
Date: Thu, 22 Aug 2019 11:28:31 +0300 [thread overview]
Message-ID: <20190822082831.GH3964@kadam> (raw)
In-Reply-To: <58e9a151-3d92-c730-eea6-5cfde90934a4@xilinx.com>
On Thu, Aug 22, 2019 at 10:14:12AM +0200, Michal Simek wrote:
> Hi Dan,
>
> On 21. 08. 19 9:06, Dan Carpenter wrote:
> > These structs have holes in them so we end up disclosing a few bytes of
> > uninitialized stack data.
> >
> > drivers/misc/xilinx_sdfec.c:305 xsdfec_get_status() warn: check that 'status' doesn't leak information (struct has a hole after 'activity')
> > drivers/misc/xilinx_sdfec.c:449 xsdfec_get_turbo() warn: check that 'turbo_params' doesn't leak information (struct has a hole after 'scale')
>
> Who is generating these warnings? Is this any new GCC or different tool?
> I see that 3byte padding but never seen these warnings.
This is a Smatch check.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks
Date: Thu, 22 Aug 2019 11:28:31 +0300 [thread overview]
Message-ID: <20190822082831.GH3964@kadam> (raw)
In-Reply-To: <58e9a151-3d92-c730-eea6-5cfde90934a4@xilinx.com>
On Thu, Aug 22, 2019 at 10:14:12AM +0200, Michal Simek wrote:
> Hi Dan,
>
> On 21. 08. 19 9:06, Dan Carpenter wrote:
> > These structs have holes in them so we end up disclosing a few bytes of
> > uninitialized stack data.
> >
> > drivers/misc/xilinx_sdfec.c:305 xsdfec_get_status() warn: check that 'status' doesn't leak information (struct has a hole after 'activity')
> > drivers/misc/xilinx_sdfec.c:449 xsdfec_get_turbo() warn: check that 'turbo_params' doesn't leak information (struct has a hole after 'scale')
>
> Who is generating these warnings? Is this any new GCC or different tool?
> I see that 3byte padding but never seen these warnings.
This is a Smatch check.
regards,
dan carpenter
next prev parent reply other threads:[~2019-08-22 8:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 7:06 [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks Dan Carpenter
2019-08-21 7:06 ` Dan Carpenter
2019-08-21 7:06 ` Dan Carpenter
2019-08-21 7:07 ` [PATCH 2/4] misc: xilinx_sdfec: Return -EFAULT if copy_from_user() fails Dan Carpenter
2019-08-21 7:07 ` Dan Carpenter
2019-08-21 7:07 ` Dan Carpenter
2019-08-22 8:16 ` Michal Simek
2019-08-22 8:16 ` Michal Simek
2019-08-22 8:16 ` Michal Simek
2019-08-22 8:31 ` [PATCH 2/4 v2] " Dan Carpenter
2019-08-22 8:31 ` Dan Carpenter
2019-08-22 8:31 ` Dan Carpenter
2019-08-22 17:47 ` [PATCH 2/4] " Dragan Cvetic
2019-08-22 17:47 ` Dragan Cvetic
2019-08-22 17:47 ` Dragan Cvetic
2019-08-21 7:09 ` [PATCH 3/4] misc: xilinx_sdfec: Prevent a divide by zero in xsdfec_reg0_write() Dan Carpenter
2019-08-21 7:09 ` Dan Carpenter
2019-08-21 7:09 ` Dan Carpenter
2019-08-22 8:18 ` Michal Simek
2019-08-22 8:18 ` Michal Simek
2019-08-22 8:18 ` Michal Simek
2019-08-23 8:23 ` Dragan Cvetic
2019-08-23 8:23 ` Dragan Cvetic
2019-08-23 8:23 ` Dragan Cvetic
2019-08-21 7:11 ` [PATCH 4/4] misc: xilinx_sdfec: Prevent integer overflow in xsdfec_table_write() Dan Carpenter
2019-08-21 7:11 ` Dan Carpenter
2019-08-21 7:11 ` Dan Carpenter
2019-08-22 8:27 ` Michal Simek
2019-08-22 8:27 ` Michal Simek
2019-08-22 8:27 ` Michal Simek
2019-08-22 17:55 ` Dragan Cvetic
2019-08-22 17:55 ` Dragan Cvetic
2019-08-22 17:55 ` Dragan Cvetic
2019-08-22 8:14 ` [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks Michal Simek
2019-08-22 8:14 ` Michal Simek
2019-08-22 8:14 ` Michal Simek
2019-08-22 8:28 ` Dan Carpenter [this message]
2019-08-22 8:28 ` Dan Carpenter
2019-08-22 8:28 ` Dan Carpenter
2019-08-22 8:49 ` Michal Simek
2019-08-22 8:49 ` Michal Simek
2019-08-22 8:49 ` Michal Simek
2019-08-22 17:47 ` Dragan Cvetic
2019-08-22 17:47 ` Dragan Cvetic
2019-08-22 17:47 ` Dragan Cvetic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822082831.GH3964@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.