Re: Re: [PATCH for-rc] siw: fix for 'is_kva' flag issue in siw_tx_hdt()

[Krishnamraju Eraparaju <krishna2@chelsio.com>]

On Wednesday, August 08/21/19, 2019 at 19:13:18 +0530, Bernard Metzler wrote:
> -----"Doug Ledford" <dledford@redhat.com> wrote: -----
> 
> >To: "Bernard Metzler" <BMT@zurich.ibm.com>, "Krishnamraju Eraparaju"
> ><krishna2@chelsio.com>
> >From: "Doug Ledford" <dledford@redhat.com>
> >Date: 08/20/2019 07:56PM
> >Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, bharat@chelsio.com,
> >nirranjan@chelsio.com
> >Subject: [EXTERNAL] Re: [PATCH for-rc] siw: fix for 'is_kva' flag
> >issue in siw_tx_hdt()
> >
> >On Mon, 2019-08-19 at 21:44 +0000, Bernard Metzler wrote:
> >> Hi Krishna,
> >> That is a good catch. I was not aware of the possibility of mixed
> >> PBL and kernel buffer addresses in one SQE.
> >> 
> >> A correct fix must also handle the un-mapping of any kmap()'d
> >> buffers. The current TX code expects all buffers be either kmap()'d
> >or
> >> all not kmap()'d. So the fix is a little more complex, if we must
> >> handle mixed SGL's during un-mapping. I think I can provide it by
> >> tomorrow. It's almost midnight ;)
> >
> >I'll wait for a proper fix.  Dropping this patch.  Thanks.
> >
> Thanks Doug!
> 
> I have a fix ready but still have to test it with iSER. 
> Unfortunately I have a hard time to test iSER with siw, since
> both iSCSI-TCP target and iSER want to bind to the same
> TCP port. While this may be considered a bug in that code,
> siw is the first RDMA provider to take notice (since using
> kernel sockets and not offloaded, hitting a TCP port
> already bound).
Not sure if this will become a serious problem when a iSCSI target
is configured to serve both iSCSI-TCP & iSER connections simultaniously.
Because, offloaded iSER CM handles all the TCP SYN packets that were
destined to iSCSI-TCP.
> 
> I sent the patch to Chelsio folks and hope for
> the best. They know the trick to make it working.
I have tested your patch, it's working fine.
> 
> Thanks
> Bernard.
>