All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Levon <levon@movementarian.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: smatch@vger.kernel.org, linux-sparse@vger.kernel.org,
	yuri.pankov@nexenta.com
Subject: Re: noreturn attribute doesn't work in smatch
Date: Thu, 22 Aug 2019 16:29:58 +0100	[thread overview]
Message-ID: <20190822152958.GA12745@movementarian.org> (raw)
In-Reply-To: <20190822150528.GL3964@kadam>

On Thu, Aug 22, 2019 at 06:05:29PM +0300, Dan Carpenter wrote:

> On Thu, Aug 22, 2019 at 02:46:03PM +0100, John Levon wrote:
> > On Thu, Aug 22, 2019 at 04:30:34PM +0300, Dan Carpenter wrote:
> > > The code to handle that is really ancient.  You need to do:
> > >     ./smatch --info test.c | tee warns.txt
> > >     grep no_return_funcs warns.txt || echo FAIL
> > >     ./smatch_scripts/gen_no_return_funcs.sh warns.txt -p=levon
> > >     mv levon.no_return_funcs smatch_data/
> > > 
> > > Then pass -p=levon to smatch on the next run.
> > 
> > OK, thanks. That doesn't match too well with the way we use smatch, but
> > this is much less of a big deal (I only needed to annotate this in a
> > couple of places).
> 
> It should be the the DB, right?  Would that work for you?

There's few enough that it's preferable to just explicitly mark the
source as noreturn too, rather than keep a separate list.

regards
john

      reply	other threads:[~2019-08-22 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15  0:53 noreturn attribute doesn't work in smatch John Levon
2019-08-15 11:12 ` John Levon
2019-08-22 13:30   ` Dan Carpenter
2019-08-22 13:46     ` John Levon
2019-08-22 15:05       ` Dan Carpenter
2019-08-22 15:29         ` John Levon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822152958.GA12745@movementarian.org \
    --to=levon@movementarian.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=smatch@vger.kernel.org \
    --cc=yuri.pankov@nexenta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.