All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "René van Dorst" <opensource@vdorst.com>
Cc: Sean Wang <sean.wang@mediatek.com>, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Frank Wunderlich <frank-w@public-files.de>,
	netdev@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	John Crispin <john@phrozen.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5
Date: Sat, 24 Aug 2019 23:29:35 +0100	[thread overview]
Message-ID: <20190824222935.GG13294@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190821144547.15113-1-opensource@vdorst.com>

On Wed, Aug 21, 2019 at 04:45:44PM +0200, René van Dorst wrote:
> 1. net: dsa: mt7530: Convert to PHYLINK API
>    This patch converts mt7530 to PHYLINK API.
> 2. dt-bindings: net: dsa: mt7530: Add support for port 5
> 3. net: dsa: mt7530: Add support for port 5
>    These 2 patches adding support for port 5 of the switch.
> 
> v1->v2:
>  * Mostly phylink improvements after review.
> rfc -> v1:
>  * Mostly phylink improvements after review.
>  * Drop phy isolation patches. Adds no value for now.
> René van Dorst (3):
>   net: dsa: mt7530: Convert to PHYLINK API
>   dt-bindings: net: dsa: mt7530: Add support for port 5
>   net: dsa: mt7530: Add support for port 5
> 
>  .../devicetree/bindings/net/dsa/mt7530.txt    | 218 ++++++++++
>  drivers/net/dsa/mt7530.c                      | 371 +++++++++++++++---
>  drivers/net/dsa/mt7530.h                      |  61 ++-
>  3 files changed, 577 insertions(+), 73 deletions(-)

Having looked through this set of patches, I don't see anything
from the phylink point of view that concerns me.  So, for the
series from the phylink perspective:

Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

Thanks.

I did notice a dev_info() in patch 3 that you may like to consider
whether they should be printed at info level or debug level.  You
may keep my ack on the patch when fixing that.

I haven't considered whether the patch passes davem's style
requirements for networking code; what I spotted did look like
the declarations were upside-down christmas tree.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "René van Dorst" <opensource@vdorst.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Frank Wunderlich <frank-w@public-files.de>,
	netdev@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
	linux-mips@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	linux-mediatek@lists.infradead.org,
	John Crispin <john@phrozen.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5
Date: Sat, 24 Aug 2019 23:29:35 +0100	[thread overview]
Message-ID: <20190824222935.GG13294@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190821144547.15113-1-opensource@vdorst.com>

On Wed, Aug 21, 2019 at 04:45:44PM +0200, René van Dorst wrote:
> 1. net: dsa: mt7530: Convert to PHYLINK API
>    This patch converts mt7530 to PHYLINK API.
> 2. dt-bindings: net: dsa: mt7530: Add support for port 5
> 3. net: dsa: mt7530: Add support for port 5
>    These 2 patches adding support for port 5 of the switch.
> 
> v1->v2:
>  * Mostly phylink improvements after review.
> rfc -> v1:
>  * Mostly phylink improvements after review.
>  * Drop phy isolation patches. Adds no value for now.
> René van Dorst (3):
>   net: dsa: mt7530: Convert to PHYLINK API
>   dt-bindings: net: dsa: mt7530: Add support for port 5
>   net: dsa: mt7530: Add support for port 5
> 
>  .../devicetree/bindings/net/dsa/mt7530.txt    | 218 ++++++++++
>  drivers/net/dsa/mt7530.c                      | 371 +++++++++++++++---
>  drivers/net/dsa/mt7530.h                      |  61 ++-
>  3 files changed, 577 insertions(+), 73 deletions(-)

Having looked through this set of patches, I don't see anything
from the phylink point of view that concerns me.  So, for the
series from the phylink perspective:

Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

Thanks.

I did notice a dev_info() in patch 3 that you may like to consider
whether they should be printed at info level or debug level.  You
may keep my ack on the patch when fixing that.

I haven't considered whether the patch passes davem's style
requirements for networking code; what I spotted did look like
the declarations were upside-down christmas tree.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-08-24 22:29 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 14:45 [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5 René van Dorst
2019-08-21 14:45 ` René van Dorst
2019-08-21 14:45 ` [PATCH net-next v2 1/3] net: dsa: mt7530: Convert to PHYLINK API René van Dorst
2019-08-21 14:45   ` René van Dorst
2019-08-21 14:45 ` [PATCH net-next v2 2/3] dt-bindings: net: dsa: mt7530: Add support for port 5 René van Dorst
2019-08-21 14:45   ` René van Dorst
2019-08-27 22:22   ` Rob Herring
2019-08-27 22:22     ` Rob Herring
2019-08-28  6:35     ` René van Dorst
2019-08-28  6:35       ` René van Dorst
2019-08-30 17:16       ` René van Dorst
2019-08-30 17:16         ` René van Dorst
2019-08-21 14:45 ` [PATCH net-next v2 3/3] " René van Dorst
2019-08-21 14:45   ` René van Dorst
2019-08-24 23:19   ` David Miller
2019-08-24 23:19     ` David Miller
2019-08-25 12:48     ` René van Dorst
2019-08-25 12:48       ` René van Dorst
2019-08-21 21:05 ` [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add " Andrew Lunn
2019-08-21 21:05   ` Andrew Lunn
2019-08-21 21:05   ` Andrew Lunn
2019-08-22 15:44 ` Aw: " Frank Wunderlich
2019-08-22 15:44   ` Frank Wunderlich
2019-08-22 15:44   ` Frank Wunderlich
2019-08-22 16:26   ` Frank Wunderlich
2019-08-22 16:26     ` Frank Wunderlich
2019-08-22 23:20 ` David Miller
2019-08-22 23:20   ` David Miller
2019-08-23  1:09   ` Andrew Lunn
2019-08-23  1:09     ` Andrew Lunn
2019-08-24 21:18     ` David Miller
2019-08-24 21:18       ` David Miller
2019-08-24 22:15       ` Andrew Lunn
2019-08-24 22:15         ` Andrew Lunn
2019-08-24 22:31         ` Russell King - ARM Linux admin
2019-08-24 22:31           ` Russell King - ARM Linux admin
2019-08-24 22:18       ` Russell King - ARM Linux admin
2019-08-24 22:18         ` Russell King - ARM Linux admin
2019-08-24 22:29 ` Russell King - ARM Linux admin [this message]
2019-08-24 22:29   ` Russell King - ARM Linux admin
2019-08-25 13:15   ` René van Dorst
2019-08-25 13:15     ` René van Dorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190824222935.GG13294@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=frank-w@public-files.de \
    --cc=john@phrozen.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=opensource@vdorst.com \
    --cc=sean.wang@mediatek.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.