All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: David Abdurachmanov <david.abdurachmanov@gmail.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Oleg Nesterov <oleg@redhat.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>, Shuah Khan <shuah@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	David Abdurachmanov <david.abdurachmanov@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>,
	Alexios Zavras <alexios.zavras@intel.com>,
	Anup Patel <Anup.Patel@wdc.com>,
	Vincent Chen <vincentc@andestech.com>,
	Alan Kao <alankao@andestech.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, me@carlosedp.com
Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER
Date: Sun, 25 Aug 2019 14:59:37 -0700	[thread overview]
Message-ID: <201908251451.73C6812E8@keescook> (raw)
In-Reply-To: <20190822205533.4877-1-david.abdurachmanov@sifive.com>

On Thu, Aug 22, 2019 at 01:55:22PM -0700, David Abdurachmanov wrote:
> This patch was extensively tested on Fedora/RISCV (applied by default on
> top of 5.2-rc7 kernel for <2 months). The patch was also tested with 5.3-rc
> on QEMU and SiFive Unleashed board.

Oops, I see the mention of QEMU here. Where's the best place to find
instructions on creating a qemu riscv image/environment?

> There is one failing kernel selftest: global.user_notification_signal

This test has been fragile (and is not arch-specific), so as long as
everything else is passing, I would call this patch ready to go. :)

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: David Abdurachmanov <david.abdurachmanov@gmail.com>
Cc: Song Liu <songliubraving@fb.com>,
	Alan Kao <alankao@andestech.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Oleg Nesterov <oleg@redhat.com>,
	linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org,
	Shuah Khan <shuah@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Yonghong Song <yhs@fb.com>,
	me@carlosedp.com, Albert Ou <aou@eecs.berkeley.edu>,
	Alexios Zavras <alexios.zavras@intel.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>,
	Will Drewry <wad@chromium.org>,
	David Abdurachmanov <david.abdurachmanov@sifive.com>,
	netdev@vger.kernel.org, Anup Patel <Anup.Patel@wdc.com>,
	linux-kernel@vger.kernel.org,
	Andy Lutomirski <luto@amacapital.net>,
	Vincent Chen <vincentc@andestech.com>,
	bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>
Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER
Date: Sun, 25 Aug 2019 14:59:37 -0700	[thread overview]
Message-ID: <201908251451.73C6812E8@keescook> (raw)
In-Reply-To: <20190822205533.4877-1-david.abdurachmanov@sifive.com>

On Thu, Aug 22, 2019 at 01:55:22PM -0700, David Abdurachmanov wrote:
> This patch was extensively tested on Fedora/RISCV (applied by default on
> top of 5.2-rc7 kernel for <2 months). The patch was also tested with 5.3-rc
> on QEMU and SiFive Unleashed board.

Oops, I see the mention of QEMU here. Where's the best place to find
instructions on creating a qemu riscv image/environment?

> There is one failing kernel selftest: global.user_notification_signal

This test has been fragile (and is not arch-specific), so as long as
everything else is passing, I would call this patch ready to go. :)

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2019-08-28 17:37 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 20:55 [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER David Abdurachmanov
2019-08-22 20:55 ` David Abdurachmanov
2019-08-23 22:54 ` Carlos Eduardo de Paula
2019-08-23 22:54   ` Carlos Eduardo de Paula
2019-08-23 23:01 ` Carlos Eduardo de Paula
2019-08-23 23:01   ` Carlos Eduardo de Paula
2019-08-24  0:30 ` Paul Walmsley
2019-08-24  0:30   ` Paul Walmsley
2019-08-24  1:04   ` David Abdurachmanov
2019-08-24  1:04     ` David Abdurachmanov
2019-08-24  1:10     ` David Abdurachmanov
2019-08-24  1:10       ` David Abdurachmanov
2019-08-24  1:18     ` Paul Walmsley
2019-08-24  1:18       ` Paul Walmsley
2019-08-25 21:51   ` Kees Cook
2019-08-25 21:51     ` Kees Cook
2019-08-28 21:39     ` David Abdurachmanov
2019-08-28 21:39       ` David Abdurachmanov
2019-08-26 14:57   ` Tycho Andersen
2019-08-26 14:57     ` Tycho Andersen
2019-08-26 16:39     ` David Abdurachmanov
2019-08-26 16:39       ` David Abdurachmanov
2019-08-26 17:48       ` Kees Cook
2019-08-26 17:48         ` Kees Cook
2019-08-29  1:30         ` Paul Walmsley
2019-08-29  1:30           ` Paul Walmsley
2019-09-27 17:20           ` Kees Cook
2019-09-27 17:20             ` Kees Cook
2019-10-05  1:24             ` Paul Walmsley
2019-10-05  1:24               ` Paul Walmsley
2019-08-25 21:59 ` Kees Cook [this message]
2019-08-25 21:59   ` Kees Cook
2019-08-28 17:52   ` Andy Lutomirski
2019-08-28 17:52     ` Andy Lutomirski
2019-08-28 18:01     ` Kees Cook
2019-08-28 18:01       ` Kees Cook
2019-09-03 22:27     ` Palmer Dabbelt
2019-09-03 22:27       ` Palmer Dabbelt
2019-09-27 20:58       ` Andy Lutomirski
2019-09-27 20:58         ` Andy Lutomirski
2019-10-06 19:18         ` Andy Lutomirski
2019-10-06 19:18           ` Andy Lutomirski
2019-08-28 21:37   ` David Abdurachmanov
2019-08-28 21:37     ` David Abdurachmanov
2019-08-28 23:44     ` Kees Cook
2019-08-28 23:44       ` Kees Cook
2019-10-05  1:20 ` Paul Walmsley
2019-10-05  1:20   ` Paul Walmsley
2019-10-14 21:06   ` Paul Walmsley
2019-10-14 21:06     ` Paul Walmsley
2019-10-15 16:27     ` Kees Cook
2019-10-15 16:27       ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201908251451.73C6812E8@keescook \
    --to=keescook@chromium.org \
    --cc=Anup.Patel@wdc.com \
    --cc=alankao@andestech.com \
    --cc=alexios.zavras@intel.com \
    --cc=allison@lohutok.net \
    --cc=aou@eecs.berkeley.edu \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=david.abdurachmanov@gmail.com \
    --cc=david.abdurachmanov@sifive.com \
    --cc=kafai@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luto@amacapital.net \
    --cc=me@carlosedp.com \
    --cc=netdev@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=shuah@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=tglx@linutronix.de \
    --cc=vincentc@andestech.com \
    --cc=wad@chromium.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.