* [PATCH] ALSA: usb-audio: remove some dead code
@ 2019-08-26 13:45 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-08-26 13:45 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: Richard Fontana, alsa-devel, Hui Peng, kernel-janitors,
Wenwen Wang
We recently cleaned up the error handling in commit 52c3e317a857 ("ALSA:
usb-audio: Unify the release of usb_mixer_elem_info objects") but
accidentally left this stray return.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/usb/mixer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index a0468c4a6326..a607577f0097 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -2633,7 +2633,6 @@ static int parse_audio_selector_unit(struct mixer_build *state, int unitid,
usb_audio_err(state->chip, "cannot malloc kcontrol\n");
err = -ENOMEM;
goto error_name;
- return -ENOMEM;
}
kctl->private_value = (unsigned long)namelist;
kctl->private_free = usb_mixer_selector_elem_free;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ALSA: usb-audio: remove some dead code
@ 2019-08-26 13:45 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-08-26 13:45 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: Richard Fontana, alsa-devel, Hui Peng, kernel-janitors,
Wenwen Wang
We recently cleaned up the error handling in commit 52c3e317a857 ("ALSA:
usb-audio: Unify the release of usb_mixer_elem_info objects") but
accidentally left this stray return.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/usb/mixer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index a0468c4a6326..a607577f0097 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -2633,7 +2633,6 @@ static int parse_audio_selector_unit(struct mixer_build *state, int unitid,
usb_audio_err(state->chip, "cannot malloc kcontrol\n");
err = -ENOMEM;
goto error_name;
- return -ENOMEM;
}
kctl->private_value = (unsigned long)namelist;
kctl->private_free = usb_mixer_selector_elem_free;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ALSA: usb-audio: remove some dead code
2019-08-26 13:45 ` Dan Carpenter
@ 2019-08-26 13:52 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2019-08-26 13:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Wenwen Wang, kernel-janitors, Richard Fontana,
Hui Peng
On Mon, 26 Aug 2019 15:45:50 +0200,
Dan Carpenter wrote:
>
> We recently cleaned up the error handling in commit 52c3e317a857 ("ALSA:
> usb-audio: Unify the release of usb_mixer_elem_info objects") but
> accidentally left this stray return.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ALSA: usb-audio: remove some dead code
@ 2019-08-26 13:52 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2019-08-26 13:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Wenwen Wang, kernel-janitors, Richard Fontana,
Hui Peng
On Mon, 26 Aug 2019 15:45:50 +0200,
Dan Carpenter wrote:
>
> We recently cleaned up the error handling in commit 52c3e317a857 ("ALSA:
> usb-audio: Unify the release of usb_mixer_elem_info objects") but
> accidentally left this stray return.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-26 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-26 13:45 [PATCH] ALSA: usb-audio: remove some dead code Dan Carpenter
2019-08-26 13:45 ` Dan Carpenter
2019-08-26 13:52 ` Takashi Iwai
2019-08-26 13:52 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.